]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc
authorJosé Expósito <jose.exposito89@gmail.com>
Sun, 9 Jan 2022 19:24:31 +0000 (20:24 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 3 Feb 2022 09:28:54 +0000 (10:28 +0100)
commit544f5bc6b6972cfcec5276ba65d3e79fd630889d
tree24d48687b5d965d0df935e4670384f6936db2dc8
parent12c5b20633ce7321b289ea32bcd464719017259e
drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc

BugLink: https://bugs.launchpad.net/bugs/1959879
[ Upstream commit 170b22234d5495f5e0844246e23f004639ee89ba ]

The function performs a check on the "ctx" input parameter, however, it
is used before the check.

Initialize the "base" variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 4259ff7ae509e ("drm/msm/dpu: add support for pcc color block in dpu driver")
Addresses-Coverity-ID: 1493866 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Link: https://lore.kernel.org/r/20220109192431.135949-1-jose.exposito89@gmail.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c