]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 27 Dec 2021 18:09:18 +0000 (19:09 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Tue, 25 Jan 2022 11:05:29 +0000 (12:05 +0100)
commit6902bfbb9eb5c00e6023262ebae534db6454dddb
tree12a35d076f8766a7f94006e90cd73b51ca752dca
parent08a3c720d79f069a7e02e18de6545f960dd5e469
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()

BugLink: https://bugs.launchpad.net/bugs/1958977
commit 40a74870b2d1d3d44e13b3b73c6571dd34f5614d upstream.

'buffer_index_array' really looks like a bitmap. So it should be allocated
as such.
When kzalloc is called, a number of bytes is expected, but a number of
longs is passed instead.

In get(), if not enough memory is allocated, un-allocated memory may be
read or written.

So use bitmap_zalloc() to safely allocate the correct memory size and
avoid un-expected behavior.

While at it, change the corresponding kfree() into bitmap_free() to keep
the semantic.

Fixes: ea2c9c9f6574 ("orangefs: bufmap rewrite")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/orangefs/orangefs-bufmap.c