]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
gpio: mpc8xxx: Fix a potential double iounmap call in 'mpc8xxx_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 Aug 2021 15:38:03 +0000 (17:38 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Tue, 31 Aug 2021 10:10:12 +0000 (12:10 +0200)
commit7d6588931ccd4c09e70a08175cf2e0cf7fc3b869
tree38e5b11c8bb4449c808543cda923c7c015c3949e
parent555bda42b0c1a5ffb72d3227c043e8afde778f1f
gpio: mpc8xxx: Fix a potential double iounmap call in 'mpc8xxx_probe()'

Commit 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support") has switched to a
managed version when dealing with 'mpc8xxx_gc->regs'. So the corresponding
'iounmap()' call in the error handling path and in the remove should be
removed to avoid a double unmap.

This also allows some simplification in the probe. All the error handling
paths related to managed resources can be direct returns and a NULL check
in what remains in the error handling path can be removed.

Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-mpc8xxx.c