]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: cpsw: Properly initialise struct page_pool_params
authorToke Høiland-Jørgensen <toke@redhat.com>
Mon, 24 Jan 2022 14:35:29 +0000 (15:35 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 3 Feb 2022 09:28:54 +0000 (10:28 +0100)
commit83fd7e6e648b25a9260cdd556e8419eaa38ce8f2
tree24ca6e2da5cad1aaa1c03a5495ddd4056cc29b1e
parent1a7cf00f96fe62f7f43d3e73a7b5e54fd77c7399
net: cpsw: Properly initialise struct page_pool_params

BugLink: https://bugs.launchpad.net/bugs/1959879
[ Upstream commit c63003e3d99761afb280add3b30de1cf30fa522b ]

The cpsw driver didn't properly initialise the struct page_pool_params
before calling page_pool_create(), which leads to crashes after the struct
has been expanded with new parameters.

The second Fixes tag below is where the buggy code was introduced, but
because the code was moved around this patch will only apply on top of the
commit in the first Fixes tag.

Fixes: c5013ac1dd0e ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv")
Fixes: 9ed4050c0d75 ("net: ethernet: ti: cpsw: add XDP support")
Reported-by: Colin Foster <colin.foster@in-advantage.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Tested-by: Colin Foster <colin.foster@in-advantage.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/ethernet/ti/cpsw_priv.c