]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ksmbd: fix error code in ndr_read_int32()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 30 Nov 2021 12:50:47 +0000 (15:50 +0300)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:49:45 +0000 (09:49 +0100)
commit9be9d730af3c06574b3579745ec7162f42536a0a
tree92920b07e7adb89a8fa44dadf5af9b75fc0a57a6
parent5c2ebc292223a4887fe96cc0b4af94485857d82d
ksmbd: fix error code in ndr_read_int32()

BugLink: https://bugs.launchpad.net/bugs/1956305
commit ef399469d9ceb9f2171cdd79863f9434b9fa3edc upstream.

This is a failure path and it should return -EINVAL instead of success.
Otherwise it could result in the caller using uninitialized memory.

Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
fs/ksmbd/ndr.c