]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
dmaengine: ptdma: Fix the error handling path in pt_core_init()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 5 Feb 2022 06:58:44 +0000 (07:58 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 7 Mar 2022 10:44:18 +0000 (11:44 +0100)
commitb8c0c5c64ef5717cefca1ebd91c3777243b9e599
tree8e72c80cb1f136012d5ba270f24d26e102c3e3f4
parentde666e9ea8bc9b2c9f7f0bb1dce7609006384964
dmaengine: ptdma: Fix the error handling path in pt_core_init()

BugLink: https://bugs.launchpad.net/bugs/1963890
commit 3c62fd3406e0b2277c76a6984d3979c7f3f1d129 upstream.

In order to free resources correctly in the error handling path of
pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
will leak and we will try to release things that have not been allocated
yet.

Also move a dev_err() to a place where it is more meaningful.

Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Sanjay R Mehta <sanju.mehta@amd.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/41a963a35173f89c874f5c44df5530dc09fea8da.1644044244.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/dma/ptdma/ptdma-dev.c