]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
phylib: fix potential use-after-free
authorMarek Behún <kabel@kernel.org>
Wed, 19 Jan 2022 16:27:48 +0000 (17:27 +0100)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 3 Feb 2022 09:28:52 +0000 (10:28 +0100)
commitb8c113fe74320d73c3ac0b97598044dcde317d73
tree4ff64bd484553d8115be05b5dc7227943e03069a
parent53d809e3285aa18d43ae2ab0cc1c717d0b1fb3cb
phylib: fix potential use-after-free

BugLink: https://bugs.launchpad.net/bugs/1959879
[ Upstream commit cbda1b16687580d5beee38273f6241ae3725960c ]

Commit bafbdd527d56 ("phylib: Add device reset GPIO support") added call
to phy_device_reset(phydev) after the put_device() call in phy_detach().

The comment before the put_device() call says that the phydev might go
away with put_device().

Fix potential use-after-free by calling phy_device_reset() before
put_device().

Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220119162748.32418-1-kabel@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/phy/phy_device.c