]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
PCI: xgene: Fix double free on init error
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 4 Apr 2017 19:32:26 +0000 (19:32 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 21 Apr 2017 08:12:37 +0000 (10:12 +0200)
commit06f3250f362125920521c3e5a51c9196bdaffde3
tree642930a2b8457db0ee4bf7844c9a8f9c564b88f4
parent7da7929753edbfa3b5a7dffa5f47b132ab626147
PCI: xgene: Fix double free on init error

BugLink: http://bugs.launchpad.net/bugs/1682130
[ Upstream commit 1ded56df3247d358390ae6dc09ccee620262ac5f ]

The "port" variable was allocated with devm_kzalloc() so if we free it with
kfree() it will be freed twice.  Also I changed it to propogate the error
from devm_ioremap_resource() instead of returning -ENOMEM.

Fixes: c5d460396100 ("PCI: Add MCFG quirks for X-Gene host controller")
Also-posted-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Tanmay Inamdar <tinamdar@apm.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/pci/host/pci-xgene.c