]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash
authorMauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Thu, 26 Jan 2017 00:07:06 +0000 (22:07 -0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 1 Feb 2017 03:25:32 +0000 (22:25 -0500)
commit2780f3c8f0233de90b6b47a23fc422b7780c5436
tree1174ed10ddfcbe0b89e1d37fbe004d9d3e7b1edd
parent27873de99f2fecca0f6b257316489ef2a1d86ffd
scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash

Avoid that issuing a LIP as follows:

  find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done

triggers the following:

BUG: unable to handle kernel NULL pointer dereference at (null)
Call Trace:
 qla2x00_abort_all_cmds+0xed/0x140 [qla2xxx]
 qla2x00_abort_isp_cleanup+0x1e3/0x280 [qla2xxx]
 qla2x00_abort_isp+0xef/0x690 [qla2xxx]
 qla2x00_do_dpc+0x36c/0x880 [qla2xxx]
 kthread+0x10c/0x140

[mkp: consolidated Mauricio's and Bart's fixes]

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Fixes: 1535aa75a3d8 ("qla2xxx: fix invalid DMA access after command aborts in PCI device remove")
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c