]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
scsi: hisi_sas: add missing break in switch statement
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Mar 2017 11:12:22 +0000 (12:12 +0100)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Wed, 28 Jun 2017 14:24:06 +0000 (11:24 -0300)
commit31ec0fe84f7c9a7e21b0ae475df48808e5bce44e
treebb635be9a584826d7eae5b5d6b1b4fcbe4656809
parent1ae0b34996a9bcb3b2101075438f4b8da1db64dd
scsi: hisi_sas: add missing break in switch statement

BugLink: https://bugs.launchpad.net/bugs/1695999
It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION case
got accidentally removed in an earlier commit, as it stands, the
ts->stat and ts->open_rej_reason are being updated twice for this case
which looks incorrect.  Fix this by adding in the missing break
statement.

Detected by CoverityScan, CID#1422110 ("Missing break in switch")

Fixes: 634a9585f49c7 ("scsi: hisi_sas: process error codes according to their priority")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit a28b259b43914b04746184cec318c67bded7234c)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c