]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
MIPS: Avoid BUG warning in arch_check_elf
authorJames Cowgill <James.Cowgill@imgtec.com>
Tue, 11 Apr 2017 12:51:07 +0000 (13:51 +0100)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Wed, 17 May 2017 16:39:14 +0000 (13:39 -0300)
commit38b24846eec26dc627eb699c215b61949e5ebd60
treeb21cf50edadde376e7bc36339277baef0d2d09a4
parenta8748e8e52c8c35442b0fee75d201b007f17a7bc
MIPS: Avoid BUG warning in arch_check_elf

BugLink: http://bugs.launchpad.net/bugs/1688499
commit c46f59e90226fa5bfcc83650edebe84ae47d454b upstream.

arch_check_elf contains a usage of current_cpu_data that will call
smp_processor_id() with preemption enabled and therefore triggers a
"BUG: using smp_processor_id() in preemptible" warning when an fpxx
executable is loaded.

As a follow-up to commit b244614a60ab ("MIPS: Avoid a BUG warning during
prctl(PR_SET_FP_MODE, ...)"), apply the same fix to arch_check_elf by
using raw_current_cpu_data instead. The rationale quoted from the previous
commit:

"It is assumed throughout the kernel that if any CPU has an FPU, then
all CPUs would have an FPU as well, so it is safe to perform the check
with preemption enabled - change the code to use raw_ variant of the
check to avoid the warning."

Fixes: 46490b572544 ("MIPS: kernel: elf: Improve the overall ABI and FPU mode checks")
Signed-off-by: James Cowgill <James.Cowgill@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/15951/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
arch/mips/kernel/elf.c