]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
bcm2835-v4l2: Fix buffer overflow problem
authorDave Stevenson <dave.stevenson@raspberrypi.org>
Fri, 10 Mar 2017 14:43:15 +0000 (14:43 +0000)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 28 Aug 2017 18:30:27 +0000 (15:30 -0300)
commit6b0e32411ff00732a38eecd05d5cd4aed790a35f
tree48d01c413a35bbadea98a3b3eb07d12faf63dfda
parent972ea029f762415cde8c51c10a73702b5d5b0b61
bcm2835-v4l2: Fix buffer overflow problem

https://github.com/raspberrypi/linux/issues/1447
port_parameter_get() failed to account for the header
(u32 id and u32 size) in the size before memcpying
the response into the response buffer, so overrunning
the provided buffer by 8 bytes.

Account for those bytes, and also a belt-and-braces
check to ensure we never copy more than *value_size
bytes into value.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/media/platform/bcm2835/mmal-vchiq.c