]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
hwmon: (scpi) skip unsupported sensors properly
authorSudeep Holla <sudeep.holla@arm.com>
Wed, 28 Oct 2015 17:17:31 +0000 (17:17 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 16 Nov 2015 17:59:50 +0000 (09:59 -0800)
commitcef03d7e66bd70c4baf61dd2431cf8de250834de
treee8a2296d6f0cc62c2224dd849ccf908ef5e86848
parentd42d5b6f729929f2bbd17d22a2b223b7138470da
hwmon: (scpi) skip unsupported sensors properly

Currently it's assumed that firmware exports only the class of sensors
supported by the driver. However with newer firmware or SCPI protocol
revision, support for newer classes of sensors can be present.

The driver fails to probe with the following warning if an unsupported
class of sensor is encountered in the firmware.

sysfs: cannot create duplicate filename
'/devices/platform/scpi/scpi:sensors/hwmon/hwmon0/'
------------[ cut here ]------------
WARNING: at fs/sysfs/dir.c:31
Modules linked in:

CPU: 0 PID: 6 Comm: kworker/u12:0 Not tainted 4.3.0-rc7 #137
Hardware name: ARM Juno development board (r0) (DT)
Workqueue: deferwq deferred_probe_work_func
PC is at sysfs_warn_dup+0x54/0x78
LR is at sysfs_warn_dup+0x54/0x78

This patch fixes the above issue by skipping through the unsupported
class of SCPI sensors.

Fixes: 68acc77a2d51 ("hwmon: Support thermal zones registration for SCP temperature sensors")
Fixes: ea98b29a05e9 ("hwmon: Support sensors exported via ARM SCP interface")
Cc: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Punit Agrawal <punit.agrawal@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/scpi-hwmon.c