]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
net: fix socket refcounting in skb_complete_wifi_ack()
authorEric Dumazet <edumazet@google.com>
Sat, 4 Mar 2017 05:01:02 +0000 (21:01 -0800)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 22 Mar 2017 14:02:34 +0000 (08:02 -0600)
commitec721f0268d53ba6a693ef2b4da448daa2e9a93c
treef1a37e19a1bf16d864aad7de3e313cc89a90ad43
parent76d06ff43810cfa79aaefeac8e5e059728da5e06
net: fix socket refcounting in skb_complete_wifi_ack()

BugLink: http://bugs.launchpad.net/bugs/1675032
[ Upstream commit dd4f10722aeb10f4f582948839f066bebe44e5fb ]

TX skbs do not necessarily hold a reference on skb->sk->sk_refcnt
By the time TX completion happens, sk_refcnt might be already 0.

sock_hold()/sock_put() would then corrupt critical state, like
sk_wmem_alloc.

Fixes: bf7fa551e0ce ("mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/core/skbuff.c