]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
crypto: powerpc - Fix initialisation of crc32c context
authorDaniel Axtens <dja@axtens.net>
Fri, 3 Mar 2017 06:56:55 +0000 (17:56 +1100)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 22 Mar 2017 14:02:34 +0000 (08:02 -0600)
commitf3bb3c2ac7b6fc6cb5837a8c45ff8bba5df3a6bf
tree75f5f933801c299c4537e53ca1728ee9596560f3
parent011af505d0c089d6581a3405ed146acef0067de5
crypto: powerpc - Fix initialisation of crc32c context

BugLink: http://bugs.launchpad.net/bugs/1675032
commit aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 upstream.

Turning on crypto self-tests on a POWER8 shows:

    alg: hash: Test 1 failed for crc32c-vpmsum
    00000000: ff ff ff ff

Comparing the code with the Intel CRC32c implementation on which
ours is based shows that we are doing an init with 0, not ~0
as CRC32c requires.

This probably wasn't caught because btrfs does its own weird
open-coded initialisation.

Initialise our internal context to ~0 on init.

This makes the self-tests pass, and btrfs continues to work.

Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Cc: Anton Blanchard <anton@samba.org>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
arch/powerpc/crypto/crc32c-vpmsum_glue.c