]> git.proxmox.com Git - ovs.git/commit
compat: Initialize IPv4 reassembly secret timer
authorGreg Rose <gvrose8192@gmail.com>
Fri, 20 Jul 2018 01:48:31 +0000 (18:48 -0700)
committerBen Pfaff <blp@ovn.org>
Fri, 27 Jul 2018 18:37:46 +0000 (11:37 -0700)
commit8daf95ba359c27c098752fa87819e8cb1385da27
tree21fc962c96cce4a34e70f391e183b8121f848708
parentb1ca64f020f77388b10b47ba279bd5e0fba57dfd
compat: Initialize IPv4 reassembly secret timer

The RHEL 7 kernels expect the secret timer interval to be initialized
before calling the inet_frags_init() function.  By not initializing it
the inet_frags_secret_rebuild() function was running on every tick
rather than on the expected interval.  This caused occasional panics
from page faults when inet_frags_secret_rebuild() would try to rearm a
timer from the openvswitch kernel module which had just been removed.

Also remove the prior, and now unnecessary, work around.

VMware BZ 2094203

Fixes: 595e069a ("compat: Backport IPv4 reassembly.")
Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
datapath/datapath.c
datapath/linux/compat/ip_fragment.c
datapath/linux/compat/nf_conntrack_reasm.c