]> git.proxmox.com Git - proxmox-widget-toolkit.git/commit
form: combo grid: use correct method to initialize the picker
authorDominik Csapak <d.csapak@proxmox.com>
Fri, 31 Mar 2023 10:04:51 +0000 (12:04 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 12 Apr 2023 11:30:41 +0000 (13:30 +0200)
commit736c3457a268c66d16502c7832bd94aed17d1bf3
treee13df91cd1887f7c49016250304f433b950aeacc
parentc1a3b7f725d7ee0bc658b29c36e5dc2a3b71d298
form: combo grid: use correct method to initialize the picker

'createPicker' does create the picker, but saves no reference to it
in the owning field, Instead, 'getPicker' should be used for that,
since that does all the necessary initialization, and actually
assigns the created picker to the field's me.picker variable so that
the pickers lifetime can be successfully tracked and enforced.

Without this patch, we leak the picker being created every time a
combo grid is created.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
src/form/ComboGrid.js