move the "return early, because a request is already pending" into
the doLoad function, so that all calls to it underly the request
limiting, but note that such a new request is desired, and if so
schedule it once the current finishes. This ensures that scrolling
will always get honored, but does not produces multiple hanging
workers, at max one.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 16 Apr 2019 05:53:06 +0000 (05:53 +0000)]
node/TimeEdit: allow to 'search' time zone
follow the logic we use in file selectors of the PVE gui, i.e., allow
editable but force a match and do not allow blank, this lets
quick filter this big list instead of scrolling, and searching if
something appears or not, even if one is may not be sure if/how this
was sorted...
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
use the view, viewmodel, controller style code, which makes the logic
much more understandable
this adds two features to it, namely a viewBuffer range, which controls
the distance to the end of the data on which the panel loads the next data
and an optional failCallback, which will be used for the cephlog
Stoiko Ivanov [Thu, 21 Mar 2019 17:20:32 +0000 (18:20 +0100)]
change allowed v6 prefix-length to 128
Currently the frontend validation only allows values 8-120 as prefix-lengths for
ipv6-cidr notations.
Following commit 70ea22506939f9687e1146c0f35247cfbe9225b8 in pve-common, this
patch changes that value to 128, which, while seldomly seen in regular setups
is technically correct.
Problem was reported by a user in the forum - they needed to set a length of
125, because their provider supplies only smaller networks. [0]
Dominik Csapak [Thu, 21 Feb 2019 10:34:24 +0000 (11:34 +0100)]
fix popup behaviour in firefox with touchscreens on desktop
when the popup blocker is active, nw is undefined and nw.focus() throws
an error and the touchend event is not finished, causing
extjs to retry the touchevent and click handler, which tries to open
a popup which gets blocked here, and so on
PendingObjectGrid: fix display of deletion of multikey fields
we did only check if the first field of a mulitfield key is being deleted,
resulting in showing no pending change at all when deleting any other,
and as long as only deletions were taking place
also when deleting the 'main' key of a multikey field, we
showed the deletion of the whole line, even when already showing
a different pending line
Dominik Csapak [Tue, 6 Mar 2018 08:06:28 +0000 (09:06 +0100)]
remove gettext definition in Utils.js
this should not be here, rather where we include the language files
(like in pve), because this is not ecma conform and behaves very
different in different browsers (e.g. safari ignores the if check
completely and simply uses that function definition)
Dominik Csapak [Tue, 20 Feb 2018 08:48:19 +0000 (09:48 +0100)]
skip config property for cbind mixin
if we use a component with cbind in a static declaration,
we do not want to traverse the 'config' property, as this can lead
to properties of base classes which produce errors on copying
Dominik Csapak [Mon, 15 Jan 2018 13:11:02 +0000 (14:11 +0100)]
add task_desc_table and format_task_description from pve
since the Task is in the widget-toolkit, passing
a renderer/list a few levels of components down is not nice
and there are not *that* many strings in the task_desc_table,
we put it here, so that either pve and pmg can use them
ComboBoxes provided by UI frameworks normally show their selection
possibilities once focused, ExtJS does this too but not on editable
(and thus filterable) input fields. Add a logic which allows this too
and streamlines the behavior of ComboGrid/Box like components.
To avoid a glitch, where clicking the "picker trigger" (the down
arrow which normally toggles the selection picker) would first focus
the element - thus expanding it - and only then causing a toggle
which collapses it again, we overwrite the 'Ext.form.trigger.Trigger'
onMouseDown so that we can skip a expansion on this event.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 19 Dec 2017 07:16:14 +0000 (08:16 +0100)]
toolkit: fix #1516: mouse-scrolling of overflowhandlers in firefox
this is a workaround for scrolling in toolbars, etc. in firefox with
the mouse.
while the result is not very "pretty", it maintains the old behaviour
for all other browsers and makes it work in firefox
we may drop this when we update to a new extjs release
Thomas Lamprecht [Tue, 19 Dec 2017 07:16:13 +0000 (08:16 +0100)]
toolkit: fix #1510: don't scroll back to focus when view refreshes
adds a workaround, so that we restore the scroll position when we
restore the focus. Fixies an annoying issue where, if a user had an
ellemtn selected, scrolled down and then a store refresh re-rendered
the view it was scrolled back to the selected item and the user lost
his scrolling position.
Add also the 'jumpToFocus' flag to allow enabling the old behaviour
Thomas Lamprecht [Mon, 11 Dec 2017 10:18:14 +0000 (11:18 +0100)]
HelpButton: be backward compatible with PVE help mapping
pve-doc-generator used pveOnlineHelp as variable name while the
widget toolkit expects proxmoxOnlineHelp, allow both for now.
As its not quite clear when the switch to the widget toolkit happens
this is more flexible than changing the generator and adding a
versioned build dependency in pve-manager for it.
We normally do not bump pve-docs during releases either.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> CC: Dominik Csapak <d.csapak@proxmox.com>
commit acc9bf4752972ffd79af1c78510fcce24c2db959 (Close #1268: Show
migration start server and migration end server) introduced the
possibility to display additional information in the TaskViewer
window title. This change happened after the widget toolkit formed
and seems reasonable to have here, thus port it over.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>