fix some format security issues

[pve-cluster.git] / data / src / dcdb.c

diff --git a/data/src/dcdb.c b/data/src/dcdb.c
index 66d1b0fdec004599bc9f1d555d5f47ce4a2e9ce7..12abf1d1996a2eb019df32add61a6248a819db4a 100644 (file)
--- a/data/src/dcdb.c
+++ b/data/src/dcdb.c
@@ -632,8 +632,8 @@ dcdb_process_state_update(
        memdb_index_t *leaderidx = idx[leader];
        localsi->master = leaderidx;
 
-       GString *str = g_string_new("synced members:");
-       g_string_append_printf(str, " %d/%d", syncinfo->nodes[leader].nodeid, syncinfo->nodes[leader].pid);
+       GString *synced_member_ids = g_string_new(NULL);
+       g_string_append_printf(synced_member_ids, "%d/%d", syncinfo->nodes[leader].nodeid, syncinfo->nodes[leader].pid);
 
        for (int i = 0; i < syncinfo->node_count; i++) {
                dfsm_node_info_t *ni = &syncinfo->nodes[i];
@@ -643,14 +643,14 @@ dcdb_process_state_update(
                        if (leaderidx->bytes == idx[i]->bytes &&
                            memcmp(leaderidx, idx[i], leaderidx->bytes) == 0) {
                                ni->synced = 1;
-                               g_string_append_printf(str, ", %d/%d", ni->nodeid, ni->pid);
+                               g_string_append_printf(synced_member_ids, ", %d/%d", ni->nodeid, ni->pid);
                        }
                }
                if (dfsm_nodeid_is_local(dfsm, ni->nodeid, ni->pid)) 
                        localsi->idx = idx[i];
        }
-       cfs_message(str->str);
-       g_string_free(str, 1);
+       cfs_message("synced members: %s", synced_member_ids->str);
+       g_string_free(synced_member_ids, 1);
 
        /* send update */
        if (dfsm_nodeid_is_local(dfsm, syncinfo->nodes[leader].nodeid, syncinfo->nodes[leader].pid)) {