use base qw(PVE::CLIHandler);
-$SIG{'__WARN__'} = sub {
- my $err = $@;
- my $t = $_[0];
- chomp $t;
- print "$t\n";
- syslog('warning', "WARNING: %s", $t);
- $@ = $err;
-};
-
$ENV{'PATH'} = '/sbin:/bin:/usr/sbin:/usr/bin';
my $daemon_initialized = 0; # we only allow one instance
my $close_daemon_lock = sub {
my ($self) = @_;
+ return if !$self->{daemon_lock_fh};
+
close $self->{daemon_lock_fh};
delete $self->{daemon_lock_fh};
};
+my $log_err = sub {
+ my ($msg) = @_;
+ chomp $msg;
+ print STDERR "$msg\n";
+ syslog('err', "%s", $msg);
+};
+
+# call this if you fork() from child
+# Note: we already call this for workers, so it is only required
+# if you fork inside a simple daemon (max_workers == 0).
+sub after_fork_cleanup {
+ my ($self) = @_;
+
+ &$close_daemon_lock($self);
+
+ PVE::INotify::inotify_close();
+
+ for my $sig (qw(CHLD HUP INT TERM QUIT)) {
+ $SIG{$sig} = 'DEFAULT'; # restore default handler
+ # AnyEvent signals only works if $SIG{XX} is
+ # undefined (perl event loop)
+ delete $SIG{$sig}; # so that we can handle events with AnyEvent
+ }
+}
+
my $lockpidfile = sub {
my ($self) = @_;
my $lkfn = $self->{pidfile} . ".lock";
- $self->{daemon_lock_fh} = IO::File->new(">>$lkfn");
+ my $waittime = 0;
+
+ if (my $fd = $self->{env_pve_lock_fd}) {
+
+ $self->{daemon_lock_fh} = IO::Handle->new_from_fd($fd, "a");
+
+ } else {
+
+ $waittime = 5;
+ $self->{daemon_lock_fh} = IO::File->new(">>$lkfn");
+ }
+
if (!$self->{daemon_lock_fh}) {
- my $msg = "can't aquire lock on file '$lkfn' - $!";
- syslog ('err', $msg);
- die "ERROR: $msg\n";
+ die "can't open lock '$lkfn' - $!\n";
}
- for (my $i = 0; $i < 5; $i ++) {
+ for (my $i = 0; $i < $waittime; $i ++) {
return if flock ($self->{daemon_lock_fh}, LOCK_EX|LOCK_NB);
sleep(1);
}
if (!flock ($self->{daemon_lock_fh}, LOCK_EX|LOCK_NB)) {
&$close_daemon_lock($self);
- my $msg = "can't aquire lock '$lkfn' - $!";
- syslog ('err', $msg);
- die "ERROR: $msg\n";
+ my $err = $!;
+
+ my ($running, $pid) = $self->running();
+ if ($running) {
+ die "can't aquire lock '$lkfn' - daemon already started (pid = $pid)\n";
+ } else {
+ die "can't aquire lock '$lkfn' - $err\n";
+ }
}
};
my $pidfile = $self->{pidfile};
- if (!open (PIDFH, ">$pidfile")) {
- my $msg = "can't open pid file '$pidfile' - $!";
- syslog ('err', $msg);
- die "ERROR: $msg\n";
- }
+ die "can't open pid file '$pidfile' - $!\n" if !open (PIDFH, ">$pidfile");
+
print PIDFH "$$\n";
close (PIDFH);
};
} else {
$0 = "$self->{name} worker";
- &$close_daemon_lock($self);
-
- PVE::INotify::inotify_close();
-
- for my $sig (qw(CHLD HUP INT TERM QUIT)) {
- $SIG{$sig} = 'DEFAULT'; # restore default handler
- # AnyEvent signals only works if $SIG{XX} is
- # undefined (perl event loop)
- delete $SIG{$sig}; # so that we can handle events with AnyEvent
- }
+ $self->after_fork_cleanup();
eval { $self->run(); };
if (my $err = $@) {
my $server_run = sub {
my ($self, $debug) = @_;
+ # fixme: handle restart lockfd
&$lockpidfile($self);
- # run in background
- my $spid;
+ # remove FD_CLOEXEC bit to reuse on exec
+ $self->{daemon_lock_fh}->fcntl(Fcntl::F_SETFD(), 0);
- my $restart = $ENV{RESTART_PVE_DAEMON};
+ $ENV{PVE_DAEMON_LOCK_FD} = $self->{daemon_lock_fh}->fileno;
- delete $ENV{RESTART_PVE_DAEMON};
+ # run in background
+ my $spid;
$self->{debug} = 1 if $debug;
open STDOUT, '>/dev/null' || die "can't write /dev/null";
}
- if (!$restart && !$debug) {
+ if (!$self->{env_restart_pve_daemon} && !$debug) {
PVE::INotify::inotify_close();
$spid = fork();
if (!defined ($spid)) {
- my $msg = "can't put server into background - fork failed";
- syslog('err', $msg);
- die "ERROR: $msg\n";
+ die "can't put server into background - fork failed";
} elsif ($spid) { # parent
exit (0);
}
PVE::INotify::inotify_init();
}
- &$writepidfile($self);
-
- POSIX::setsid();
-
- if ($restart) {
+ if ($self->{env_restart_pve_daemon}) {
syslog('info' , "restarting server");
} else {
+ &$writepidfile($self);
syslog('info' , "starting server");
}
+ POSIX::setsid();
+
open STDERR, '>&STDOUT' || die "can't close STDERR\n";
my $old_sig_term = $SIG{TERM};
sub new {
my ($this, $name, $cmdline, %params) = @_;
- die "please run as root\n" if !$ENV{RESTART_PVE_DAEMON} && ($> != 0);
+ $name = 'daemon' if !$name; # should not happen
- die "missing name" if !$name;
+ initlog($name);
- die "can't create more that one PVE::Daemon" if $daemon_initialized;
- $daemon_initialized = 1;
+ my $self;
- PVE::INotify::inotify_init();
+ eval {
- initlog($name);
+ my $restart = $ENV{RESTART_PVE_DAEMON};
+ delete $ENV{RESTART_PVE_DAEMON};
- my $class = ref($this) || $this;
-
- my $self = bless {
- name => $name,
- run_dir => '/var/run',
- workers => {},
- }, $class;
-
- foreach my $opt (keys %params) {
- my $value = $params{$opt};
- if ($opt eq 'restart_on_error') {
- $self->{$opt} = $value;
- } elsif ($opt eq 'stop_wait_time') {
- $self->{$opt} = $value;
- } elsif ($opt eq 'run_dir') {
- $self->{$opt} = $value;
- } elsif ($opt eq 'max_workers') {
- $self->{$opt} = $value;
- } else {
- die "unknown option '$opt'";
+ my $lockfd = $ENV{PVE_DAEMON_LOCK_FD};
+ delete $ENV{PVE_DAEMON_LOCK_FD};
+
+ if (defined($lockfd)) {
+ $lockfd =~ m/^(\d+)$/;
+ $lockfd = $1; # untaint
}
- }
- $self->{pidfile} = "$self->{run_dir}/${name}.pid";
+ die "please run as root\n" if !$restart && ($> != 0);
- $self->{nodename} = PVE::INotify::nodename();
+ die "can't create more that one PVE::Daemon" if $daemon_initialized;
+ $daemon_initialized = 1;
- $self->{cmdline} = [];
+ PVE::INotify::inotify_init();
- foreach my $el (@$cmdline) {
- $el =~ m/^(.*)$/; # untaint
- push @{$self->{cmdline}}, $1;
- }
+ my $class = ref($this) || $this;
+
+ $self = bless {
+ name => $name,
+ run_dir => '/var/run',
+ env_restart_pve_daemon => $restart,
+ env_pve_lock_fd => $lockfd,
+ workers => {},
+ }, $class;
+
+ foreach my $opt (keys %params) {
+ my $value = $params{$opt};
+ if ($opt eq 'restart_on_error') {
+ $self->{$opt} = $value;
+ } elsif ($opt eq 'stop_wait_time') {
+ $self->{$opt} = $value;
+ } elsif ($opt eq 'run_dir') {
+ $self->{$opt} = $value;
+ } elsif ($opt eq 'max_workers') {
+ $self->{$opt} = $value;
+ } else {
+ die "unknown daemon option '$opt'\n";
+ }
+ }
+
+ $self->{pidfile} = "$self->{run_dir}/${name}.pid";
+
+ $self->{nodename} = PVE::INotify::nodename();
+
+ $self->{cmdline} = [];
- $0 = $name;
+ foreach my $el (@$cmdline) {
+ $el =~ m/^(.*)$/; # untaint
+ push @{$self->{cmdline}}, $1;
+ }
+
+ $0 = $name;
+ };
+ if (my $err = $@) {
+ &$log_err($err);
+ exit(-1);
+ }
return $self;
}
sub start {
my ($self, $debug) = @_;
- &$server_run($self, $debug);
+ eval { &$server_run($self, $debug); };
+ if (my $err = $@) {
+ &$log_err("start failed - $err");
+ exit(-1);
+ }
}
my $read_pid = sub {
}
if (-f $self->{pidfile}) {
- # try to get the lock
- &$lockpidfile($self);
- &$server_cleanup($self);
+ eval {
+ # try to get the lock
+ &$lockpidfile($self);
+ &$server_cleanup($self);
+ };
+ if (my $err = $@) {
+ &$log_err("cleanup failed - $err");
+ }
}
}
my $reload_daemon = sub {
my ($self, $use_hup) = @_;
- if (my $restart = $ENV{RESTART_PVE_DAEMON}) {
+ if ($self->{env_restart_pve_daemon}) {
$self->start();
} else {
my ($running, $pid) = $self->running();
projects / pve-common.git / blobdiff