$self->{storecfg} = PVE::Storage::config();
- # test is VM exist
+ # test if CT exists
my $conf = $self->{vmconf} = PVE::LXC::Config->load_config($vmid);
PVE::LXC::Config->check_lock($conf);
if (PVE::LXC::check_running($vmid)) {
die "lxc live migration is currently not implemented\n";
- die "cant migrate running container without --online\n" if !$online;
+ die "can't migrate running container without --online\n" if !$online;
$running = 1;
}
- PVE::LXC::foreach_mountpoint($conf, sub {
+ my $force = $self->{opts}->{force} // 0;
+ my $need_activate = [];
+
+ PVE::LXC::Config->foreach_mountpoint($conf, sub {
my ($ms, $mountpoint) = @_;
my $volid = $mountpoint->{volume};
+ my $type = $mountpoint->{type};
+
+ # skip dev/bind mps when forced / shared
+ if ($type ne 'volume') {
+ if ($force) {
+ warn "-force is deprecated, please use the 'shared' property on individual non-volume mount points instead!\n";
+ return;
+ }
+ if ($mountpoint->{shared}) {
+ return;
+ } else {
+ die "cannot migrate local $type mount point '$ms'\n";
+ }
+ }
+
my ($storage, $volname) = PVE::Storage::parse_volume_id($volid, 1) if $volid;
die "can't determine assigned storage for mountpoint '$ms'\n" if !$storage;
my $scfg = PVE::Storage::storage_check_node($self->{storecfg}, $storage);
PVE::Storage::storage_check_node($self->{storecfg}, $storage, $self->{node});
- die "unable to migrate local mountpoint '$volid' while CT is running"
- if !$scfg->{shared} && $running;
+
+ if ($scfg->{shared}) {
+ # PVE::Storage::activate_storage checks this for non-shared storages
+ my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
+ warn "Used shared storage '$storage' is not online on source node!\n"
+ if !$plugin->check_connection($storage, $scfg);
+ } else {
+ # only activate if not shared
+ push @$need_activate, $volid;
+
+ die "unable to migrate local mountpoint '$volid' while CT is running"
+ if $running;
+ }
});
- my $volid_list = PVE::LXC::get_vm_volumes($conf);
- PVE::Storage::activate_volumes($self->{storecfg}, $volid_list);
+ PVE::Storage::activate_volumes($self->{storecfg}, $need_activate);
# todo: test if VM uses local resources
$self->log('info', "container is running - using online migration");
}
- $self->{volumes} = [];
+ $self->{volumes} = []; # list of already migrated volumes
+ my $volhash = {}; # 'config', 'snapshot' or 'storage' for local volumes
+ my $volhash_errors = {};
+ my $abort = 0;
- PVE::LXC::foreach_mountpoint($conf, sub {
- my ($ms, $mountpoint) = @_;
+ my $log_error = sub {
+ my ($msg, $volid) = @_;
+
+ $volhash_errors->{$volid} = $msg if !defined($volhash_errors->{$volid});
+ $abort = 1;
+ };
+
+ my $test_volid = sub {
+ my ($volid, $snapname) = @_;
+
+ return if !$volid;
+
+ my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
+
+ # check if storage is available on both nodes
+ my $scfg = PVE::Storage::storage_check_node($self->{storecfg}, $sid);
+ PVE::Storage::storage_check_node($self->{storecfg}, $sid, $self->{node});
+
+ if ($scfg->{shared}) {
+ $self->log('info', "volume '$volid' is on shared storage '$sid'")
+ if !$snapname;
+ return;
+ }
+
+ $volhash->{$volid} = defined($snapname) ? 'snapshot' : 'config';
+
+ my ($path, $owner) = PVE::Storage::path($self->{storecfg}, $volid);
+
+ die "owned by other guest (owner = $owner)\n"
+ if !$owner || ($owner != $self->{vmid});
+
+ if (defined($snapname)) {
+ # we cannot migrate shapshots on local storage
+ # exceptions: 'zfspool'
+ if (($scfg->{type} eq 'zfspool')) {
+ return;
+ }
+ die "non-migratable snapshot exists\n";
+ }
+ };
+
+ my $test_mp = sub {
+ my ($ms, $mountpoint, $snapname) = @_;
my $volid = $mountpoint->{volume};
- my ($storage, $volname) = PVE::Storage::parse_volume_id($volid);
- my $scfg = PVE::Storage::storage_check_node($self->{storecfg}, $storage);
+ # already checked in prepare
+ if ($mountpoint->{type} ne 'volume') {
+ $self->log('info', "ignoring shared '$mountpoint->{type}' mount point '$ms' ('$volid')")
+ if !$snapname;
+ return;
+ }
+
+ eval {
+ &$test_volid($volid, $snapname);
+ };
- if (!$scfg->{shared}) {
+ &$log_error($@, $volid) if $@;
+ };
- $self->log('info', "copy mointpoint '$ms' ($volid) to node ' $self->{node}'");
- PVE::Storage::storage_migrate($self->{storecfg}, $volid, $self->{nodeip}, $storage);
- push @{$self->{volumes}}, $volid;
+ # first unused / lost volumes owned by this container
+ my @sids = PVE::Storage::storage_ids($self->{storecfg});
+ foreach my $storeid (@sids) {
+ my $scfg = PVE::Storage::storage_config($self->{storecfg}, $storeid);
+ next if $scfg->{shared};
+ next if !PVE::Storage::storage_check_enabled($self->{storecfg}, $storeid, undef, 1);
+
+ # get list from PVE::Storage (for unused volumes)
+ my $dl = PVE::Storage::vdisk_list($self->{storecfg}, $storeid, $vmid);
+
+ next if @{$dl->{$storeid}} == 0;
+
+ # check if storage is available on target node
+ PVE::Storage::storage_check_node($self->{storecfg}, $storeid, $self->{node});
+
+ PVE::Storage::foreach_volid($dl, sub {
+ my ($volid, $sid, $volname) = @_;
+
+ $volhash->{$volid} = 'storage';
+ });
+ }
+
+ # then all volumes referenced in snapshots
+ foreach my $snapname (keys %{$conf->{snapshots}}) {
+ &$test_volid($conf->{snapshots}->{$snapname}->{'vmstate'}, 0, undef)
+ if defined($conf->{snapshots}->{$snapname}->{'vmstate'});
+ PVE::LXC::Config->foreach_mountpoint($conf->{snapshots}->{$snapname}, $test_mp, $snapname);
+ }
+
+ # finally all currently used volumes
+ PVE::LXC::Config->foreach_mountpoint($conf, $test_mp);
+
+
+ # additional checks for local storage
+ foreach my $volid (keys %$volhash) {
+ eval {
+ my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
+ my $scfg = PVE::Storage::storage_config($self->{storecfg}, $sid);
+
+ my $migratable = ($scfg->{type} eq 'dir') || ($scfg->{type} eq 'zfspool') ||
+ ($scfg->{type} eq 'lvmthin') || ($scfg->{type} eq 'lvm');
+
+ die "storage type '$scfg->{type}' not supported\n"
+ if !$migratable;
+
+ # image is a linked clone on local storage, se we can't migrate.
+ if (my $basename = (PVE::Storage::parse_volname($self->{storecfg}, $volid))[3]) {
+ die "clone of '$basename'";
+ }
+ };
+ &$log_error($@, $volid) if $@;
+ }
+
+ foreach my $volid (sort keys %$volhash) {
+ if ($volhash->{$volid} eq 'storage') {
+ $self->log('info', "found local volume '$volid' (via storage)\n");
+ } elsif ($volhash->{$volid} eq 'config') {
+ $self->log('info', "found local volume '$volid' (in current VM config)\n");
+ } elsif ($volhash->{$volid} eq 'snapshot') {
+ $self->log('info', "found local volume '$volid' (referenced by snapshot(s))\n");
} else {
- $self->log('info', "mointpoint '$ms' is on shared storage '$storage'");
+ $self->log('info', "found local volume '$volid'\n");
}
- });
+ }
+
+ foreach my $volid (sort keys %$volhash_errors) {
+ $self->log('warn', "can't migrate local volume '$volid': $volhash_errors->{$volid}");
+ }
+
+ if ($abort) {
+ die "can't migrate CT - check log\n";
+ }
+
+ foreach my $volid (keys %$volhash) {
+ my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
+ push @{$self->{volumes}}, $volid;
+ PVE::Storage::storage_migrate($self->{storecfg}, $volid, $self->{nodeip}, $sid);
+ }
my $conffile = PVE::LXC::Config->config_file($vmid);
my $newconffile = PVE::LXC::Config->config_file($vmid, $self->{node});
PVE::LXC::umount_all($vmid, $self->{storecfg}, $conf);
#to be sure there are no active volumes
- my $vollist = PVE::LXC::get_vm_volumes($conf);
+ my $vollist = PVE::LXC::Config->get_vm_volumes($conf);
PVE::Storage::deactivate_volumes($self->{storecfg}, $vollist);
# move config
projects / pve-container.git / blobdiff