]> git.proxmox.com Git - pve-container.git/commit
fix #3161: snapshot creation: only check volumes for fsfreeze
authorStoiko Ivanov <s.ivanov@proxmox.com>
Mon, 23 Nov 2020 10:12:29 +0000 (11:12 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 23 Nov 2020 12:07:24 +0000 (13:07 +0100)
commit7a8591e8ca262b02e7ce2f299d4c05ab05f070ba
tree139af0a9a4917e10b439c7b6a5d21e03542814a0
parent3d27198ec07127ef55dac2b153be465f3c648309
fix #3161: snapshot creation: only check volumes for fsfreeze

When considering mountpoints for running 'fsfreeze' before snapshot
creation, commit 8463099d99273561c46398bf02206b4d9d431bc5 did not
only consider volumes created by our storage-stack, but also
bindmounts and devmounts (directly mounting a blockdevice).

This led to PVE::Storage::parse_volume_id failing on those
mountpoints.

Since the fsfreeze call is best-effort and only run for specific
storageplugins, we can simply skip non-volume mountpoints, when
gathering the list of volumes to call fsfreeze on.

Tested with a container with a bind mount.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
src/PVE/LXC/Config.pm