]> git.proxmox.com Git - pve-eslint.git/log
pve-eslint.git
2 years agobump version to 8.3.0-1
Thomas Lamprecht [Wed, 1 Dec 2021 12:44:44 +0000 (13:44 +0100)]
bump version to 8.3.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agofixup! import 8.3.0 source
Thomas Lamprecht [Wed, 1 Dec 2021 12:44:30 +0000 (13:44 +0100)]
fixup! import 8.3.0 source

2 years agocommit build of 8.3.0
Thomas Lamprecht [Wed, 1 Dec 2021 12:44:18 +0000 (13:44 +0100)]
commit build of 8.3.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoimport 8.3.0 source
Thomas Lamprecht [Wed, 1 Dec 2021 12:39:06 +0000 (13:39 +0100)]
import 8.3.0 source

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agobuild upstream to umd
Thomas Lamprecht [Mon, 30 Aug 2021 10:54:23 +0000 (12:54 +0200)]
build upstream to umd

as we want to avoid requiring npm et al for every build, this is also
effectively vendoring all in, so easier to avoid supply-chain attacks

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agouse worker_threads for linting
Dominik Csapak [Mon, 19 Jul 2021 10:13:12 +0000 (12:13 +0200)]
use worker_threads for linting

instead linting all files in the main thread, use worker threads
for that (4 by default) and add the '-t' switch to able to control that

a basic benchmark of eslint of pve-manager showed some performance
gains:

Benchmark #1: Current
  Time (mean ± σ):      6.468 s ±  0.116 s    [User: 9.803 s, System: 0.333 s]
  Range (min … max):    6.264 s …  6.647 s    10 runs

Benchmark #2: 2Threads
  Time (mean ± σ):      4.509 s ±  0.106 s    [User: 12.706 s, System: 0.530 s]
  Range (min … max):    4.335 s …  4.674 s    10 runs

Benchmark #3: 4Threads
  Time (mean ± σ):      3.471 s ±  0.033 s    [User: 16.390 s, System: 0.630 s]
  Range (min … max):    3.431 s …  3.542 s    10 runs

Benchmark #4: 8Threads
  Time (mean ± σ):      2.880 s ±  0.044 s    [User: 22.454 s, System: 0.938 s]
  Range (min … max):    2.813 s …  2.964 s    10 runs

Summary
  '8Threads' ran
    1.21 ± 0.02 times faster than '4Threads'
    1.57 ± 0.04 times faster than '2Threads'
    2.25 ± 0.05 times faster than 'Current'

after 8 threads, there were no real performance benefits since the
overhead to load the module seems to be the biggest factor.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoremove unnecessary eslint.js
Dominik Csapak [Mon, 19 Jul 2021 10:10:39 +0000 (12:10 +0200)]
remove unnecessary eslint.js

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoship proper nodejs module 'pve-eslint'
Dominik Csapak [Mon, 19 Jul 2021 10:07:21 +0000 (12:07 +0200)]
ship proper nodejs module 'pve-eslint'

instead of concatenating the eslint module into our app.js, ship
a 'pve-eslint' module that exports the built eslint module

to do this, we have to leave the module type on 'umd' instead of
changing to 'var' so that nodejs can properly import it.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agobump version to 7.28.0-1
Thomas Lamprecht [Wed, 9 Jun 2021 14:40:31 +0000 (16:40 +0200)]
bump version to 7.28.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoset cwd of CLIEngine to process.cwd()
Dominik Csapak [Wed, 9 Jun 2021 11:49:27 +0000 (13:49 +0200)]
set cwd of CLIEngine to process.cwd()

it seems it now defaults to '/' as the current working dir, but we
assume the cwd of the process

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2 years agoswitch to es2020 for bullseyse
Thomas Lamprecht [Wed, 9 Jun 2021 09:05:48 +0000 (11:05 +0200)]
switch to es2020 for bullseyse

at least in theory this should be enough

https://eslint.org/docs/user-guide/configuring/language-options#specifying-environments

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoactually build upstream release 7.28.0
Thomas Lamprecht [Wed, 9 Jun 2021 09:05:28 +0000 (11:05 +0200)]
actually build upstream release 7.28.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoimport eslint 7.28.0
Thomas Lamprecht [Tue, 8 Jun 2021 09:43:11 +0000 (11:43 +0200)]
import eslint 7.28.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agobuildsys: change upload dist to bullseye
Thomas Lamprecht [Tue, 8 Jun 2021 09:18:30 +0000 (11:18 +0200)]
buildsys: change upload dist to bullseye

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2 years agoadd small script to help extracting more relevant changes
Thomas Lamprecht [Tue, 8 Jun 2021 09:35:11 +0000 (11:35 +0200)]
add small script to help extracting more relevant changes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump version to 7.18.0-1
Thomas Lamprecht [Tue, 19 Jan 2021 16:09:00 +0000 (17:09 +0100)]
bump version to 7.18.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoswitch to ECMA version 2018
Thomas Lamprecht [Tue, 19 Jan 2021 16:02:53 +0000 (17:02 +0100)]
switch to ECMA version 2018

Mainly to enable the rest/spread operator (...variable).

Other new features include asynchronous iteration,
Promise.prototype.finally and additions to RegExp (look behind, named
capture groups, s flag)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoimport eslint 7.18.0
Thomas Lamprecht [Tue, 19 Jan 2021 15:04:13 +0000 (16:04 +0100)]
import eslint 7.18.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump version to 7.12.1-1
Thomas Lamprecht [Thu, 29 Oct 2020 11:21:53 +0000 (12:21 +0100)]
bump version to 7.12.1-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoimport 7.12.1 upstream release
Thomas Lamprecht [Thu, 22 Oct 2020 11:01:02 +0000 (13:01 +0200)]
import 7.12.1 upstream release

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoexit with error also on warnings
Thomas Lamprecht [Thu, 22 Oct 2020 10:47:58 +0000 (12:47 +0200)]
exit with error also on warnings

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoapp: eslint fixes
Thomas Lamprecht [Thu, 22 Oct 2020 10:46:52 +0000 (12:46 +0200)]
app: eslint fixes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump version to 7.2.0-1
Thomas Lamprecht [Sat, 6 Jun 2020 14:01:26 +0000 (16:01 +0200)]
bump version to 7.2.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoimport and build new upstream release 7.2.0
Thomas Lamprecht [Sat, 6 Jun 2020 13:59:12 +0000 (15:59 +0200)]
import and build new upstream release 7.2.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoship an example config and extend-rules sample files
Thomas Lamprecht [Sat, 6 Jun 2020 10:56:33 +0000 (12:56 +0200)]
ship an example config and extend-rules sample files

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoadd HelpInfo variables to globals
Thomas Lamprecht [Sat, 6 Jun 2020 14:54:42 +0000 (16:54 +0200)]
add HelpInfo variables to globals

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agono-mixed-operators: do not check basic math precedence
Thomas Lamprecht [Sat, 6 Jun 2020 14:41:35 +0000 (16:41 +0200)]
no-mixed-operators: do not check basic math precedence

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoimprove no-extra-parens rule
Thomas Lamprecht [Sat, 6 Jun 2020 13:19:39 +0000 (15:19 +0200)]
improve no-extra-parens rule

We use both, 'no-extra-parens' and 'no-mixed-operators' rules and
those can conflict. Thus follow eslints recommendation[0] and allow
parenthesis in nestedBinaryExpressions to avoid the linter
complaining either way. Do this also fo enforceForArrowConditionals
as there I saw the issue already in practice for me.

[0]: https://eslint.org/docs/rules/no-mixed-operators#rule-details

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agotry to improve object-curly-newline
Thomas Lamprecht [Sat, 6 Jun 2020 12:51:01 +0000 (14:51 +0200)]
try to improve object-curly-newline

for me consistency on open/close is most important..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodisable 'no-else-return' rule
Thomas Lamprecht [Sat, 6 Jun 2020 12:04:10 +0000 (14:04 +0200)]
disable 'no-else-return' rule

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodisable "no-underscore-dangle" as used in explicit unused variables
Thomas Lamprecht [Sat, 6 Jun 2020 11:36:39 +0000 (13:36 +0200)]
disable "no-underscore-dangle" as used in explicit unused variables

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agodisable semi-style for now
Thomas Lamprecht [Sat, 6 Jun 2020 11:03:29 +0000 (13:03 +0200)]
disable semi-style for now

In generally we follow it but we want also to allow statements like:

let foo = bar
    ? 'baz'
    : 'foz'
    ;

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoadapt some rules
Thomas Lamprecht [Sat, 6 Jun 2020 10:50:21 +0000 (12:50 +0200)]
adapt some rules

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoadd --output-config CLI option
Thomas Lamprecht [Sat, 6 Jun 2020 10:49:55 +0000 (12:49 +0200)]
add --output-config CLI option

can help to get the default config for adaption

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoadd possibiliity to extend base config over CLI
Thomas Lamprecht [Sat, 6 Jun 2020 10:13:04 +0000 (12:13 +0200)]
add possibiliity to extend base config over CLI

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agofactor out path expansion
Thomas Lamprecht [Sat, 6 Jun 2020 10:12:30 +0000 (12:12 +0200)]
factor out path expansion

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agono-unused-vars: allow starting with _underscore
Thomas Lamprecht [Tue, 26 May 2020 09:53:57 +0000 (11:53 +0200)]
no-unused-vars: allow starting with _underscore

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agocheckin build of 7.1.0
Thomas Lamprecht [Mon, 25 May 2020 11:00:56 +0000 (13:00 +0200)]
checkin build of 7.1.0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoupdate to 7.1.0 sources
Thomas Lamprecht [Mon, 25 May 2020 11:00:39 +0000 (13:00 +0200)]
update to 7.1.0 sources

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agobump version to 7.0.0-1
Thomas Lamprecht [Fri, 22 May 2020 12:32:21 +0000 (14:32 +0200)]
bump version to 7.0.0-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
3 years agoupgrade to v7.0.0
Dominik Csapak [Fri, 22 May 2020 11:37:30 +0000 (13:37 +0200)]
upgrade to v7.0.0

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agobump version to 7.0.0~alpha3-2
Thomas Lamprecht [Fri, 10 Apr 2020 15:02:45 +0000 (17:02 +0200)]
bump version to 7.0.0~alpha3-2

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoignore unused 'me'
Dominik Csapak [Fri, 10 Apr 2020 15:06:08 +0000 (17:06 +0200)]
ignore unused 'me'

sometimes we want to have it just in case

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoprint relative file path
Thomas Lamprecht [Fri, 10 Apr 2020 14:49:37 +0000 (16:49 +0200)]
print relative file path

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agore do output formatting, save some lines
Thomas Lamprecht [Fri, 10 Apr 2020 14:38:40 +0000 (16:38 +0200)]
re do output formatting, save some lines

Moving the message and the info if something is auto-fixable to a
single line, saving ~ 2/3rd of output lines.

The auto-fixable got replaced with a (*) marker, it's not ideal but
IMO OK; explain what it means in the summaries "X issues marked with
(*) could be auto-fixed"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoeslint: autofixes
Dominik Csapak [Fri, 10 Apr 2020 06:26:51 +0000 (08:26 +0200)]
eslint: autofixes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoallow '!!' for boolean conversion
Dominik Csapak [Fri, 10 Apr 2020 06:24:59 +0000 (08:24 +0200)]
allow '!!' for boolean conversion

we use this many times, and it really should not be confusing,
also it is much shorter than: 'Boolean(foo)',

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agobump version to 7.0.0~alpha3-1
Thomas Lamprecht [Thu, 9 Apr 2020 16:52:35 +0000 (18:52 +0200)]
bump version to 7.0.0~alpha3-1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agodrop "lints cwd on no params" hint
Thomas Lamprecht [Thu, 9 Apr 2020 16:54:43 +0000 (18:54 +0200)]
drop "lints cwd on no params" hint

This is a bit strange behaviour, especially if there's nothing to
lint and one gets just a spewed out nodejs backtracke.. It's not hard
to just to `eslint *.js` or the like..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agorules: dot-location: set location parameter to property
Thomas Lamprecht [Thu, 9 Apr 2020 16:29:46 +0000 (18:29 +0200)]
rules: dot-location: set location parameter to property

who the heck makes the following syntax the default:
> foo.
>    bar().
>    baz();

So let's enforce the right thing™ and enforce the dot sticking to the
property, not the object, i.e.:

> foo
>    .bar().
>    .baz();

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoexit sanely if no args are given
Thomas Lamprecht [Thu, 9 Apr 2020 16:27:48 +0000 (18:27 +0200)]
exit sanely if no args are given

I mean some seem to like python style throwing up in ones face on
every occasion.. I don't though..

nodes drops the original argv0 in favor of process.execPath and the
path to the JavaScript file being executed, so we need more than two
args to be OK.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoglobals: sort and add PBS
Thomas Lamprecht [Thu, 9 Apr 2020 16:15:36 +0000 (18:15 +0200)]
globals: sort and add PBS

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobump version to 7.0.0~alpha3
Thomas Lamprecht [Thu, 9 Apr 2020 15:57:26 +0000 (17:57 +0200)]
bump version to 7.0.0~alpha3

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoadd dsc target, fix various packaging related stuff
Thomas Lamprecht [Thu, 9 Apr 2020 15:57:06 +0000 (17:57 +0200)]
add dsc target, fix various packaging related stuff

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agofirst commit
Dominik Csapak [Thu, 2 Apr 2020 07:24:29 +0000 (09:24 +0200)]
first commit

includes a (minimal) working wrapper

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>