base guest config: add common destroy_config implementation

[pve-guest-common.git] / PVE / AbstractConfig.pm

diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
index 482f0e28c8bd99333da83e054ce5bd4631c30fa1..26235fa47563cab1ae45cd855ae248851df9e0ee 100644 (file)
--- a/PVE/AbstractConfig.pm
+++ b/PVE/AbstractConfig.pm
@@ -8,6 +8,9 @@ use PVE::INotify;
 use PVE::Cluster;
 use PVE::Storage;
 
+use PVE::ReplicationConfig;
+use PVE::Replication;
+
 my $nodename = PVE::INotify::nodename();
 
 # Printable string, currently either "VM" or "CT"
@@ -79,6 +82,28 @@ sub lock_config_full {
     return $res;
 }
 
+sub create_and_lock_config {
+    my ($class, $vmid, $allow_existing) = @_;
+
+    $class->lock_config_full($vmid, 5, sub {
+       PVE::Cluster::check_vmid_unused($vmid, $allow_existing);
+
+       my $conf = eval { $class->load_config($vmid) } || {};
+       $class->check_lock($conf);
+       $conf->{lock} = 'create';
+       $class->write_config($vmid, $conf);
+    });
+}
+
+# destroys configuration, only applyable for configs owned by the callers node.
+# dies if removal fails, e.g., when inquorate.
+sub destroy_config {
+    my ($class, $vmid) = @_;
+
+    my $config_fn = $class->config_file($vmid, $nodename);
+    unlink $config_fn or die "failed to remove config file: $!\n";
+}
+
 # Lock config file using flock, run $code with @param, unlock config file.
 # $timeout is the maximum time to aquire the flock
 # $shared eq 1 creates a non-exclusive ("read") flock
@@ -192,6 +217,15 @@ sub has_feature {
     die "implement me - abstract method\n";
 }
 
+# get all replicatable volume (hash $res->{$volid} = 1)
+# $cleanup: for cleanup - simply ignores volumes without replicate feature
+# $norerr: never raise exceptions - return undef instead
+sub get_replicatable_volumes {
+    my ($class, $storecfg, $vmid, $conf, $cleanup, $noerr) = @_;
+
+    die "implement me - abstract method\n";
+}
+
 # Internal snapshots
 
 # NOTE: Snapshot create/delete involves several non-atomic
@@ -260,6 +294,15 @@ sub __snapshot_delete_vol_snapshot {
     die "abstract method - implement me\n";
 }
 
+# called during rollback prepare, and between config rollback and starting guest
+# can change config, e.g. for vmgenid
+# $data is shared across calls and passed to vm_start
+sub __snapshot_rollback_hook {
+    my ($class, $vmid, $conf, $snap, $prepare, $data) = @_;
+
+    return;
+}
+
 # Checks whether a volume snapshot is possible for this volume.
 sub __snapshot_rollback_vol_possible {
     my ($class, $volume, $snapname) = @_;
@@ -283,7 +326,7 @@ sub __snapshot_rollback_vm_stop {
 
 # Start the VM/CT after a rollback with restored vmstate.
 sub __snapshot_rollback_vm_start {
-    my ($class, $vmid, $vmstate, $forcemachine);
+    my ($class, $vmid, $vmstate, $data);
 
     die "abstract method - implement me\n";
 }
@@ -332,6 +375,7 @@ sub __snapshot_apply_config {
     # keep description and list of unused disks
     foreach my $k (keys %$conf) {
        next if !($k =~ m/^unused\d+$/ || $k eq 'description');
+
        $newconf->{$k} = $conf->{$k};
     }
 
@@ -467,9 +511,13 @@ sub snapshot_delete {
 
     my $prepare = 1;
 
-    my $snap;
     my $unused = [];
 
+    my $conf = $class->load_config($vmid);
+    my $snap = $conf->{snapshots}->{$snapname};
+
+    die "snapshot '$snapname' does not exist\n" if !defined($snap);
+
     $class->set_lock($vmid, 'snapshot-delete')
        if (!$drivehash); # doesn't already have a 'snapshot' lock
 
@@ -582,6 +630,17 @@ sub snapshot_rollback {
        return $res;
     };
 
+    my $repl_conf = PVE::ReplicationConfig->new();
+    if ($repl_conf->check_for_existing_jobs($vmid, 1)) {
+       # remove all replication snapshots
+       my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 1);
+       my $sorted_volids = [ sort keys %$volumes ];
+
+       # remove all local replication snapshots (jobid => undef)
+       my $logfunc = sub { my $line = shift; chomp $line; print "$line\n"; };
+       PVE::Replication::prepare($storecfg, $sorted_volids, undef, 0, undef, $logfunc);
+    }
+    
     my $snap = &$get_snapshot_config();
 
     $class->__snapshot_foreach_volume($snap, sub {
@@ -590,6 +649,8 @@ sub snapshot_rollback {
        $class->__snapshot_rollback_vol_possible($volume, $snapname);
     });
 
+    my $data = {};
+
     my $updatefn = sub {
 
        $conf = $class->load_config($vmid);
@@ -612,36 +673,24 @@ sub snapshot_rollback {
        } else {
            die "got wrong lock\n" if !($conf->{lock} && $conf->{lock} eq 'rollback');
            delete $conf->{lock};
-       }
-
-       # machine only relevant for Qemu
-       my $forcemachine;
 
-       if (!$prepare) {
            my $unused = $class->__snapshot_rollback_get_unused($conf, $snap);
 
            foreach my $volid (@$unused) {
                $class->add_unused_volume($conf, $volid);
            }
 
-           my $has_machine_config = defined($conf->{machine});
-
            # copy snapshot config to current config
            $conf = $class->__snapshot_apply_config($conf, $snap);
            $conf->{parent} = $snapname;
-
-           # Note: old code did not store 'machine', so we try to be smart
-           # and guess the snapshot was generated with kvm 1.4 (pc-i440fx-1.4).
-           $forcemachine = $conf->{machine} || 'pc-i440fx-1.4';
-           # we remove the 'machine' configuration if not explicitly specified
-           # in the original config.
-           delete $conf->{machine} if $snap->{vmstate} && !$has_machine_config;
        }
 
+       $class->__snapshot_rollback_hook($vmid, $conf, $snap, $prepare, $data);
+
        $class->write_config($vmid, $conf);
 
        if (!$prepare && $snap->{vmstate}) {
-           $class->__snapshot_rollback_vm_start($vmid, $snap->{vmstate}, $forcemachine);
+           $class->__snapshot_rollback_vm_start($vmid, $snap->{vmstate}, $data);
        }
     };
 
@@ -657,4 +706,18 @@ sub snapshot_rollback {
     $class->lock_config($vmid, $updatefn);
 }
 
+# bash completion helper
+
+sub snapshot_list {
+    my ($class, $vmid) = @_;
+
+    my $snapshot = eval {
+       my $conf = $class->load_config($vmid);
+       my $snapshots = $conf->{snapshots} || [];
+       [ sort keys %$snapshots ]
+    } || [];
+
+    return $snapshot;
+}
+
 1;