]>
Commit | Line | Data |
---|---|---|
c0bbd038 DM |
1 | package PVE::HA::Manager; |
2 | ||
3 | use strict; | |
4 | use warnings; | |
c4a221bc | 5 | use Digest::MD5 qw(md5_base64); |
c0bbd038 | 6 | |
c142ebc9 | 7 | use PVE::Tools; |
a89ff919 | 8 | use PVE::HA::Tools ':exit_codes'; |
c0bbd038 | 9 | use PVE::HA::NodeStatus; |
5d724d4d | 10 | use PVE::HA::Usage::Basic; |
561e7f4b | 11 | use PVE::HA::Usage::Static; |
c0bbd038 | 12 | |
a3ffb0b3 TL |
13 | ## Variable Name & Abbreviations Convention |
14 | # | |
15 | # The HA stack has some variables it uses frequently and thus abbreviates it such that it may be | |
16 | # confusing for new readers. Here's a short list of the most common used. | |
17 | # | |
18 | # NOTE: variables should be assumed to be read only if not otherwise stated, only use the specific | |
19 | # methods to re-compute/read/alter them. | |
20 | # | |
21 | # - $haenv -> HA environment, the main interface to the simulator/test/real world | |
22 | # - $sid -> Service ID, unique identifier for a service, `type:vmid` is common | |
23 | # | |
24 | # - $ms -> Master/Manager Status, contains runtime info from the current active manager | |
25 | # - $ns -> Node Status, hash holding online/offline status about all nodes | |
26 | # | |
27 | # - $ss -> Service Status, hash holding the current state (last LRM cmd result, failed starts | |
28 | # or migrates, maintenance fallback node, for *all* services ... | |
29 | # - $sd -> Service Data, the service status of a *single* service, iow. $ss->{$sid} | |
30 | # | |
31 | # - $sc -> Service Configuration, hash for all services including target state, group, ... | |
0869c306 | 32 | # - $cd -> Configuration Data, the service config of a *single* service, iow. $sc->{$sid} |
a3ffb0b3 TL |
33 | # |
34 | # Try to avoid adding new two letter (or similar over abbreviated) names, but also don't send | |
35 | # patches for changing above, as that set is mostly sensible and should be easy to remember once | |
36 | # spending a bit time in the HA code base. | |
37 | ||
c0bbd038 | 38 | sub new { |
8f0bb968 | 39 | my ($this, $haenv) = @_; |
c0bbd038 DM |
40 | |
41 | my $class = ref($this) || $this; | |
42 | ||
1b813831 | 43 | my $self = bless { haenv => $haenv, crs => {} }, $class; |
8f0bb968 | 44 | |
6ee64cfc | 45 | my $old_ms = $haenv->read_manager_status(); |
8f0bb968 | 46 | |
6ee64cfc TL |
47 | # we only copy the state part of the manager which cannot be auto generated |
48 | ||
49 | $self->{ns} = PVE::HA::NodeStatus->new($haenv, $old_ms->{node_status} || {}); | |
8f0bb968 | 50 | |
59fd7207 | 51 | # fixme: use separate class PVE::HA::ServiceStatus |
6ee64cfc TL |
52 | $self->{ss} = $old_ms->{service_status} || {}; |
53 | ||
54 | $self->{ms} = { master_node => $haenv->nodename() }; | |
c0bbd038 | 55 | |
086f7075 | 56 | $self->update_crs_scheduler_mode(); # initial set, we update it once every loop |
f74f8ffb | 57 | |
c0bbd038 DM |
58 | return $self; |
59 | } | |
60 | ||
cb06cd42 TL |
61 | sub update_crs_scheduler_mode { |
62 | my ($self) = @_; | |
63 | ||
64 | my $haenv = $self->{haenv}; | |
65 | my $dc_cfg = $haenv->get_datacenter_settings(); | |
66 | ||
1b813831 | 67 | my $old_mode = $self->{crs}->{scheduler}; |
cb06cd42 TL |
68 | my $new_mode = $dc_cfg->{crs}->{ha} || 'basic'; |
69 | ||
70 | if (!defined($old_mode)) { | |
71 | $haenv->log('info', "using scheduler mode '$new_mode'") if $new_mode ne 'basic'; | |
086f7075 TL |
72 | } elsif ($new_mode eq $old_mode) { |
73 | return; # nothing to do | |
74 | } else { | |
75 | $haenv->log('info', "switching scheduler mode from '$old_mode' to '$new_mode'"); | |
cb06cd42 TL |
76 | } |
77 | ||
1b813831 | 78 | $self->{crs}->{scheduler} = $new_mode; |
cb06cd42 TL |
79 | |
80 | return; | |
81 | } | |
82 | ||
d84da043 DM |
83 | sub cleanup { |
84 | my ($self) = @_; | |
85 | ||
86 | # todo: ? | |
87 | } | |
88 | ||
8f0bb968 | 89 | sub flush_master_status { |
c0bbd038 DM |
90 | my ($self) = @_; |
91 | ||
59fd7207 | 92 | my ($haenv, $ms, $ns, $ss) = ($self->{haenv}, $self->{ms}, $self->{ns}, $self->{ss}); |
c0bbd038 | 93 | |
8f0bb968 | 94 | $ms->{node_status} = $ns->{status}; |
59fd7207 | 95 | $ms->{service_status} = $ss; |
d2f612cf | 96 | $ms->{timestamp} = $haenv->get_time(); |
289e4784 | 97 | |
8f0bb968 | 98 | $haenv->write_manager_status($ms); |
289e4784 | 99 | } |
c0bbd038 | 100 | |
48a6ba2a TL |
101 | sub get_service_group { |
102 | my ($groups, $online_node_usage, $service_conf) = @_; | |
f7ccd1b3 | 103 | |
09c5c4bf TL |
104 | my $group = {}; |
105 | # add all online nodes to default group to allow try_next when no group set | |
5d724d4d | 106 | $group->{nodes}->{$_} = 1 for $online_node_usage->list_nodes(); |
abc920b4 | 107 | |
09c5c4bf | 108 | # overwrite default if service is bound to a specific group |
3458a0e3 TL |
109 | if (my $group_id = $service_conf->{group}) { |
110 | $group = $groups->{ids}->{$group_id} if $groups->{ids}->{$group_id}; | |
111 | } | |
abc920b4 | 112 | |
48a6ba2a TL |
113 | return $group; |
114 | } | |
115 | ||
116 | # groups available nodes with their priority as group index | |
117 | sub get_node_priority_groups { | |
118 | my ($group, $online_node_usage) = @_; | |
119 | ||
abc920b4 DM |
120 | my $pri_groups = {}; |
121 | my $group_members = {}; | |
e0a56314 | 122 | foreach my $entry (keys %{$group->{nodes}}) { |
abc920b4 DM |
123 | my ($node, $pri) = ($entry, 0); |
124 | if ($entry =~ m/^(\S+):(\d+)$/) { | |
125 | ($node, $pri) = ($1, $2); | |
126 | } | |
5d724d4d | 127 | next if !$online_node_usage->contains_node($node); # offline |
abc920b4 DM |
128 | $pri_groups->{$pri}->{$node} = 1; |
129 | $group_members->{$node} = $pri; | |
130 | } | |
f7ccd1b3 | 131 | |
abc920b4 DM |
132 | # add non-group members to unrestricted groups (priority -1) |
133 | if (!$group->{restricted}) { | |
134 | my $pri = -1; | |
5d724d4d | 135 | for my $node ($online_node_usage->list_nodes()) { |
abc920b4 DM |
136 | next if defined($group_members->{$node}); |
137 | $pri_groups->{$pri}->{$node} = 1; | |
138 | $group_members->{$node} = -1; | |
139 | } | |
140 | } | |
141 | ||
48a6ba2a TL |
142 | return ($pri_groups, $group_members); |
143 | } | |
144 | ||
145 | sub select_service_node { | |
b2598576 | 146 | my ($groups, $online_node_usage, $sid, $service_conf, $current_node, $try_next, $tried_nodes, $maintenance_fallback) = @_; |
48a6ba2a TL |
147 | |
148 | my $group = get_service_group($groups, $online_node_usage, $service_conf); | |
149 | ||
150 | my ($pri_groups, $group_members) = get_node_priority_groups($group, $online_node_usage); | |
151 | ||
abc920b4 DM |
152 | my @pri_list = sort {$b <=> $a} keys %$pri_groups; |
153 | return undef if !scalar(@pri_list); | |
09c5c4bf TL |
154 | |
155 | # stay on current node if possible (avoids random migrations) | |
abc920b4 DM |
156 | if (!$try_next && $group->{nofailback} && defined($group_members->{$current_node})) { |
157 | return $current_node; | |
158 | } | |
159 | ||
160 | # select node from top priority node list | |
161 | ||
162 | my $top_pri = $pri_list[0]; | |
163 | ||
e6eeb7dc TL |
164 | # try to avoid nodes where the service failed already if we want to relocate |
165 | if ($try_next) { | |
166 | foreach my $node (@$tried_nodes) { | |
167 | delete $pri_groups->{$top_pri}->{$node}; | |
168 | } | |
169 | } | |
170 | ||
631ba60e FE |
171 | return $maintenance_fallback |
172 | if defined($maintenance_fallback) && $pri_groups->{$top_pri}->{$maintenance_fallback}; | |
173 | ||
c724ce1b FE |
174 | return $current_node if !$try_next && $pri_groups->{$top_pri}->{$current_node}; |
175 | ||
5d724d4d | 176 | my $scores = $online_node_usage->score_nodes_to_start_service($sid, $current_node); |
289e4784 | 177 | my @nodes = sort { |
5d724d4d | 178 | $scores->{$a} <=> $scores->{$b} || $a cmp $b |
c142ebc9 | 179 | } keys %{$pri_groups->{$top_pri}}; |
abc920b4 DM |
180 | |
181 | my $found; | |
182 | for (my $i = scalar(@nodes) - 1; $i >= 0; $i--) { | |
183 | my $node = $nodes[$i]; | |
184 | if ($node eq $current_node) { | |
185 | $found = $i; | |
abc920b4 DM |
186 | } |
187 | } | |
188 | ||
abc920b4 | 189 | if ($try_next) { |
abc920b4 DM |
190 | if (defined($found) && ($found < (scalar(@nodes) - 1))) { |
191 | return $nodes[$found + 1]; | |
192 | } else { | |
193 | return $nodes[0]; | |
194 | } | |
abc920b4 | 195 | } else { |
abc920b4 | 196 | return $nodes[0]; |
abc920b4 | 197 | } |
f7ccd1b3 DM |
198 | } |
199 | ||
c4a221bc DM |
200 | my $uid_counter = 0; |
201 | ||
d55aa611 DM |
202 | sub compute_new_uuid { |
203 | my ($state) = @_; | |
289e4784 | 204 | |
d55aa611 DM |
205 | $uid_counter++; |
206 | return md5_base64($state . $$ . time() . $uid_counter); | |
207 | } | |
208 | ||
618fbeda DM |
209 | my $valid_service_states = { |
210 | stopped => 1, | |
211 | request_stop => 1, | |
212 | started => 1, | |
213 | fence => 1, | |
c259b1a8 | 214 | recovery => 1, |
618fbeda | 215 | migrate => 1, |
b0fdf86a | 216 | relocate => 1, |
9c7d068b | 217 | freeze => 1, |
618fbeda DM |
218 | error => 1, |
219 | }; | |
220 | ||
561e7f4b FE |
221 | # FIXME with 'static' mode and thousands of services, the overhead can be noticable and the fact |
222 | # that this function is called for each state change and upon recovery doesn't help. | |
270d4406 DM |
223 | sub recompute_online_node_usage { |
224 | my ($self) = @_; | |
225 | ||
561e7f4b | 226 | my $haenv = $self->{haenv}; |
270d4406 DM |
227 | |
228 | my $online_nodes = $self->{ns}->list_online_nodes(); | |
229 | ||
561e7f4b FE |
230 | my $online_node_usage; |
231 | ||
1b813831 | 232 | if (my $mode = $self->{crs}->{scheduler}) { |
561e7f4b FE |
233 | if ($mode eq 'static') { |
234 | $online_node_usage = eval { | |
235 | my $scheduler = PVE::HA::Usage::Static->new($haenv); | |
236 | $scheduler->add_node($_) for $online_nodes->@*; | |
237 | return $scheduler; | |
238 | }; | |
f2c72982 | 239 | $haenv->log('warning', "fallback to 'basic' scheduler mode, init for 'static' failed - $@") |
561e7f4b | 240 | if $@; |
c2d8b56a TL |
241 | } elsif ($mode eq 'basic') { |
242 | # handled below in the general fall-back case | |
243 | } else { | |
561e7f4b FE |
244 | $haenv->log('warning', "got unknown scheduler mode '$mode', using 'basic'"); |
245 | } | |
246 | } | |
247 | ||
c2d8b56a | 248 | # fallback to the basic algorithm in any case |
561e7f4b FE |
249 | if (!$online_node_usage) { |
250 | $online_node_usage = PVE::HA::Usage::Basic->new($haenv); | |
251 | $online_node_usage->add_node($_) for $online_nodes->@*; | |
252 | } | |
270d4406 | 253 | |
7fd7af67 | 254 | foreach my $sid (sort keys %{$self->{ss}}) { |
270d4406 DM |
255 | my $sd = $self->{ss}->{$sid}; |
256 | my $state = $sd->{state}; | |
6f818da1 | 257 | my $target = $sd->{target}; # optional |
5d724d4d | 258 | if ($online_node_usage->contains_node($sd->{node})) { |
c259b1a8 TL |
259 | if ( |
260 | $state eq 'started' || $state eq 'request_stop' || $state eq 'fence' || | |
261 | $state eq 'freeze' || $state eq 'error' || $state eq 'recovery' | |
262 | ) { | |
5d724d4d | 263 | $online_node_usage->add_service_usage_to_node($sd->{node}, $sid, $sd->{node}); |
270d4406 | 264 | } elsif (($state eq 'migrate') || ($state eq 'relocate')) { |
5d724d4d | 265 | my $source = $sd->{node}; |
5c2eef4b | 266 | # count it for both, source and target as load is put on both |
5d724d4d FE |
267 | $online_node_usage->add_service_usage_to_node($source, $sid, $source, $target); |
268 | $online_node_usage->add_service_usage_to_node($target, $sid, $source, $target); | |
270d4406 DM |
269 | } elsif ($state eq 'stopped') { |
270 | # do nothing | |
271 | } else { | |
feea3913 | 272 | die "should not be reached (sid = '$sid', state = '$state')"; |
270d4406 | 273 | } |
5d724d4d | 274 | } elsif (defined($target) && $online_node_usage->contains_node($target)) { |
066fd016 TL |
275 | if ($state eq 'migrate' || $state eq 'relocate') { |
276 | # to correctly track maintenance modi and also consider the target as used for the | |
277 | # case a node dies, as we cannot really know if the to-be-aborted incoming migration | |
278 | # has already cleaned up all used resources | |
5d724d4d | 279 | $online_node_usage->add_service_usage_to_node($target, $sid, $sd->{node}, $target); |
066fd016 | 280 | } |
270d4406 DM |
281 | } |
282 | } | |
283 | ||
284 | $self->{online_node_usage} = $online_node_usage; | |
285 | } | |
286 | ||
4e01bc86 DM |
287 | my $change_service_state = sub { |
288 | my ($self, $sid, $new_state, %params) = @_; | |
289 | ||
290 | my ($haenv, $ss) = ($self->{haenv}, $self->{ss}); | |
291 | ||
292 | my $sd = $ss->{$sid} || die "no such service '$sid"; | |
293 | ||
294 | my $old_state = $sd->{state}; | |
e4ffb299 | 295 | my $old_node = $sd->{node}; |
46139211 | 296 | my $old_failed_nodes = $sd->{failed_nodes}; |
2167dd1e | 297 | my $old_maintenance_node = $sd->{maintenance_node}; |
4e01bc86 DM |
298 | |
299 | die "no state change" if $old_state eq $new_state; # just to be sure | |
300 | ||
618fbeda DM |
301 | die "invalid CRM service state '$new_state'\n" if !$valid_service_states->{$new_state}; |
302 | ||
e4ffb299 DM |
303 | foreach my $k (keys %$sd) { delete $sd->{$k}; }; |
304 | ||
305 | $sd->{state} = $new_state; | |
306 | $sd->{node} = $old_node; | |
ea998b07 | 307 | $sd->{failed_nodes} = $old_failed_nodes if defined($old_failed_nodes); |
2167dd1e | 308 | $sd->{maintenance_node} = $old_maintenance_node if defined($old_maintenance_node); |
e4ffb299 DM |
309 | |
310 | my $text_state = ''; | |
ba623362 | 311 | foreach my $k (sort keys %params) { |
4e01bc86 | 312 | my $v = $params{$k}; |
e4ffb299 DM |
313 | $text_state .= ", " if $text_state; |
314 | $text_state .= "$k = $v"; | |
4e01bc86 DM |
315 | $sd->{$k} = $v; |
316 | } | |
270d4406 DM |
317 | |
318 | $self->recompute_online_node_usage(); | |
319 | ||
d55aa611 | 320 | $sd->{uid} = compute_new_uuid($new_state); |
4e01bc86 | 321 | |
24678a59 TL |
322 | $text_state = " ($text_state)" if $text_state; |
323 | $haenv->log('info', "service '$sid': state changed from '${old_state}'" . | |
324 | " to '${new_state}'$text_state"); | |
4e01bc86 DM |
325 | }; |
326 | ||
5dd3ed86 TL |
327 | # clean up a possible bad state from a recovered service to allow its start |
328 | my $fence_recovery_cleanup = sub { | |
329 | my ($self, $sid, $fenced_node) = @_; | |
330 | ||
331 | my $haenv = $self->{haenv}; | |
332 | ||
0087839a | 333 | my (undef, $type, $id) = $haenv->parse_sid($sid); |
5dd3ed86 TL |
334 | my $plugin = PVE::HA::Resources->lookup($type); |
335 | ||
336 | # should not happen | |
337 | die "unknown resource type '$type'" if !$plugin; | |
338 | ||
32ea51dd TL |
339 | # locks may block recovery, cleanup those which are safe to remove after fencing, |
340 | # i.e., after the original node was reset and thus all it's state | |
3458a0e3 TL |
341 | my $removable_locks = [ |
342 | 'backup', | |
343 | 'mounted', | |
344 | 'migrate', | |
345 | 'clone', | |
346 | 'rollback', | |
347 | 'snapshot', | |
348 | 'snapshot-delete', | |
349 | 'suspending', | |
350 | 'suspended', | |
351 | ]; | |
5dd3ed86 TL |
352 | if (my $removed_lock = $plugin->remove_locks($haenv, $id, $removable_locks, $fenced_node)) { |
353 | $haenv->log('warning', "removed leftover lock '$removed_lock' from recovered " . | |
354 | "service '$sid' to allow its start."); | |
355 | } | |
356 | }; | |
357 | ||
289e4784 | 358 | # read LRM status for all nodes |
c4a221bc | 359 | sub read_lrm_status { |
332170bd | 360 | my ($self) = @_; |
c4a221bc | 361 | |
9c7d068b | 362 | my $nodes = $self->{ns}->list_nodes(); |
c4a221bc DM |
363 | my $haenv = $self->{haenv}; |
364 | ||
9c7d068b DM |
365 | my $results = {}; |
366 | my $modes = {}; | |
332170bd | 367 | foreach my $node (@$nodes) { |
9c7d068b | 368 | my $lrm_status = $haenv->read_lrm_status($node); |
02ffd753 | 369 | $modes->{$node} = $lrm_status->{mode} || 'active'; |
9c7d068b DM |
370 | foreach my $uid (keys %{$lrm_status->{results}}) { |
371 | next if $results->{$uid}; # should not happen | |
372 | $results->{$uid} = $lrm_status->{results}->{$uid}; | |
c4a221bc DM |
373 | } |
374 | } | |
375 | ||
9c7d068b | 376 | return ($results, $modes); |
c4a221bc DM |
377 | } |
378 | ||
aa98a844 DM |
379 | # read new crm commands and save them into crm master status |
380 | sub update_crm_commands { | |
381 | my ($self) = @_; | |
382 | ||
383 | my ($haenv, $ms, $ns, $ss) = ($self->{haenv}, $self->{ms}, $self->{ns}, $self->{ss}); | |
384 | ||
385 | my $cmdlist = $haenv->read_crm_commands(); | |
bf7febe3 | 386 | |
aa98a844 DM |
387 | foreach my $cmd (split(/\n/, $cmdlist)) { |
388 | chomp $cmd; | |
389 | ||
b0fdf86a | 390 | if ($cmd =~ m/^(migrate|relocate)\s+(\S+)\s+(\S+)$/) { |
289e4784 | 391 | my ($task, $sid, $node) = ($1, $2, $3); |
aa98a844 DM |
392 | if (my $sd = $ss->{$sid}) { |
393 | if (!$ns->node_is_online($node)) { | |
394 | $haenv->log('err', "crm command error - node not online: $cmd"); | |
395 | } else { | |
396 | if ($node eq $sd->{node}) { | |
397 | $haenv->log('info', "ignore crm command - service already on target node: $cmd"); | |
289e4784 | 398 | } else { |
aa98a844 | 399 | $haenv->log('info', "got crm command: $cmd"); |
3d42b01b | 400 | $ss->{$sid}->{cmd} = [ $task, $node ]; |
aa98a844 DM |
401 | } |
402 | } | |
403 | } else { | |
404 | $haenv->log('err', "crm command error - no such service: $cmd"); | |
405 | } | |
406 | ||
21caf0db FE |
407 | } elsif ($cmd =~ m/^stop\s+(\S+)\s+(\S+)$/) { |
408 | my ($sid, $timeout) = ($1, $2); | |
409 | if (my $sd = $ss->{$sid}) { | |
410 | $haenv->log('info', "got crm command: $cmd"); | |
411 | $ss->{$sid}->{cmd} = [ 'stop', $timeout ]; | |
412 | } else { | |
413 | $haenv->log('err', "crm command error - no such service: $cmd"); | |
414 | } | |
aa98a844 DM |
415 | } else { |
416 | $haenv->log('err', "unable to parse crm command: $cmd"); | |
417 | } | |
418 | } | |
419 | ||
420 | } | |
421 | ||
8f0bb968 DM |
422 | sub manage { |
423 | my ($self) = @_; | |
c0bbd038 | 424 | |
59fd7207 | 425 | my ($haenv, $ms, $ns, $ss) = ($self->{haenv}, $self->{ms}, $self->{ns}, $self->{ss}); |
c0bbd038 | 426 | |
99278e06 TL |
427 | my ($node_info) = $haenv->get_node_info(); |
428 | my ($lrm_results, $lrm_modes) = $self->read_lrm_status(); | |
429 | ||
430 | $ns->update($node_info, $lrm_modes); | |
c79442f2 | 431 | |
99278e06 | 432 | if (!$ns->node_is_operational($haenv->nodename())) { |
e5986717 | 433 | $haenv->log('info', "master seems offline"); |
c79442f2 DM |
434 | return; |
435 | } | |
436 | ||
086f7075 TL |
437 | $self->update_crs_scheduler_mode(); |
438 | ||
f7ccd1b3 DM |
439 | my $sc = $haenv->read_service_config(); |
440 | ||
abc920b4 DM |
441 | $self->{groups} = $haenv->read_group_config(); # update |
442 | ||
f7ccd1b3 DM |
443 | # compute new service status |
444 | ||
445 | # add new service | |
cc32a8f3 | 446 | foreach my $sid (sort keys %$sc) { |
f7ccd1b3 | 447 | next if $ss->{$sid}; # already there |
77499288 | 448 | my $cd = $sc->{$sid}; |
667670b2 TL |
449 | next if $cd->{state} eq 'ignored'; |
450 | ||
77499288 | 451 | $haenv->log('info', "adding new service '$sid' on node '$cd->{node}'"); |
f7ccd1b3 | 452 | # assume we are running to avoid relocate running service at add |
bb07bd2c | 453 | my $state = ($cd->{state} eq 'started') ? 'started' : 'request_stop'; |
83a84eb0 TL |
454 | $ss->{$sid} = { |
455 | state => $state, node => $cd->{node}, uid => compute_new_uuid('started'), | |
456 | }; | |
f7ccd1b3 DM |
457 | } |
458 | ||
667670b2 | 459 | # remove stale or ignored services from manager state |
4e5764af | 460 | foreach my $sid (keys %$ss) { |
667670b2 TL |
461 | next if $sc->{$sid} && $sc->{$sid}->{state} ne 'ignored'; |
462 | ||
463 | my $reason = defined($sc->{$sid}) ? 'ignored state requested' : 'no config'; | |
464 | $haenv->log('info', "removing stale service '$sid' ($reason)"); | |
465 | ||
46139211 | 466 | # remove all service related state information |
4e5764af DM |
467 | delete $ss->{$sid}; |
468 | } | |
5a28da91 | 469 | |
aa98a844 DM |
470 | $self->update_crm_commands(); |
471 | ||
c79442f2 DM |
472 | for (;;) { |
473 | my $repeat = 0; | |
289e4784 | 474 | |
270d4406 | 475 | $self->recompute_online_node_usage(); |
f7ccd1b3 | 476 | |
a5e4bef4 | 477 | foreach my $sid (sort keys %$ss) { |
c79442f2 DM |
478 | my $sd = $ss->{$sid}; |
479 | my $cd = $sc->{$sid} || { state => 'disabled' }; | |
f7ccd1b3 | 480 | |
9c7d068b | 481 | my $lrm_res = $sd->{uid} ? $lrm_results->{$sd->{uid}} : undef; |
a875fbe8 | 482 | |
c79442f2 DM |
483 | my $last_state = $sd->{state}; |
484 | ||
485 | if ($last_state eq 'stopped') { | |
486 | ||
abc920b4 | 487 | $self->next_state_stopped($sid, $cd, $sd, $lrm_res); |
f7ccd1b3 | 488 | |
c79442f2 | 489 | } elsif ($last_state eq 'started') { |
f7ccd1b3 | 490 | |
abc920b4 | 491 | $self->next_state_started($sid, $cd, $sd, $lrm_res); |
f7ccd1b3 | 492 | |
b0fdf86a | 493 | } elsif ($last_state eq 'migrate' || $last_state eq 'relocate') { |
f7ccd1b3 | 494 | |
8aaa0e36 | 495 | $self->next_state_migrate_relocate($sid, $cd, $sd, $lrm_res); |
f7ccd1b3 | 496 | |
c79442f2 | 497 | } elsif ($last_state eq 'fence') { |
f7ccd1b3 | 498 | |
21e37ed4 | 499 | # do nothing here - wait until fenced |
f7ccd1b3 | 500 | |
c259b1a8 TL |
501 | } elsif ($last_state eq 'recovery') { |
502 | ||
503 | $self->next_state_recovery($sid, $cd, $sd, $lrm_res); | |
504 | ||
c79442f2 | 505 | } elsif ($last_state eq 'request_stop') { |
f7ccd1b3 | 506 | |
0df5b3dd | 507 | $self->next_state_request_stop($sid, $cd, $sd, $lrm_res); |
618fbeda | 508 | |
9c7d068b DM |
509 | } elsif ($last_state eq 'freeze') { |
510 | ||
511 | my $lrm_mode = $sd->{node} ? $lrm_modes->{$sd->{node}} : undef; | |
83a84eb0 TL |
512 | if ($lrm_mode && $lrm_mode eq 'active') { # unfreeze if active again |
513 | my $state = ($cd->{state} eq 'started') ? 'started' : 'request_stop'; | |
514 | $change_service_state->($self, $sid, $state); | |
515 | } | |
9c7d068b | 516 | |
e88469ba DM |
517 | } elsif ($last_state eq 'error') { |
518 | ||
a2881965 | 519 | $self->next_state_error($sid, $cd, $sd, $lrm_res); |
e88469ba | 520 | |
a875fbe8 DM |
521 | } else { |
522 | ||
523 | die "unknown service state '$last_state'"; | |
618fbeda | 524 | } |
21e37ed4 | 525 | |
9c7d068b | 526 | my $lrm_mode = $sd->{node} ? $lrm_modes->{$sd->{node}} : undef; |
07adc6a6 | 527 | if ($lrm_mode && $lrm_mode eq 'restart') { |
83a84eb0 TL |
528 | my $state = $sd->{state}; |
529 | if ($state eq 'started' || $state eq 'stopped'|| $state eq 'request_stop') { | |
530 | $change_service_state->($self, $sid, 'freeze'); | |
07adc6a6 | 531 | } |
9c7d068b | 532 | } |
07adc6a6 | 533 | |
c79442f2 | 534 | $repeat = 1 if $sd->{state} ne $last_state; |
f7ccd1b3 DM |
535 | } |
536 | ||
21e37ed4 DM |
537 | # handle fencing |
538 | my $fenced_nodes = {}; | |
9b2dbc2a | 539 | foreach my $sid (sort keys %$ss) { |
2deff1ae TL |
540 | my ($service_state, $service_node) = $ss->{$sid}->@{'state', 'node'}; |
541 | next if $service_state ne 'fence'; | |
0dcb6597 TL |
542 | |
543 | if (!defined($fenced_nodes->{$service_node})) { | |
2deff1ae | 544 | $fenced_nodes->{$service_node} = $ns->fence_node($service_node) || 0; |
21e37ed4 DM |
545 | } |
546 | ||
0dcb6597 | 547 | next if !$fenced_nodes->{$service_node}; |
21e37ed4 | 548 | |
9da84a0d | 549 | # node fence was successful - recover service |
c259b1a8 | 550 | $change_service_state->($self, $sid, 'recovery'); |
0dcb6597 | 551 | $repeat = 1; # for faster recovery execution |
21e37ed4 DM |
552 | } |
553 | ||
2deff1ae TL |
554 | # Avoid that a node without services in 'fence' state (e.g., removed |
555 | # manually by admin) is stuck with the 'fence' node state. | |
556 | for my $node (sort grep { !defined($fenced_nodes->{$_}) } keys $ns->{status}->%*) { | |
7dc92703 | 557 | next if $ns->get_node_state($node) ne 'fence'; |
7dc92703 | 558 | |
2deff1ae TL |
559 | $haenv->log('notice', "node '$node' in fence state but no services to-fence! admin interference?!"); |
560 | $repeat = 1 if $ns->fence_node($node); | |
7dc92703 FE |
561 | } |
562 | ||
c79442f2 | 563 | last if !$repeat; |
f7ccd1b3 | 564 | } |
f7ccd1b3 | 565 | |
8f0bb968 | 566 | $self->flush_master_status(); |
c0bbd038 DM |
567 | } |
568 | ||
a875fbe8 DM |
569 | # functions to compute next service states |
570 | # $cd: service configuration data (read only) | |
571 | # $sd: service status data (read only) | |
572 | # | |
573 | # Note: use change_service_state() to alter state | |
574 | # | |
575 | ||
0df5b3dd DM |
576 | sub next_state_request_stop { |
577 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; | |
578 | ||
579 | my $haenv = $self->{haenv}; | |
580 | my $ns = $self->{ns}; | |
581 | ||
582 | # check result from LRM daemon | |
583 | if ($lrm_res) { | |
584 | my $exit_code = $lrm_res->{exit_code}; | |
a89ff919 | 585 | if ($exit_code == SUCCESS) { |
0df5b3dd DM |
586 | &$change_service_state($self, $sid, 'stopped'); |
587 | return; | |
588 | } else { | |
33f01524 | 589 | $haenv->log('err', "service '$sid' stop failed (exit code $exit_code)"); |
0df5b3dd DM |
590 | &$change_service_state($self, $sid, 'error'); # fixme: what state? |
591 | return; | |
592 | } | |
593 | } | |
594 | ||
ce3d7003 | 595 | if ($ns->node_is_offline_delayed($sd->{node})) { |
0df5b3dd DM |
596 | &$change_service_state($self, $sid, 'fence'); |
597 | return; | |
598 | } | |
599 | } | |
600 | ||
8aaa0e36 DM |
601 | sub next_state_migrate_relocate { |
602 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; | |
603 | ||
604 | my $haenv = $self->{haenv}; | |
605 | my $ns = $self->{ns}; | |
606 | ||
607 | # check result from LRM daemon | |
608 | if ($lrm_res) { | |
609 | my $exit_code = $lrm_res->{exit_code}; | |
bb07bd2c | 610 | my $req_state = $cd->{state} eq 'started' ? 'started' : 'request_stop'; |
a89ff919 | 611 | if ($exit_code == SUCCESS) { |
542a9902 | 612 | &$change_service_state($self, $sid, $req_state, node => $sd->{target}); |
8aaa0e36 | 613 | return; |
660596ce TL |
614 | } elsif ($exit_code == EWRONG_NODE) { |
615 | $haenv->log('err', "service '$sid' - migration failed: service" . | |
616 | " registered on wrong node!"); | |
617 | &$change_service_state($self, $sid, 'error'); | |
8aaa0e36 DM |
618 | } else { |
619 | $haenv->log('err', "service '$sid' - migration failed (exit code $exit_code)"); | |
542a9902 | 620 | &$change_service_state($self, $sid, $req_state, node => $sd->{node}); |
8aaa0e36 DM |
621 | return; |
622 | } | |
623 | } | |
624 | ||
ce3d7003 | 625 | if ($ns->node_is_offline_delayed($sd->{node})) { |
8aaa0e36 DM |
626 | &$change_service_state($self, $sid, 'fence'); |
627 | return; | |
628 | } | |
629 | } | |
630 | ||
a875fbe8 | 631 | sub next_state_stopped { |
abc920b4 | 632 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; |
a875fbe8 DM |
633 | |
634 | my $haenv = $self->{haenv}; | |
e88469ba | 635 | my $ns = $self->{ns}; |
a875fbe8 | 636 | |
ff6f1c5c DM |
637 | if ($sd->{node} ne $cd->{node}) { |
638 | # this can happen if we fence a node with active migrations | |
639 | # hack: modify $sd (normally this should be considered read-only) | |
24678a59 | 640 | $haenv->log('info', "fixup service '$sid' location ($sd->{node} => $cd->{node})"); |
289e4784 | 641 | $sd->{node} = $cd->{node}; |
ff6f1c5c DM |
642 | } |
643 | ||
94b7ebe2 | 644 | if ($sd->{cmd}) { |
21caf0db | 645 | my $cmd = shift @{$sd->{cmd}}; |
94b7ebe2 | 646 | |
b0fdf86a | 647 | if ($cmd eq 'migrate' || $cmd eq 'relocate') { |
21caf0db | 648 | my $target = shift @{$sd->{cmd}}; |
94b7ebe2 | 649 | if (!$ns->node_is_online($target)) { |
b0fdf86a | 650 | $haenv->log('err', "ignore service '$sid' $cmd request - node '$target' not online"); |
e88469ba | 651 | } elsif ($sd->{node} eq $target) { |
b0fdf86a | 652 | $haenv->log('info', "ignore service '$sid' $cmd request - service already on node '$target'"); |
94b7ebe2 | 653 | } else { |
83a84eb0 | 654 | $change_service_state->($self, $sid, $cmd, node => $sd->{node}, target => $target); |
9da84a0d | 655 | return; |
94b7ebe2 | 656 | } |
21caf0db FE |
657 | } elsif ($cmd eq 'stop') { |
658 | $haenv->log('info', "ignore service '$sid' $cmd request - service already stopped"); | |
94b7ebe2 | 659 | } else { |
289e4784 | 660 | $haenv->log('err', "unknown command '$cmd' for service '$sid'"); |
94b7ebe2 | 661 | } |
21caf0db | 662 | delete $sd->{cmd}; |
35cbb764 | 663 | } |
94b7ebe2 | 664 | |
a875fbe8 | 665 | if ($cd->{state} eq 'disabled') { |
35cbb764 TL |
666 | # NOTE: do nothing here, the stop state is an exception as we do not |
667 | # process the LRM result here, thus the LRM always tries to stop the | |
668 | # service (protection for the case no CRM is active) | |
e88469ba | 669 | return; |
35cbb764 | 670 | } |
e88469ba | 671 | |
84c945e4 | 672 | if ($ns->node_is_offline_delayed($sd->{node}) && $ns->get_node_state($sd->{node}) ne 'maintenance') { |
af14d5f3 TL |
673 | &$change_service_state($self, $sid, 'fence'); |
674 | return; | |
675 | } | |
676 | ||
677 | if ($cd->{state} eq 'stopped') { | |
678 | # almost the same as 'disabled' state but the service will also get recovered | |
679 | return; | |
680 | } | |
681 | ||
bb07bd2c | 682 | if ($cd->{state} eq 'started') { |
9da84a0d TL |
683 | # simply mark it started, if it's on the wrong node |
684 | # next_state_started will fix that for us | |
685 | &$change_service_state($self, $sid, 'started', node => $sd->{node}); | |
e88469ba | 686 | return; |
a875fbe8 | 687 | } |
e88469ba DM |
688 | |
689 | $haenv->log('err', "service '$sid' - unknown state '$cd->{state}' in service configuration"); | |
a875fbe8 DM |
690 | } |
691 | ||
46139211 | 692 | sub record_service_failed_on_node { |
57fe8e87 | 693 | my ($self, $sid, $node) = @_; |
46139211 | 694 | |
57fe8e87 DM |
695 | if (!defined($self->{ss}->{$sid}->{failed_nodes})) { |
696 | $self->{ss}->{$sid}->{failed_nodes} = []; | |
697 | } | |
46139211 | 698 | |
57fe8e87 | 699 | push @{$self->{ss}->{$sid}->{failed_nodes}}, $node; |
46139211 TL |
700 | } |
701 | ||
a875fbe8 | 702 | sub next_state_started { |
abc920b4 | 703 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; |
a875fbe8 DM |
704 | |
705 | my $haenv = $self->{haenv}; | |
ea4443cc | 706 | my $master_status = $self->{ms}; |
a875fbe8 DM |
707 | my $ns = $self->{ns}; |
708 | ||
709 | if (!$ns->node_is_online($sd->{node})) { | |
b0e9158d | 710 | if ($ns->node_is_offline_delayed($sd->{node})) { |
5385a606 DM |
711 | &$change_service_state($self, $sid, 'fence'); |
712 | } | |
99278e06 TL |
713 | if ($ns->get_node_state($sd->{node}) ne 'maintenance') { |
714 | return; | |
2167dd1e TL |
715 | } else { |
716 | # save current node as fallback for when it comes out of | |
717 | # maintenance | |
718 | $sd->{maintenance_node} = $sd->{node}; | |
99278e06 | 719 | } |
e88469ba | 720 | } |
289e4784 | 721 | |
af14d5f3 | 722 | if ($cd->{state} eq 'disabled' || $cd->{state} eq 'stopped') { |
e88469ba DM |
723 | &$change_service_state($self, $sid, 'request_stop'); |
724 | return; | |
725 | } | |
726 | ||
bb07bd2c | 727 | if ($cd->{state} eq 'started') { |
e88469ba DM |
728 | |
729 | if ($sd->{cmd}) { | |
21caf0db | 730 | my $cmd = shift @{$sd->{cmd}}; |
e88469ba | 731 | |
b0fdf86a | 732 | if ($cmd eq 'migrate' || $cmd eq 'relocate') { |
21caf0db | 733 | my $target = shift @{$sd->{cmd}}; |
e88469ba | 734 | if (!$ns->node_is_online($target)) { |
b0fdf86a | 735 | $haenv->log('err', "ignore service '$sid' $cmd request - node '$target' not online"); |
e88469ba | 736 | } elsif ($sd->{node} eq $target) { |
b0fdf86a | 737 | $haenv->log('info', "ignore service '$sid' $cmd request - service already on node '$target'"); |
e88469ba | 738 | } else { |
a3cb8dcb | 739 | $haenv->log('info', "$cmd service '$sid' to node '$target'"); |
b0fdf86a | 740 | &$change_service_state($self, $sid, $cmd, node => $sd->{node}, target => $target); |
e88469ba | 741 | } |
21caf0db FE |
742 | } elsif ($cmd eq 'stop') { |
743 | my $timeout = shift @{$sd->{cmd}}; | |
396eb6f0 TL |
744 | if ($timeout == 0) { |
745 | $haenv->log('info', "request immediate service hard-stop for service '$sid'"); | |
746 | } else { | |
747 | $haenv->log('info', "request graceful stop with timeout '$timeout' for service '$sid'"); | |
748 | } | |
21caf0db FE |
749 | &$change_service_state($self, $sid, 'request_stop', timeout => $timeout); |
750 | $haenv->update_service_config($sid, {'state' => 'stopped'}); | |
a875fbe8 | 751 | } else { |
289e4784 | 752 | $haenv->log('err', "unknown command '$cmd' for service '$sid'"); |
a875fbe8 | 753 | } |
21caf0db FE |
754 | |
755 | delete $sd->{cmd}; | |
756 | ||
a875fbe8 | 757 | } else { |
b0fdf86a | 758 | |
abc920b4 | 759 | my $try_next = 0; |
46139211 | 760 | |
ea4443cc | 761 | if ($lrm_res) { |
46139211 | 762 | |
e9e1cd68 TL |
763 | my $ec = $lrm_res->{exit_code}; |
764 | if ($ec == SUCCESS) { | |
765 | ||
46139211 | 766 | if (defined($sd->{failed_nodes})) { |
81449997 | 767 | $haenv->log('info', "relocation policy successful for '$sid' on node '$sd->{node}'," . |
46139211 TL |
768 | " failed nodes: " . join(', ', @{$sd->{failed_nodes}}) ); |
769 | } | |
770 | ||
771 | delete $sd->{failed_nodes}; | |
e9e1cd68 | 772 | |
b47920fd DM |
773 | # store flag to indicate successful start - only valid while state == 'started' |
774 | $sd->{running} = 1; | |
775 | ||
b159176a | 776 | } elsif ($ec == ERROR || $ec == EWRONG_NODE) { |
b47920fd DM |
777 | |
778 | delete $sd->{running}; | |
779 | ||
e9e1cd68 | 780 | # apply our relocate policy if we got ERROR from the LRM |
46139211 | 781 | $self->record_service_failed_on_node($sid, $sd->{node}); |
ea4443cc | 782 | |
46139211 | 783 | if (scalar(@{$sd->{failed_nodes}}) <= $cd->{max_relocate}) { |
ea4443cc | 784 | |
e9e1cd68 TL |
785 | # tell select_service_node to relocate if possible |
786 | $try_next = 1; | |
ea4443cc TL |
787 | |
788 | $haenv->log('warning', "starting service $sid on node". | |
789 | " '$sd->{node}' failed, relocating service."); | |
ea4443cc TL |
790 | |
791 | } else { | |
792 | ||
46139211 TL |
793 | $haenv->log('err', "recovery policy for service $sid " . |
794 | "failed, entering error state. Failed nodes: ". | |
795 | join(', ', @{$sd->{failed_nodes}})); | |
ea4443cc TL |
796 | &$change_service_state($self, $sid, 'error'); |
797 | return; | |
798 | ||
799 | } | |
e9e1cd68 | 800 | } else { |
46139211 TL |
801 | $self->record_service_failed_on_node($sid, $sd->{node}); |
802 | ||
e9e1cd68 TL |
803 | $haenv->log('err', "service '$sid' got unrecoverable error" . |
804 | " (exit code $ec))"); | |
805 | # we have no save way out (yet) for other errors | |
806 | &$change_service_state($self, $sid, 'error'); | |
35cbb764 | 807 | return; |
ea4443cc | 808 | } |
abc920b4 DM |
809 | } |
810 | ||
2167dd1e TL |
811 | my $node = select_service_node( |
812 | $self->{groups}, | |
813 | $self->{online_node_usage}, | |
b2598576 | 814 | $sid, |
2167dd1e TL |
815 | $cd, |
816 | $sd->{node}, | |
817 | $try_next, | |
818 | $sd->{failed_nodes}, | |
819 | $sd->{maintenance_node}, | |
820 | ); | |
abc920b4 | 821 | |
b0fdf86a | 822 | if ($node && ($sd->{node} ne $node)) { |
5d724d4d | 823 | $self->{online_node_usage}->add_service_usage_to_node($node, $sid, $sd->{node}); |
2167dd1e TL |
824 | |
825 | if (defined(my $fallback = $sd->{maintenance_node})) { | |
826 | if ($node eq $fallback) { | |
827 | $haenv->log('info', "moving service '$sid' back to '$fallback', node came back from maintenance."); | |
828 | delete $sd->{maintenance_node}; | |
829 | } elsif ($sd->{node} ne $fallback) { | |
830 | $haenv->log('info', "dropping maintenance fallback node '$fallback' for '$sid'"); | |
831 | delete $sd->{maintenance_node}; | |
832 | } | |
833 | } | |
834 | ||
c0255b2c TL |
835 | if ($cd->{type} eq 'vm') { |
836 | $haenv->log('info', "migrate service '$sid' to node '$node' (running)"); | |
837 | &$change_service_state($self, $sid, 'migrate', node => $sd->{node}, target => $node); | |
838 | } else { | |
839 | $haenv->log('info', "relocate service '$sid' to node '$node'"); | |
840 | &$change_service_state($self, $sid, 'relocate', node => $sd->{node}, target => $node); | |
841 | } | |
b0fdf86a | 842 | } else { |
e6eeb7dc TL |
843 | if ($try_next && !defined($node)) { |
844 | $haenv->log('warning', "Start Error Recovery: Tried all available " . | |
845 | " nodes for service '$sid', retry start on current node. " . | |
846 | "Tried nodes: " . join(', ', @{$sd->{failed_nodes}})); | |
847 | } | |
35cbb764 | 848 | # ensure service get started again if it went unexpected down |
bf2d8d74 TL |
849 | # but ensure also no LRM result gets lost |
850 | $sd->{uid} = compute_new_uuid($sd->{state}) if defined($lrm_res); | |
b0fdf86a | 851 | } |
a875fbe8 | 852 | } |
e88469ba DM |
853 | |
854 | return; | |
35cbb764 | 855 | } |
e88469ba DM |
856 | |
857 | $haenv->log('err', "service '$sid' - unknown state '$cd->{state}' in service configuration"); | |
a875fbe8 | 858 | } |
c0bbd038 | 859 | |
a2881965 TL |
860 | sub next_state_error { |
861 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; | |
862 | ||
863 | my $ns = $self->{ns}; | |
46139211 | 864 | my $ms = $self->{ms}; |
a2881965 TL |
865 | |
866 | if ($cd->{state} eq 'disabled') { | |
46139211 TL |
867 | # clean up on error recovery |
868 | delete $sd->{failed_nodes}; | |
869 | ||
a2881965 TL |
870 | &$change_service_state($self, $sid, 'stopped'); |
871 | return; | |
872 | } | |
873 | ||
a2881965 TL |
874 | } |
875 | ||
c259b1a8 TL |
876 | # after a node was fenced this recovers the service to a new node |
877 | sub next_state_recovery { | |
878 | my ($self, $sid, $cd, $sd, $lrm_res) = @_; | |
879 | ||
880 | my ($haenv, $ss) = ($self->{haenv}, $self->{ss}); | |
881 | my $ns = $self->{ns}; | |
882 | my $ms = $self->{ms}; | |
883 | ||
884 | if ($sd->{state} ne 'recovery') { # should not happen | |
885 | $haenv->log('err', "cannot recover service '$sid' from fencing, wrong state '$sd->{state}'"); | |
886 | return; | |
887 | } | |
888 | ||
889 | my $fenced_node = $sd->{node}; # for logging purpose | |
890 | ||
891 | $self->recompute_online_node_usage(); # we want the most current node state | |
892 | ||
893 | my $recovery_node = select_service_node( | |
894 | $self->{groups}, | |
895 | $self->{online_node_usage}, | |
b2598576 | 896 | $sid, |
c259b1a8 TL |
897 | $cd, |
898 | $sd->{node}, | |
899 | ); | |
900 | ||
901 | if ($recovery_node) { | |
90a24755 TL |
902 | my $msg = "recover service '$sid' from fenced node '$fenced_node' to node '$recovery_node'"; |
903 | if ($recovery_node eq $fenced_node) { | |
904 | # can happen if restriced groups and the node came up again OK | |
905 | $msg = "recover service '$sid' to previous failed and fenced node '$fenced_node' again"; | |
906 | } | |
907 | $haenv->log('info', "$msg"); | |
c259b1a8 TL |
908 | |
909 | $fence_recovery_cleanup->($self, $sid, $fenced_node); | |
910 | ||
911 | $haenv->steal_service($sid, $sd->{node}, $recovery_node); | |
5d724d4d | 912 | $self->{online_node_usage}->add_service_usage_to_node($recovery_node, $sid, $recovery_node); |
c259b1a8 TL |
913 | |
914 | # NOTE: $sd *is normally read-only*, fencing is the exception | |
915 | $cd->{node} = $sd->{node} = $recovery_node; | |
916 | my $new_state = ($cd->{state} eq 'started') ? 'started' : 'request_stop'; | |
917 | $change_service_state->($self, $sid, $new_state, node => $recovery_node); | |
918 | } else { | |
919 | # no possible node found, cannot recover - but retry later, as we always try to make it available | |
920 | $haenv->log('err', "recovering service '$sid' from fenced node '$fenced_node' failed, no recovery node found"); | |
719883e9 TL |
921 | |
922 | if ($cd->{state} eq 'disabled') { | |
923 | # allow getting a service out of recovery manually if an admin disables it. | |
924 | delete $sd->{failed_nodes}; # clean up on recovery to stopped | |
925 | $change_service_state->($self, $sid, 'stopped'); # must NOT go through request_stop | |
926 | return; | |
927 | } | |
c259b1a8 TL |
928 | } |
929 | } | |
930 | ||
c0bbd038 | 931 | 1; |