]> git.proxmox.com Git - pve-http-server.git/commit - src/PVE/APIServer/AnyEvent.pm
response: avoid linefeeds in response status
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 1 Jul 2022 09:32:54 +0000 (11:32 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 1 Jul 2022 09:38:16 +0000 (11:38 +0200)
commit936007ae0241811093155000486da171379c23c2
tree8cecfb9e8eac2e104b6db0ed9e2914e69cf01258
parentb9a7fd54e9f23482e668454001913caa096ecad1
response: avoid linefeeds in response status

basically only possible to trigger with chromium based browsers
(chrome, edge, opera) but besides those having the biggest usage
currently its not that nice in any way.

Users could inject headers in their response, which isn't really that
bad itself, as they won't really do anything at least for sane
browsers that don't allow setting third party cookies by default
(unlike again, chrome), in which case one can create huge cookies
that then trigger the max header size check on requests, DOS'ing an
user's access to a PVE interface if they can get them to visit a
malicious site (a clear cooki actione would allow visiting it again)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reported-by: STAR Labs <info@starlabs.sg>
src/PVE/APIServer/AnyEvent.pm