]> git.proxmox.com Git - pve-installer.git/commit
proxinstall, common: remove "off" as zfs checksum option
authorChristoph Heiss <c.heiss@proxmox.com>
Tue, 6 Feb 2024 13:12:26 +0000 (14:12 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 6 Feb 2024 13:22:24 +0000 (14:22 +0100)
commit2716d68f77f24c21d35fbbcb3f72116d33f905f0
treeef4527acecb03c67a3c3753774832627c9b58a06
parent49d08ff904f9e8b795fc7ce09aa5eb62cccf2163
proxinstall, common: remove "off" as zfs checksum option

See also the thread at [0] for the initial discussion/idea.

Disabling checksums is considered an "extraordinarily bad idea" [1] (for
pretty obvious reason) and nobody should really ever use it.

Thus remove the option completely; just so that users cannot simply
disable checksum "for performance reasons" without knowing about the
implications of this.

As pointed out by Thomas, it can still be set to "off" after the
installation using the `zfs` tool, if really wanted.

[0] https://lists.proxmox.com/pipermail/pve-devel/2023-December/061188.html
[1] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
proxinstall
proxmox-installer-common/src/options.rs