]>
git.proxmox.com Git - pve-manager.git/log
Dominik Csapak [Mon, 25 Oct 2021 14:01:38 +0000 (16:01 +0200)]
pveceph: add 'fs destroy' command
with 'remove-storages' and 'remove-pools' as optional parameters
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:37 +0000 (16:01 +0200)]
ui: ceph/fs: allow creating multiple cephfs
but only if there are any standby mds
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:36 +0000 (16:01 +0200)]
ui: storage/cephfs: make ceph fs selectable
by adding a CephFSSelector and using it in the CephFSEdit window
(similar to the poolselector/textfield)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:35 +0000 (16:01 +0200)]
api: cephfs: add 'fs-name' for cephfs storage
so that we can uniquely identify the cephfs (in case of multiple)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:34 +0000 (16:01 +0200)]
ui: ceph/fs: show fs for active mds
so that the user can see which mds is responsible for which cephfs
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:33 +0000 (16:01 +0200)]
ui: ceph/ServiceList: refactor controller out
we want to reuse that controller type by overriding some functionality
in the future, so factor it out.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:32 +0000 (16:01 +0200)]
api: cephfs: add fs_name to 'is mds active' check
so that we check the mds for the correct cephfs we just added
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:31 +0000 (16:01 +0200)]
api: cephfs: more checks on fs create
namely if the fs is already existing, and if there is currently a
standby mds that can be used for the new fs
previosuly, only one cephfs was possible, so these checks were not
necessary. now with pacific, it is possible to have multiple cephfs'
and we should check for those.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:30 +0000 (16:01 +0200)]
api: cephfs: refactor {ls, create}_fs
no function change intended
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:29 +0000 (16:01 +0200)]
ui: ceph: catch missing version for service list
when a daemon is stopped, the version here is 'undefined'. catch that
instead of letting the template renderer run into an error.
this fixes the rendering of the grid backgrounds
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 25 Oct 2021 14:01:28 +0000 (16:01 +0200)]
api: ceph-mds: get mds state when multple ceph filesystems exist
by iterating over all of them and saving the name to the active ones
this fixes the issue that an mds that is assigned to not the first
fs in the list gets wrongly shown as offline
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Thu, 11 Nov 2021 16:50:45 +0000 (17:50 +0100)]
ui: form/CalendarEvent: remove 'first saturday each month' example
Originally-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Thu, 11 Nov 2021 16:44:03 +0000 (17:44 +0100)]
ui: dc/options: show depreacation notice in u2f settings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Thu, 11 Nov 2021 16:38:10 +0000 (17:38 +0100)]
ui: dc/options: display WebAuthn and add editor
mostly copied 1:1 from PBS, we could move this to widget toolkit
sometimes though..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:14 +0000 (12:27 +0100)]
www: redirect user TFA button to TFA view
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:13 +0000 (12:27 +0100)]
www: add TFA view to config
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:12 +0000 (12:27 +0100)]
www: use af-address-book-o for realms
we do this in PBS, and use the key for TFA
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:11 +0000 (12:27 +0100)]
www: switch to new tfa login format
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:09 +0000 (12:27 +0100)]
www: use UserSelector from wtk
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Wolfgang Bumiller [Tue, 9 Nov 2021 11:27:08 +0000 (12:27 +0100)]
www: use render_u2f_error from wtk
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fabian Ebner [Thu, 11 Nov 2021 09:00:55 +0000 (10:00 +0100)]
ui: calendar event: fix descriptions for examples
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Wolfgang Bumiller [Wed, 10 Nov 2021 12:49:04 +0000 (13:49 +0100)]
depend on and use libjs-qrcodejs
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 21:03:05 +0000 (22:03 +0100)]
ui: storage: avoid deleting preallocation setting on creation
reported in the forum: https://forum.proxmox.com/threads/.99471/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Wolfgang Bumiller [Wed, 10 Nov 2021 14:11:46 +0000 (15:11 +0100)]
pvestatd: broadcast version info
broadcast the built-in, statically available version info, e.g.:
{
"release" : "7.0",
"repoid" : "
3ce05d40 ",
"version" : "7.0-14"
}
We can expand this by more actual package version info in the future,
but that certainly needs more elaborate update control mechanisms as
the oneshot at boot we have now.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 20:32:14 +0000 (21:32 +0100)]
ui: form/calendar event: add some more complex examples
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 20:31:16 +0000 (21:31 +0100)]
ui: form/calendar event: increase width of combobox picker
makes it more readable and will allow for some more complex examples
without wrapping (which is hard to grasp without row styling
otherwise)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 20:29:38 +0000 (21:29 +0100)]
ui: backup job: limit ID to 20 chars for now
we're thinking of maybe just auto-filling it or allowing to edit it,
in any way, the comment field can/should be used for longer, free
form info.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 18:26:56 +0000 (19:26 +0100)]
ui: backup job: ellipsize read-only ID on edit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 18:25:55 +0000 (19:25 +0100)]
ui: backup job: avoid row wrapping due to overly long label
We can express that it's a notification in the combobox.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 16:34:39 +0000 (17:34 +0100)]
api: version: expand return schema info
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 16:26:48 +0000 (17:26 +0100)]
api: version: only include the console option of the datacenter config
Especially with the new description the result can get quite huge and
we do not really require any other info, the console one is only
returned here anyway as a hack due to the dc config API path requires
higher privileges.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 14:02:56 +0000 (15:02 +0100)]
ui: dc/Backup: add comment field and column
and hide the ID column by default
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 14:02:55 +0000 (15:02 +0100)]
api: backup/jobs: add comment field to jobs
and encode them with PVE::Tools::encode_text in the config
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 14:02:54 +0000 (15:02 +0100)]
ui: dc/BackupEdit: use correct validation
we use a 'pve-configid', so use the 'ConfigId' vtype
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 14:02:53 +0000 (15:02 +0100)]
Jobs/VZDump: encode/decode 'prune-backups' where needed
we want to write it out to the config as propertyString,
but want it as object in the api (for compatiblity)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 8 Nov 2021 13:07:58 +0000 (14:07 +0100)]
ui: dc/backup: show id+schedule instead of dow+starttime
we can now show the id (since its not autogenerated anymore),
and we can always show/edit the schedule instead of the dow+starttime
also add an 'ID' field to the edit/create window and update the
backupinfo window as well
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 8 Nov 2021 13:07:57 +0000 (14:07 +0100)]
api/backup: handle new vzdump jobs
in addition to listing the vzdump.cron jobs, also list from the
jobs.cfg file.
updates/creations go into the new jobs.cfg only now
and on update, starttime+dow get converted to a schedule
this transformation is straight forward, since 'dow'
is already in a compatible format (e.g. 'mon,tue') and we simply
append the starttime (if any)
id on creation is optional for now (for api compat), but will
be autogenerated (uuid). on update, we simply take the id from before
(the ids of the other entries in vzdump.cron will change but they would
anyway)
as long as we have the vzdump.cron file, we must lock both
vzdump.cron and jobs.cfg, since we often update both
we also change the backupinfo api call to read the jobs.cfg too
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 8 Nov 2021 13:07:56 +0000 (14:07 +0100)]
api/backup: refactor string for all days
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 8 Nov 2021 13:07:55 +0000 (14:07 +0100)]
pvescheduler: run jobs from jobs.cfg
PVE/Jobs is responsible to decide if the job must run (e.g. with a
schedule)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Mon, 8 Nov 2021 13:07:54 +0000 (14:07 +0100)]
add PVE/Jobs to handle VZDump jobs
this adds a SectionConfig handling for jobs (only 'vzdump' for now) that
represents a job that will be handled by pvescheduler and a basic
'job-state' handling for reading/writing state json files
this has some intersections with pvesrs state handling, but does not
use a single state file for all jobs, but seperate ones, like we
do it in the backup-server.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Mon, 8 Nov 2021 13:07:53 +0000 (14:07 +0100)]
replace systemd timer with pvescheduler daemon
The whole thing is already prepared for this, the systemd timer was
just a fixed periodic timer with a frequency of one minute. And we
just introduced it as the assumption was made that less memory usage
would be generated with this approach, AFAIK.
But logging 4+ lines just about that the timer was started, even if
it does nothing, and that 24/7 is not to cheap and a bit annoying.
So in a first step add a simple daemon, which forks of a child for
running jobs once a minute.
This could be made still a bit more intelligent, i.e., look if we
have jobs tor run before forking - as forking is not the cheapest
syscall. Further, we could adapt the sleep interval to the next time
we actually need to run a job (and sending a SIGUSR to the daemon if
a job interval changes such, that this interval got narrower)
We try to sync running on minute-change boundaries at start, this
emulates systemd.timer behaviour, we had until now. Also user can
configure jobs on minute precision, so they probably expect that
those also start really close to a minute change event.
Could be adapted to resync during running, to factor in time drift.
But, as long as enough cpu cycles are available we run in correct
monotonic intervalls, so this isn't a must, IMO.
Another improvement could be locking a bit more fine grained, i.e.
not on a per-all-local-job-runs basis, but per-job (per-guest?)
basis, which would improve temporary starvement of small
high-periodic jobs through big, less peridoci jobs.
We argued that it's the user fault if such situations arise, but they
can evolve over time without noticing, especially in compolexer
setups.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 10 Nov 2021 13:06:28 +0000 (14:06 +0100)]
Revert "ceph services: drop broadcasting legacy version pmxcfs KV"
This reverts commit
8a3a300b8e430a74af2497e1759cf5ee461a22c8 as 7.0
wasn't fully prepared for the transition...
https://lists.proxmox.com/pipermail/pve-devel/2021-November/050833.html
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 12:15:56 +0000 (13:15 +0100)]
ui: ceph: make version handling actually future proof
It seems we did not prepare the GUI enough for the API changes
planned when stopping to broadcast the old single string version. We
have to use the node specific versions, not the global 'versions'
object.
Also use the `PVE.Utils.compare_ceph_versions` everywhere, since some
versions are strings and others are the parts of the version (e.g.
["16", "2, "6"])
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 10 Nov 2021 12:15:55 +0000 (13:15 +0100)]
api: ceph: fix getting ceph versions
Since commit:
8a3a300b ("ceph services: drop broadcasting legacy
version pmxcfs KV")
The 'ceph-version' kv is not broadcasted anymore, so we should not
query it, instead use get_ceph_versions
Also drop the other legacy keys for the versions
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Grünbichler [Wed, 10 Nov 2021 13:28:04 +0000 (14:28 +0100)]
d/control: bump dep on pve-storage
for disk manage with deletion
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:55 +0000 (15:47 +0200)]
ui: node: storage removal: add checkbox for cleaning up storage config
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:54 +0000 (15:47 +0200)]
ui: node: storage removal: add checkbox for cleaning up disks
and factor out a SafeDestroyStorage sub-class to avoid duplication.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:53 +0000 (15:47 +0200)]
ui: node: add destroy menu for directory, lvm, lvmthin, zfs
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:52 +0000 (15:47 +0200)]
ui: utils: add task descriptions for disk removal
For 'dirremove', it already exists.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:51 +0000 (15:47 +0200)]
ui: node: lvmthin: add volume group to columns
to be able to identify thin pools even if they have the same name.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Mon, 25 Oct 2021 13:47:50 +0000 (15:47 +0200)]
ui: node: directory: use gettext for 'Directory'
It's also localised when adding a storage for example.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:50 +0000 (09:53 +0100)]
ui/UploadToStorage: check file extension
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:49 +0000 (09:53 +0100)]
ui/UploadToStorage: add TaskViewer
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:48 +0000 (09:53 +0100)]
fix #3505: ui/UploadToStorage: add checksum and algorithm
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:47 +0000 (09:53 +0100)]
ui: refactor UploadToStorage.js
this also removes the "content" selector from the window.
as far as it seems, this selector was never able to select
more than one entry, so it was useless.
the check for FormData() is also removed, because this is
supported by all major browsers for a long time. therefore
doStandardSubmit() is also not necessary.
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Lorenz Stechauner [Mon, 8 Nov 2021 08:53:46 +0000 (09:53 +0100)]
ui: move upload window into UploadToStorage.js
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Tue, 9 Nov 2021 17:35:12 +0000 (18:35 +0100)]
d/control: bump versioned dependency for pve-cluster
ensure we got the notes property for the datacenter config and also
the newly registered/watched jobs.cfg for future pveschedule patches.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 22 Sep 2021 10:42:18 +0000 (12:42 +0200)]
ui: close #3504: Add datacenter notes
Like notes for nodes.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Grünbichler [Tue, 9 Nov 2021 16:47:26 +0000 (17:47 +0100)]
d/control: bump b-d/depends
for replication and protection changes
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Ebner [Thu, 30 Sep 2021 11:42:15 +0000 (13:42 +0200)]
ui: prune: also handle new 'renamed' keep reason
The back-end no longer returns 'protected' for renamed backups, and
'protected' backups are now their own kind.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Thu, 30 Sep 2021 11:42:14 +0000 (13:42 +0200)]
ui: backup views: add button to change protection status
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Thu, 30 Sep 2021 11:42:13 +0000 (13:42 +0200)]
ui: backup views: add protected column
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Thu, 30 Sep 2021 11:42:12 +0000 (13:42 +0200)]
ui: storage content: avoid redundant options hasNotesColumn and hideColumns
Replace both by a showColumns option instead. As the current use of
hasNotesColumn already indicates, when new content-specific columns
are added, it is more natural for each derived class to specify the
columns it wants, rather than those it doesn't.
For hideColumns, there was no user. For hasNotesColumn, the only user
was the backup view.
Set the column information in the storage.BackupView class itself
rather than the instance (like hasNotesColumn was).
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Thu, 30 Sep 2021 11:42:11 +0000 (13:42 +0200)]
vzdump: skip protected backups for dumpdir pruning
Keeps the behavior consistent with what happens for storages. It also
is required to not get into conflict with the check in archive_remove,
i.e. pruning here marks a backup as 'remove' and then archive_remove
complains that it's protected.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 19 Oct 2021 07:54:59 +0000 (09:54 +0200)]
test: replication: remove mocking for obsolete volume_snapshot_list
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 19 Oct 2021 07:54:58 +0000 (09:54 +0200)]
test: replication: mock volume_snapshot_info
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Tue, 19 Oct 2021 07:54:57 +0000 (09:54 +0200)]
test: replication: avoid implicit return for volume_snapshot
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Tue, 9 Nov 2021 10:00:39 +0000 (11:00 +0100)]
ui: guest remove: modernize code and cleanup
drop only partially used intermediate value, use template strings,
reduce line bloat while trying to keep it readable.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Aaron Lauterer [Mon, 8 Nov 2021 09:56:12 +0000 (10:56 +0100)]
ui: lxc: resources: add Detach text for mountpoints
Instead of showing 'Remove' for a mountpoint, change the text to
'Detach' and only show 'Remove' for unused volumes.
This aligns the behaviour with VMs and will make it clear, that a
mountpoint first needs to be detached before it can be fully removed.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Thomas Lamprecht [Sun, 7 Nov 2021 20:23:14 +0000 (21:23 +0100)]
bump version to 7.0-14
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 5 Nov 2021 14:23:47 +0000 (15:23 +0100)]
ceph: fix version check shortcut
with 'get_node_kv', we get a hash which contains the value for
all nodes in the cluster (with the nodename as key), so we have to use
the value from the hash corresponding to our nodename.
also the 'str' property is inside the 'version' hash
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Sun, 7 Nov 2021 20:01:30 +0000 (21:01 +0100)]
ui: join info: rework error handling/checking for no-cluster
check if error is set before trying to access it and check for the
new HTTP code a newer pve-cluster may return, and do a more fuzzy
match for older ones.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Sun, 7 Nov 2021 19:57:37 +0000 (20:57 +0100)]
ui: join info: code cleanup and future proof
we may want to return null or an empty object for the join info on a
node without a cluster in the future (i.e., PVE 8.0+), so get
compatible for that now already as it costs not much and as we can
now use es2020 we even can write the object access nicer..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 29 Oct 2021 09:14:08 +0000 (11:14 +0200)]
ui: dc/Cluster: show errors on 'join' info in the view
so instead of getting the 'standalone node' message, the grid
is masked with the actual api error
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Fabian Ebner [Fri, 22 Oct 2021 09:07:50 +0000 (11:07 +0200)]
ui: guest backup grid: monitor store errors
so that users see when something went wrong.
Don't mask the grid directly, but rather only its view so that the
title bar can be used for selecting another storage during load.
Reported in the community forum:
https://forum.proxmox.com/threads/get-backups-from-proxmox-randomly-fails.98383/
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:29:03 +0000 (13:29 +0200)]
ui: window/Wizard: make it a little wider
for the multi disk panel, we want it to be just a little wider, so
that all form fields are still readable
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:29:02 +0000 (13:29 +0200)]
ui: add qemu/MultiHDEdit and use it in the wizard
uses the MultiDiskPanel as base and implements the necessary
functions/variables
this allows now to create a vm also without any disk
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:29:01 +0000 (13:29 +0200)]
ui: add lxc/MultiMPEdit and use in lxc/CreateWizard
uses the MultiDiskPanel as a base and implements the necessary
functions/values
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:29:00 +0000 (13:29 +0200)]
ui: add MultiDiskPanel
this adds a new panel where a user can add multiple disks, intended
for use in the wizard.
Has a simple grid for displaying the already added disks and displays
a warning triangle if the disk is not valid.
this is a base panel for adding multiple disks/mps for vms/ct
respectively.
this combines the shared behavior and layout and defines the functions
that subclasses must define
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:28:59 +0000 (13:28 +0200)]
ui: lxc/MPEdit: add selectFree toggle
that sets the given vmconfig at the start and selects the first
free mpid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:28:58 +0000 (13:28 +0200)]
ui: lxc/MPEdit: fire diskidchange event
when the diskid changes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Tue, 5 Oct 2021 11:28:57 +0000 (13:28 +0200)]
ui: lxc/MPEdit: add updateVMConfig
helper for the upcoming MultiMPEdit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Dominik Csapak [Wed, 3 Nov 2021 14:01:04 +0000 (15:01 +0100)]
ui: qemu/SystemEdit: add spacing and heading for 'firmware' options
So that they are more visually seperated from the rest of the options.
Use the same style as in the realm sync panel.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Thu, 28 Oct 2021 13:54:49 +0000 (15:54 +0200)]
ui: storage/PBSEdit: do not send server on edit
it's a fixed value for the storage config, so the api would reject it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Lorenz Stechauner [Mon, 11 Oct 2021 09:52:00 +0000 (11:52 +0200)]
ui: storage/PBSEdit: add port to server field
this gives users the chance to supply the port nr in the gui,
without having to add a extra new field to the panel.
using the same implementation as in RemoteEdit.js in PBS.
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Thomas Lamprecht [Thu, 21 Oct 2021 11:41:06 +0000 (13:41 +0200)]
ui: clarify labels for EFI/TPM storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stefan Reiter [Mon, 11 Oct 2021 12:55:20 +0000 (14:55 +0200)]
ui: add 'win11' ostype and set defaults in wizard
Windows 11 requires a TPM and secure boot, so try to auto-enable both.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Stefan Reiter [Mon, 11 Oct 2021 12:55:19 +0000 (14:55 +0200)]
ui: SystemEdit: promote advanced settings to normal
and reorder the panel a bit, as otherwise I found it *very* cluttered.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Thomas Lamprecht [Thu, 21 Oct 2021 10:15:14 +0000 (12:15 +0200)]
d/control: bump versioned dependency on libpve-storage-perl
to ensure the new selectable `preallocation` property is available.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Lorenz Stechauner [Tue, 12 Oct 2021 12:32:34 +0000 (14:32 +0200)]
fix 3850: ui: storage: using PreallocationSelector for file based storage types
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
Lorenz Stechauner [Tue, 12 Oct 2021 12:32:33 +0000 (14:32 +0200)]
ui: add PreallocationSelector
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
Dominik Csapak [Mon, 4 Oct 2021 07:50:00 +0000 (09:50 +0200)]
ui: resourcetree: move guest position on template creation
we sort templates at the end normally, but if we convert a guest to a
template, it was not moved in the tree
add it to the list of attributes that are checked for a move
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 15:01:48 +0000 (17:01 +0200)]
statd: rebalance_lxc_containers: use grep instead of for+next-if
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 14:37:05 +0000 (16:37 +0200)]
statd: rebalance_lxc_containers: code bload reduction
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Oguz Bektas [Thu, 14 Oct 2021 06:51:48 +0000 (08:51 +0200)]
pvestatd: fix rebalancing cpusets for cgroupv2
currently we only check the entry for cgroup v1 to decide if cores
should be rebalanced. extend the check to include cgroup v2 entries.
reported in forum [0]
[0]: https://forum.proxmox.com/threads/hard-set-streams-for-lxc-container.97768/
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 14:28:01 +0000 (16:28 +0200)]
ceph services: get_cluster_service: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 14:26:44 +0000 (16:26 +0200)]
ceph services: return early if versions stayed the same
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 14:25:09 +0000 (16:25 +0200)]
ceph services: drop broadcasting legacy version pmxcfs KV
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 20 Oct 2021 14:20:09 +0000 (16:20 +0200)]
pvenetcommit: better handle non-existent pending changes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Mon, 11 Oct 2021 07:14:23 +0000 (09:14 +0200)]
vzdump: pbs: suppress output from upload-log command
which ended up in the backup task log and can be confusing to users:
> INFO: Backup finished at 2021-10-11 08:40:38
> Result: {
> "data": null
> }
> INFO: Backup job finished successfully
For proxmox-backup-server < 2.0.11-1, there was no output for the
upload-log command.
Reported in the community forum:
https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>