]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
4 years agogui: ceph: add get_ceph_icon_html to utils
Dominik Csapak [Mon, 27 May 2019 12:13:57 +0000 (14:13 +0200)]
gui: ceph: add get_ceph_icon_html to utils

returns html code for a ceph health icon, will be used in Services.js

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: ceph: add 'old' to ceph health
Dominik Csapak [Mon, 27 May 2019 12:13:56 +0000 (14:13 +0200)]
gui: ceph: add 'old' to ceph health

this will be used for the dashboard to show outdated services/osds

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agogui: StateProvider: add fireevent option to set
Dominik Csapak [Mon, 27 May 2019 12:13:55 +0000 (14:13 +0200)]
gui: StateProvider: add fireevent option to set

this way, we can control if we want to fire the 'statechanged' event
when we set a value in the stateprovider

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agoadd cluster wide ceph api calls
Dominik Csapak [Mon, 27 May 2019 12:13:54 +0000 (14:13 +0200)]
add cluster wide ceph api calls

add two new api calls in /cluster/ceph

status:
the same as /nodes/NODE/ceph/status, but accessible without
nodename, which we don't need, as in the hyperconverged case, all nodes
have the ceph.conf which contains the info on how to connect to the
monitors

metadata:
combines data from the cluster filesystem about the services,
as well as the 'ceph YYY metadata' info we get from ceph.
with this info we can convieniently display which services exists,
which are running and which versions they have

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agofollowup code cleanup for: broadcast ceph service data to cluster
Thomas Lamprecht [Mon, 27 May 2019 13:41:37 +0000 (15:41 +0200)]
followup code cleanup for: broadcast ceph service data to cluster

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobroadcast ceph service data to cluster
Dominik Csapak [Mon, 27 May 2019 12:13:53 +0000 (14:13 +0200)]
broadcast ceph service data to cluster

so that we have a list of all existing ceph services in the cluster

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agofollowup code cleanup for: add get_local_services for ceph
Thomas Lamprecht [Mon, 27 May 2019 13:39:37 +0000 (15:39 +0200)]
followup code cleanup for: add get_local_services for ceph

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoadd get_local_services for ceph
Dominik Csapak [Mon, 27 May 2019 12:13:52 +0000 (14:13 +0200)]
add get_local_services for ceph

this returns a hash of existing service links for
mds/mgr/mons so that we know which services exists

this is necessary since ceph itself does not save if a service is
defined somewhere, only when it runs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agopvecfg: adapt version and release semantic
Thomas Lamprecht [Sun, 26 May 2019 13:58:16 +0000 (15:58 +0200)]
pvecfg: adapt version and release semantic

Wit commit a74ba607d4b02c5734c5480de62700f52f96ac71 we switched over
to using the dpkg-dev provided helpers to set package version,
architecture and such in the buildsystem.

But unlike other repositories we used the version also for giving it
back over the API through the during build generated PVE::pvecfg
module, which wasn't fully updated to the new style.

This patch does that, and also cleans up semantics a bit, the
following two changed:

release is now the Debian release, instead of the "package release"
(i.e., the -X part of a full package version).
version is now simply the full (pve-manager) version, e.g., 6.0-1 or
the currently for testing used 6.0-0+1

This allows to do everything we used this information for even in a
slightly easier way (no  string concat needed anymore), and fits also
with the terminology we often used in our public channels (mailing
lists, forum, website)

Remove some cruft as we touch things.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi/ceph: create mon: drop now unsupported set-uid on autkey create
Thomas Lamprecht [Sun, 26 May 2019 13:22:35 +0000 (15:22 +0200)]
api/ceph: create mon: drop now unsupported set-uid on autkey create

From Nautilus release changelog[0]:
> The auid property for cephx users and RADOS pools has been removed.
> This was an undocumented and partially implemented capability that
> allowed cephx users to map capabilities to RADOS pools that they
> “owned”. Because there are no users we have removed this support.

[0]: https://ceph.com/releases/v14-2-0-nautilus-released/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph install: pull out ceph packages and apt command
Thomas Lamprecht [Sun, 26 May 2019 11:41:13 +0000 (13:41 +0200)]
ceph install: pull out ceph packages and apt command

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph: install: run_command is imported, use directly
Thomas Lamprecht [Sun, 26 May 2019 11:39:41 +0000 (13:39 +0200)]
ceph: install: run_command is imported, use directly

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoceph: drop systemd_managed - we now always are
Thomas Lamprecht [Sun, 26 May 2019 11:35:39 +0000 (13:35 +0200)]
ceph: drop systemd_managed - we now always are

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi: install ceph: remove old cruft
Thomas Lamprecht [Sun, 26 May 2019 10:40:33 +0000 (12:40 +0200)]
api: install ceph: remove old cruft

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoservices; update 'PIDFile' to point directly to /run
Thomas Lamprecht [Sun, 26 May 2019 09:03:21 +0000 (11:03 +0200)]
services; update 'PIDFile' to point directly to /run

fixes a complaint from system:
> PIDFile= references path below legacy directory /var/run/'

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoapi apt versions: update package lists for PVE 6
Thomas Lamprecht [Fri, 24 May 2019 11:23:46 +0000 (13:23 +0200)]
api apt versions: update package lists for PVE 6

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobuildsys: switch upload dist over to buster
Thomas Lamprecht [Wed, 22 May 2019 19:34:47 +0000 (21:34 +0200)]
buildsys: switch upload dist over to buster

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobump version to 6.0-0+1
Thomas Lamprecht [Wed, 22 May 2019 19:34:06 +0000 (21:34 +0200)]
bump version to 6.0-0+1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agoui: followup: set background color to dark grey
Thomas Lamprecht [Fri, 17 May 2019 10:17:16 +0000 (12:17 +0200)]
ui: followup: set background color to dark grey

Finally make the "Create VM/CT" button distinct from the User
(earlier "Logout") button, this should make them stand out more

As main color the "Proxmox Dark Grey" from our branding guide was
choosen
https://www.proxmox.com/images/proxmox/Proxmox-Corporate-Brandguideline-2018.pdf

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agomake the logout button a menu and move the username there
Dominik Csapak [Thu, 18 Apr 2019 11:46:14 +0000 (13:46 +0200)]
make the logout button a menu and move the username there

so we have a more 'web-app' like appearance for the user

the menu contains links to:
* browser localstorage settings
* password change
* tfa change
* logout

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
4 years agod/control: fix mail-transport-agent-dependency-does-not-specify-default-mta
Thomas Lamprecht [Wed, 22 May 2019 19:29:21 +0000 (21:29 +0200)]
d/control: fix mail-transport-agent-dependency-does-not-specify-default-mta

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobump debian compat level to 11
Thomas Lamprecht [Wed, 22 May 2019 19:27:36 +0000 (21:27 +0200)]
bump debian compat level to 11

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agod/postinst: remove outdated transitions fixups
Thomas Lamprecht [Wed, 22 May 2019 19:16:23 +0000 (21:16 +0200)]
d/postinst: remove outdated transitions fixups

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
4 years agobuildsys: use dpkg-dev makefile helpers for pkg info
Thomas Lamprecht [Wed, 22 May 2019 19:15:47 +0000 (21:15 +0200)]
buildsys: use dpkg-dev makefile helpers for pkg info

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: FW log ratelimit: avoid access on possible undefined rate
Thomas Lamprecht [Thu, 16 May 2019 08:31:00 +0000 (10:31 +0200)]
ui: FW log ratelimit: avoid access on possible undefined rate

This is an optional parameter and needs to be guarded, a simple
"truthy" check is enough, as eithers it's missing or a more complex
string (i.e., it cannot be '0' or the like)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: FW log ratelimit: fix default value
Thomas Lamprecht [Thu, 16 May 2019 08:30:22 +0000 (10:30 +0200)]
ui: FW log ratelimit: fix default value

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: FW options: do not draw border arount rate limit separator
Thomas Lamprecht [Thu, 16 May 2019 07:48:37 +0000 (09:48 +0200)]
ui: FW options: do not draw border arount rate limit separator

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix lint errors introduced by NFS version option patch
Thomas Lamprecht [Thu, 16 May 2019 07:35:31 +0000 (09:35 +0200)]
fix lint errors introduced by NFS version option patch

fixes commit d3abac4335ddeb691d8fc10f53b8cafbc2796925

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobump version to 5.4-6
Thomas Lamprecht [Wed, 15 May 2019 14:20:40 +0000 (16:20 +0200)]
bump version to 5.4-6

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: bump version dependency of libpve-access-control
Thomas Lamprecht [Wed, 15 May 2019 14:21:41 +0000 (16:21 +0200)]
d/control: bump version dependency of libpve-access-control

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi/nodes journal: fix parameter types and add minimum
Thomas Lamprecht [Wed, 15 May 2019 14:12:20 +0000 (16:12 +0200)]
api/nodes journal: fix parameter types and add minimum

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agopartially revert "api/nodes journal: add and enforce parameter conflicts"
Thomas Lamprecht [Wed, 15 May 2019 14:02:09 +0000 (16:02 +0200)]
partially revert "api/nodes journal: add and enforce parameter conflicts"

This partially reverts commit f9b08743a5a2322427ebdce78eb84c990bae7e31
as we had some wrong assumptions about lastentries and the other
params, so just note conflicts in the description but let the tool
itself make the checks

This reverts commit f9b08743a5a2322427ebdce78eb84c990bae7e31.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #2185: add option to change nfs version on gui
Oguz Bektas [Wed, 15 May 2019 13:21:56 +0000 (15:21 +0200)]
fix #2185: add option to change nfs version on gui

this enables us to specify an nfs version while editing/creating an nfs
mount. it used to default to vers=3 without the ability to change it in
gui. now it supports: 3, 4, 4.1 and 4.2

it should also be possible to add further options in the future (rsize,
wsize, timeo, etc.) on this screen.

Co-Authored-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
5 years agoapi/nodes journal: add and enforce parameter conflicts
Thomas Lamprecht [Wed, 15 May 2019 13:16:22 +0000 (15:16 +0200)]
api/nodes journal: add and enforce parameter conflicts

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi/nodes: add journal to index
Thomas Lamprecht [Wed, 15 May 2019 13:15:51 +0000 (15:15 +0200)]
api/nodes: add journal to index

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agovzdump: allow plugins to set guest resume time
Thomas Lamprecht [Wed, 8 May 2019 17:23:37 +0000 (17:23 +0000)]
vzdump: allow plugins to set guest resume time

This refactors things a bit to avoid having the same two lines in 3
places and allows the plugin to set the "guest was resumed" time
stamp at the point it really was resumed, not only once the backup
completed (see #503). Further, if a plugin prints it's own
"resumed/running after X seconds" message, it can unset the vmstop
time and thus avoid printing the message twice.

related to a fix for #503

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: bump version dependency of proxmox-widget-toolkit
Thomas Lamprecht [Wed, 15 May 2019 12:29:33 +0000 (14:29 +0200)]
d/control: bump version dependency of proxmox-widget-toolkit

ensures we've the new Journal panel available

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: node: change syslog to JournalView and journal api
Dominik Csapak [Wed, 15 May 2019 09:15:14 +0000 (11:15 +0200)]
gui: node: change syslog to JournalView and journal api

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agonode: add journal api
Dominik Csapak [Wed, 15 May 2019 09:15:13 +0000 (11:15 +0200)]
node: add journal api

this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor

also you can give an unix epoch as time parameters

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix #2197: ui: editing CDROM doesn't require VM.Config.Disk rights
Thomas Lamprecht [Mon, 13 May 2019 17:24:24 +0000 (17:24 +0000)]
fix #2197: ui: editing CDROM doesn't require VM.Config.Disk rights

A user which just has the default role PVEVMUser on a VM is able to
edit the CDROM, either to no media or if storage permissions are
available also to other ISOs, through the API. So reflect this again
for the WebUI. We could add a check for "VM.Config.CDROM", but that's
not really worth, if we keep in mind that the Ext.Caps state is
heuristically only.

fixes commit d35b5b2afbe9287a90129d861cf6fa27b91c1ed3

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: NodeSelector: check status field for offline nodes
Dominik Csapak [Wed, 8 May 2019 09:12:23 +0000 (11:12 +0200)]
ui: NodeSelector: check status field for offline nodes

the memory stat is not available if the user has no audit privilges on
/nodes/NODENAME but the status is always available

also it makes simple more sense to check if it is online not only if the
memory value is there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd new parameters cidr(6) to the network api
Dominik Csapak [Fri, 3 May 2019 07:28:52 +0000 (09:28 +0200)]
add new parameters cidr(6) to the network api

to also allow to set it directly and not via address/netmask

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofollowup: do not break on mixed, as one with no level could follow
Thomas Lamprecht [Tue, 7 May 2019 17:51:02 +0000 (17:51 +0000)]
followup: do not break on mixed, as one with no level could follow

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowup code cleanup
Thomas Lamprecht [Tue, 7 May 2019 17:49:43 +0000 (17:49 +0000)]
followup code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #2183: fix blinking subscription and show unknown status
Dominik Csapak [Fri, 3 May 2019 12:06:13 +0000 (14:06 +0200)]
fix #2183: fix blinking subscription and show unknown status

we skip offline nodes, check for nodes without subscription,
and finally check for different levels

if for some reason we do not get any subscription status (should not happen)
we show 'unknown'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: TFAEdit: use new tfa api call
Dominik Csapak [Tue, 7 May 2019 13:22:20 +0000 (15:22 +0200)]
ui: TFAEdit: use new tfa api call

with the api call to userid/tfa we get the users tfa type as well
as the realm tfa type, so we can replace the call to the realm
with this

to properly show the loadmask, we want to initiate the api call when
the window is already shown, the 'show' event works for this

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: TFAEdit: change tfa_type default to null
Dominik Csapak [Tue, 7 May 2019 13:22:19 +0000 (15:22 +0200)]
ui: TFAEdit: change tfa_type default to null

If a dependency of a formula returns undefined, it will not get updated,
even if the other parts of the formula would work.

So we change the default to 'null' which gets handled differently,
but serves the same purpose for us.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofollouwp: reduce duplicate code
Thomas Lamprecht [Tue, 7 May 2019 13:30:50 +0000 (13:30 +0000)]
follouwp: reduce duplicate code

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage: handle empty response in case of file upload error
Tim Marx [Tue, 7 May 2019 11:46:03 +0000 (13:46 +0200)]
ui: storage: handle empty response in case of file upload error

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agobump version to 5.4-5
Thomas Lamprecht [Wed, 24 Apr 2019 11:28:35 +0000 (11:28 +0000)]
bump version to 5.4-5

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi: handle undefined shellcmd parameter better
Thomas Lamprecht [Wed, 24 Apr 2019 11:27:52 +0000 (11:27 +0000)]
api: handle undefined shellcmd parameter better

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi: ceph/osd: conciser metadata array to hash mapping
Thomas Lamprecht [Wed, 24 Apr 2019 10:24:21 +0000 (10:24 +0000)]
api: ceph/osd: conciser metadata array to hash mapping

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowup: refactor & code cleanup
Thomas Lamprecht [Wed, 24 Apr 2019 10:22:58 +0000 (10:22 +0000)]
followup: refactor & code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoadapt osd api call for ceph nautilus
Dominik Csapak [Fri, 19 Apr 2019 14:02:05 +0000 (16:02 +0200)]
adapt osd api call for ceph nautilus

ceph nautilus changed the structure of 'pg dump osds'
they moved the data one level below

parse both new and old format, and bail if it returns anything else

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoFix #482: Add timestamps to backup create task log
Dominic Jäger [Tue, 23 Apr 2019 07:04:49 +0000 (09:04 +0200)]
Fix #482: Add timestamps to backup create task log

Adding timestamps to the log messages facilitates troubleshooting.

We only log this in the task log, as the syslog and the backup log
(stored together with the backup on the target storage) already have
date/time prefixed, so only the task log missed this info in case of
multiple backups tasks for a single job.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
5 years agocall cfs_update() before retrieving cluster status
Fabian Grünbichler [Thu, 18 Apr 2019 08:54:53 +0000 (10:54 +0200)]
call cfs_update() before retrieving cluster status

otherwise this potentially returns outdated information (like the
cluster being quorate when corosync has crashed on all nodes 5 minutes
ago).

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agofix #1910: urlencode usernames in UserEdit
Dominik Csapak [Wed, 17 Apr 2019 12:31:22 +0000 (14:31 +0200)]
fix #1910: urlencode usernames in UserEdit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: tfa: handle if TFA setup with no specific type set
Dominik Csapak [Wed, 17 Apr 2019 12:28:22 +0000 (14:28 +0200)]
ui: tfa: handle if TFA setup with no specific type set

if we have no info about TFA in the userview (x as key instead of
x!oath or x!u2f) we disabled the whole window and the only action
was to delete

instead show all options, so the user can overwrite the setting

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.4-4
Thomas Lamprecht [Tue, 16 Apr 2019 14:24:05 +0000 (14:24 +0000)]
bump version to 5.4-4

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: tfa edit: fix initial state of delete button
Thomas Lamprecht [Tue, 16 Apr 2019 14:31:48 +0000 (14:31 +0000)]
ui: tfa edit: fix initial state of delete button

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agovzdump: code cleanup empty newlines
Thomas Lamprecht [Tue, 16 Apr 2019 14:16:21 +0000 (14:16 +0000)]
vzdump: code cleanup empty newlines

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agovzdump: use strftime for backup basename assembly
Thomas Lamprecht [Tue, 16 Apr 2019 14:08:54 +0000 (14:08 +0000)]
vzdump: use strftime for backup basename assembly

we already use POSIX strftime a lot in the stack, so nothing new,
also just use the perl built in localtime

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #263: only include node rrd stats if user has Sys.Audit
Thomas Lamprecht [Mon, 15 Apr 2019 13:45:18 +0000 (13:45 +0000)]
fix #263: only include node rrd stats if user has Sys.Audit

It makes sense to not give users without Sys.Audit permissions to
much information over a node and this is relatively easy and cheap to
check and enforce at those two points.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
5 years agofollowup: code cleanup and print error
Thomas Lamprecht [Tue, 16 Apr 2019 12:05:47 +0000 (12:05 +0000)]
followup: code cleanup and print error

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agopveceph: install ceph service print sucess message
Alwin Antreich [Tue, 9 Apr 2019 08:44:43 +0000 (10:44 +0200)]
pveceph: install ceph service print sucess message

This patch adds a success message on successful ceph.service
installation. And adds a newline to make a successful ceph package
installation more visible.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
5 years agofix #2177: use getValue() to get otp value
Wolfgang Bumiller [Tue, 16 Apr 2019 11:37:50 +0000 (13:37 +0200)]
fix #2177: use getValue() to get otp value

as '.value' isn't always valid

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agotfa: disable, not mask, other cards if tfa is already setup
Thomas Lamprecht [Tue, 16 Apr 2019 07:54:01 +0000 (07:54 +0000)]
tfa: disable, not mask, other cards if tfa is already setup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agotfa: comment that TOTP secret is meant to be base32
Thomas Lamprecht [Tue, 16 Apr 2019 07:53:27 +0000 (07:53 +0000)]
tfa: comment that TOTP secret is meant to be base32

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agomake jslint happier
Thomas Lamprecht [Tue, 16 Apr 2019 07:46:59 +0000 (07:46 +0000)]
make jslint happier

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: tfa: set initial tab based on current tfa type
Wolfgang Bumiller [Thu, 11 Apr 2019 09:32:02 +0000 (11:32 +0200)]
ui: tfa: set initial tab based on current tfa type

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agoui: tfa: mask panels for not currently used types
Wolfgang Bumiller [Thu, 11 Apr 2019 09:32:01 +0000 (11:32 +0200)]
ui: tfa: mask panels for not currently used types

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agoui: user view: show tfa type name
Wolfgang Bumiller [Thu, 11 Apr 2019 09:32:00 +0000 (11:32 +0200)]
ui: user view: show tfa type name

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agowww: parser: add parseTfaType helper
Wolfgang Bumiller [Thu, 11 Apr 2019 09:31:59 +0000 (11:31 +0200)]
www: parser: add parseTfaType helper

The tfa keys can now contain the type as additional
information, so let's parse it out.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agod/control: bump widget-toolkit version dependency
Thomas Lamprecht [Tue, 16 Apr 2019 06:08:10 +0000 (06:08 +0000)]
d/control: bump widget-toolkit version dependency

It's not that nothing would work without it, but ceph cannot be
configured via gui, and knowing that some user want to do strange
things with mixing package versions, we save us some hassle just
recording this to ensure one cannot run into this..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix ceph install wizard not accepting ipv6
Mira Limbeck [Mon, 15 Apr 2019 13:12:17 +0000 (15:12 +0200)]
fix ceph install wizard not accepting ipv6

changes the vtype to the newly defined IP64CIDRAddress. depends on the
introduction of the IP64CIDRAddress vtype in proxmox-widget-toolkit.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
5 years agod/control: bump doc-generator build dependency version
Dominic Jäger [Mon, 15 Apr 2019 10:17:43 +0000 (12:17 +0200)]
d/control: bump doc-generator build dependency version

When building a current version of pve-manager a dependency to the
documentation is missing, as it ships new references used by our
onlineHelp tooling this is required.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
5 years agocleanup Status plugins use statements
Thomas Lamprecht [Thu, 11 Apr 2019 07:21:12 +0000 (09:21 +0200)]
cleanup Status plugins use statements

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowup: code cleanup, remove unnecessary type check
Thomas Lamprecht [Thu, 11 Apr 2019 07:11:07 +0000 (09:11 +0200)]
followup: code cleanup, remove unnecessary type check

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1326: allow multiple status server definitions per type
Dominik Csapak [Wed, 10 Apr 2019 12:49:00 +0000 (14:49 +0200)]
fix #1326: allow multiple status server definitions per type

we allow an id like storage.cfg but leave it optional (so we do not
break existing configs):

 influxdb: name

so that one can export the data to multiple servers of the same type

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.4-3
Thomas Lamprecht [Wed, 10 Apr 2019 14:11:34 +0000 (16:11 +0200)]
bump version to 5.4-3

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: dc/options: allow to edit cluster wide migration settings
Thomas Lamprecht [Wed, 10 Apr 2019 14:04:34 +0000 (16:04 +0200)]
ui: dc/options: allow to edit cluster wide migration settings

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowuop: ui/dc/options: fix default
Thomas Lamprecht [Wed, 10 Apr 2019 13:35:38 +0000 (15:35 +0200)]
followuop: ui/dc/options: fix default

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: dc/options: allow to edit HA shutdown policy
Thomas Lamprecht [Wed, 10 Apr 2019 13:17:47 +0000 (15:17 +0200)]
ui: dc/options: allow to edit HA shutdown policy

add some helpers handling this, can be re used for adding the
migration field, maybe we want to move this to widget-toolkits parent
ObjectGrid class, a bit cleaned up.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: lxc: do not disable complete add resource button if no disk caps
Thomas Lamprecht [Wed, 10 Apr 2019 07:56:14 +0000 (09:56 +0200)]
ui: lxc: do not disable complete add resource button if no disk caps

While for now you only have elements which require the add disk
capability in the add sections it makes no sense to hide it, as it
would suggest that one can add no resource at all, and can easily
introduce a bug if we add another type of resource here, independent
of disk add cap.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1814: do not enable disk related buttons for audit user
Dominik Csapak [Tue, 9 Apr 2019 11:56:56 +0000 (13:56 +0200)]
fix #1814: do not enable disk related buttons for audit user

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: u2f: refactor error code map out and use in login window
Thomas Lamprecht [Wed, 10 Apr 2019 07:48:13 +0000 (09:48 +0200)]
ui: u2f: refactor error code map out and use in login window

to avoid showing numbers as error codes to users, even though the
strings are not much more helpful either...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoremove non-existant property
Dominik Csapak [Wed, 10 Apr 2019 07:31:04 +0000 (09:31 +0200)]
remove non-existant property

vmComboSelector does not have such a property

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: Restore: Fix error where the textfield did not default to next free VMID
Christian Ebner [Tue, 9 Apr 2019 12:11:25 +0000 (14:11 +0200)]
ui: Restore: Fix error where the textfield did not default to next free VMID

This was introduced when refactoring our seprated CT & VM ID
selectors into an unified one in
commit ed416f20248d46d95c9d1547a2e1b833aeb097d6

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
5 years agouse correct icon for hibernate in cmdmenu
Dominik Csapak [Tue, 9 Apr 2019 10:32:49 +0000 (12:32 +0200)]
use correct icon for hibernate in cmdmenu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix jslint warning
Dominik Csapak [Tue, 9 Apr 2019 10:32:48 +0000 (12:32 +0200)]
fix jslint warning

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.4-2
Thomas Lamprecht [Mon, 8 Apr 2019 15:43:33 +0000 (17:43 +0200)]
bump version to 5.4-2

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: bump version dependency to libpve-access-control
Thomas Lamprecht [Mon, 8 Apr 2019 15:38:09 +0000 (17:38 +0200)]
d/control: bump version dependency to libpve-access-control

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoapi: ceph/mon: improve no ip error
Thomas Lamprecht [Mon, 8 Apr 2019 15:36:54 +0000 (17:36 +0200)]
api: ceph/mon: improve no ip error

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: tfa: add onlineHelp
Thomas Lamprecht [Mon, 8 Apr 2019 15:31:03 +0000 (17:31 +0200)]
ui: tfa: add onlineHelp

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: qemu system panel: set onlineHelp
Thomas Lamprecht [Mon, 8 Apr 2019 15:24:32 +0000 (17:24 +0200)]
ui: qemu system panel: set onlineHelp

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoCeph MON - Reword error message on IP config
Alwin Antreich [Mon, 8 Apr 2019 11:50:18 +0000 (13:50 +0200)]
Ceph MON - Reword error message on IP config

Reword the error message in find_mon_ip to make it more clear, that
there is no active IP configuration for the ceph public network.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
5 years agoui: tfa login: wording followup
Thomas Lamprecht [Mon, 8 Apr 2019 14:59:50 +0000 (16:59 +0200)]
ui: tfa login: wording followup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: login: remove fixed OTP field completely
Thomas Lamprecht [Mon, 8 Apr 2019 13:48:32 +0000 (15:48 +0200)]
ui: login: remove fixed OTP field completely

we now have the TFALoginWindow which pops up if TFA is configured,
so use only this single stream lined approach.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: use 2-step authentication for non-tfa realms
Wolfgang Bumiller [Mon, 8 Apr 2019 11:58:30 +0000 (13:58 +0200)]
ui: use 2-step authentication for non-tfa realms

(Ext.Msg.prompt() fails on firefox...)

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
5 years agoHTTPServer: verify_ticket now returns a hash
Wolfgang Bumiller [Mon, 8 Apr 2019 11:58:29 +0000 (13:58 +0200)]
HTTPServer: verify_ticket now returns a hash

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>