]> git.proxmox.com Git - pve-manager.git/log
pve-manager.git
5 years agoui: dc/storage: allow to add CephFS
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:11 +0000 (13:20 +0100)]
ui: dc/storage: allow to add CephFS

Allow to add CephFS storage over GUI. Reuse viewcontroller and model from RBD
to detect if we can do a "hyper-converged" addition (with PVE maintained Ceph)
or if only external is possible.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: rbd: storage: obsolete strange getBinds binding assembly
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:10 +0000 (13:20 +0100)]
ui: rbd: storage: obsolete strange getBinds binding assembly

this was added for our (also in other places used):
> xtype: me.isCreate ? 'pveCephPoolSelector' : 'displayfield',
construct. But as displayfield does not has a submitValue setter we
cannot bind it generally.

So add such a setter with a small override and declare the bindings
direct when declaring the items, less side effects and all the
configurations for an item stays in the same place.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage: RBD: factor out view- model/controler
Thomas Lamprecht [Thu, 15 Nov 2018 12:20:09 +0000 (13:20 +0100)]
ui: storage: RBD: factor out view- model/controler

will be reused for CephFS, look at this with git's ignore whitespace
change flag '-w' to see that the changes consist mostly of indent and
hunk movement changes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1224: ui: ACLAdd: allow to filter by username
Thomas Lamprecht [Fri, 16 Nov 2018 11:12:57 +0000 (12:12 +0100)]
fix #1224: ui: ACLAdd: allow to filter by username

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1358: ui: show clustername besides 'Datacenter' node, if available
Thomas Lamprecht [Fri, 16 Nov 2018 09:00:00 +0000 (10:00 +0100)]
fix #1358: ui: show clustername besides 'Datacenter' node, if available

If we get the cluster name (successful login with '/' Sys.Audit
permissions) then display it in the resource tree's root node.

This updated on login and all ticket refreshs (every 15 minutes).
I currently have no functionallity to refresh it actively on cluster
create over WebUI, as it's not a straight forward change there.
Further, this is something which does not changes often (in
production), and we cannot detect CLI or API triggered (from non-pve
clients) cluster creations anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofollowup: split up and pull out html tags from gettext
Thomas Lamprecht [Fri, 16 Nov 2018 11:19:50 +0000 (12:19 +0100)]
followup: split up and pull out html tags from gettext

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1928: ct snapshot: changed rollback message to warning
Tim Marx [Fri, 16 Nov 2018 11:02:43 +0000 (12:02 +0100)]
fix #1928: ct snapshot: changed rollback message to warning

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agod/control: bump version dependency to pve-doc-generator
Thomas Lamprecht [Wed, 14 Nov 2018 15:20:51 +0000 (16:20 +0100)]
d/control: bump version dependency to pve-doc-generator

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoadd help button to 'My Settings' window
David Limbeck [Tue, 13 Nov 2018 12:48:26 +0000 (13:48 +0100)]
add help button to 'My Settings' window

link to 'gui_my_settings' in docs

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoEnable "Discard" option for IDE and SATA drives
Nick Chevsky [Wed, 14 Nov 2018 04:42:05 +0000 (23:42 -0500)]
Enable "Discard" option for IDE and SATA drives

Even though QEMU supports the discard feature for both ATA [1] and
SCSI drives, the "Discard" checkbox in Proxmox VE is artificially
restricted to SCSI drives. This change expands availability of the
"Discard" checkbox to all drive types supported by QEMU, leaving
VirtIO Block as the only remaining exclusion.

Combined with the new "SSD emulation" option [2], enabling discard
on IDE/SATA drives allows reclaiming of free space on thin-provisioned
storage with guests that do not support our SCSI controllers.

[1] https://github.com/qemu/qemu/commit/d353fb72f59cd0e1f67baf773e74719cda761a89
[2] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f9261fde2134cec35a5ec7c3ebbee5daa4d67ec7

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1959: remove invalid SLAAC option
David Limbeck [Thu, 25 Oct 2018 09:32:46 +0000 (11:32 +0200)]
fix #1959: remove invalid SLAAC option

nocloud configuration does not support SLAAC option, only static or dhcp
so this option shouldn't be available

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoadd_storage creates only one ceph storage entry
Alwin Antreich [Fri, 9 Nov 2018 16:43:16 +0000 (17:43 +0100)]
add_storage creates only one ceph storage entry

This patch removes the separate storage entries for CT & VM to the same
ceph pool. Instead only one entry is made as we can now map/unmap
volumes actively in pve-container.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: node/zfs: fix up order of variable declaration to match grid order
Thomas Lamprecht [Mon, 12 Nov 2018 11:31:44 +0000 (12:31 +0100)]
ui: node/zfs: fix up order of variable declaration to match grid order

It confused me twice and I enabled autoScroll on the wrong component,
so order it as it's layouted and remove the autoscroll completely,
not needed at all...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: node/zfs: fix stretch and scroll in details window
Thomas Lamprecht [Mon, 12 Nov 2018 11:26:38 +0000 (12:26 +0100)]
ui: node/zfs: fix stretch and scroll in details window

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agonode zfs: added panel to window as container for new components
Tim Marx [Mon, 12 Nov 2018 10:41:15 +0000 (11:41 +0100)]
node zfs: added panel to window as container for new components

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agonode zfs: added new component to display additional zfs details
Tim Marx [Mon, 12 Nov 2018 10:41:14 +0000 (11:41 +0100)]
node zfs: added new component to display additional zfs details

 ZFSStatus component got renamed to ZFSDevices to clarify that it only displays
 the device tree of the status command. The newly added component is now named
 ZFSStatus instead.

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agonode zfs: added read, write, cksum fields to device tree
Tim Marx [Mon, 12 Nov 2018 10:41:13 +0000 (11:41 +0100)]
node zfs: added read, write, cksum fields to device tree

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agobump version to 5.2-11
Thomas Lamprecht [Fri, 9 Nov 2018 16:00:30 +0000 (17:00 +0100)]
bump version to 5.2-11

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1969: increase max unused disks
David Limbeck [Mon, 5 Nov 2018 13:02:16 +0000 (14:02 +0100)]
fix #1969: increase max unused disks

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agofollowup: remove unnecessarry new line
Thomas Lamprecht [Fri, 9 Nov 2018 13:47:06 +0000 (14:47 +0100)]
followup: remove unnecessarry new line

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agonode zfs: added check for undefined & new case AVAIL
Tim Marx [Tue, 6 Nov 2018 12:48:48 +0000 (13:48 +0100)]
node zfs: added check for undefined & new case AVAIL

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agofixup: lxc/Resources: add missing trailing semicolon
Thomas Lamprecht [Fri, 9 Nov 2018 13:18:47 +0000 (14:18 +0100)]
fixup: lxc/Resources: add missing trailing semicolon

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: let users edit the vga memory
Dominik Csapak [Fri, 9 Nov 2018 12:31:10 +0000 (13:31 +0100)]
gui: let users edit the vga memory

and show the default for each type of virtual gpu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix mount point/unused disk sorting in Resources.js
David Limbeck [Fri, 9 Nov 2018 11:03:24 +0000 (12:03 +0100)]
fix mount point/unused disk sorting in Resources.js

use the same sort function as for VMs based on group and order

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agofix sorting for unused disks in HardwareView.js
David Limbeck [Fri, 9 Nov 2018 11:03:23 +0000 (12:03 +0100)]
fix sorting for unused disks in HardwareView.js

sort everything based on group and order for those with multiple numbered
entries

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoAdd "SSD emulation" property to IDE, SATA, and SCSI drives
Nick Chevsky [Thu, 8 Nov 2018 18:17:19 +0000 (13:17 -0500)]
Add "SSD emulation" property to IDE, SATA, and SCSI drives

When enabled, the "SSD emulation" feature exposes drives as
solid-state (rather than rotational) by enabling the new `ssd`
qm.conf flag [1] on the drives, which in turn sets QEMU's
`rotation_rate` property [2, 3] on the underlying devices.

This change also moves the "Discard" option out of the advanced
section and promotes it to the top of the dialog box, as proposed
by Thomas Lamprecht [4].

[1] https://git.proxmox.com/?p=qemu-server.git;a=commit;h=6c875f9f315f2dc7a0a3a988622c2efdf089b171
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1498042
[3] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00698.html
[4] https://pve.proxmox.com/pipermail/pve-devel/2018-November/034327.html

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
5 years agolxc/Features: not that keyctl is unnecessary for privileged
Thomas Lamprecht [Mon, 5 Nov 2018 12:02:52 +0000 (13:02 +0100)]
lxc/Features: not that keyctl is unnecessary for privileged

So that users are (hopefully) less confused why this is disabled for
privileged CTs. If we get more feature settings which only make
sense for unprivileged or privileged but not both we could split
this into sections which respective headings, but for one only I
didn't wanted to do this - so just add a boxLabel conditionally.

Cc: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: expose lxc features
Dominik Csapak [Mon, 5 Nov 2018 09:07:56 +0000 (10:07 +0100)]
gui: expose lxc features

but constrain editing to root@pam
give a checkbox (for now) for nfs and cifs, but keep all that are manually set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agovzdump: hook script example: s/openvz/lxc/
Thomas Lamprecht [Mon, 29 Oct 2018 10:09:57 +0000 (11:09 +0100)]
vzdump: hook script example: s/openvz/lxc/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix wrong permissions for subscription info
Dietmar Maurer [Tue, 30 Oct 2018 10:36:14 +0000 (11:36 +0100)]
fix wrong permissions for subscription info

workaround to keep the subscription popup on login even without 'Sys.Audit'
permissions but remove the subscription details in the GUI for unauthorized
users.

5 years agofollow up: cleanup long line
Thomas Lamprecht [Wed, 24 Oct 2018 11:22:58 +0000 (13:22 +0200)]
follow up: cleanup long line

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoadd wipe_disk option when destroying ceph disk
David Limbeck [Wed, 24 Oct 2018 09:45:44 +0000 (11:45 +0200)]
add wipe_disk option when destroying ceph disk

this allows the disk to be reused as ceph disk by zeroing the first 200M
of the destroyed disk. disks are iterated separately from partitions to
prevent duplicate wipes.

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
5 years agoadd pve-edk2-firmware to pveversion package list
Thomas Lamprecht [Tue, 23 Oct 2018 11:34:26 +0000 (13:34 +0200)]
add pve-edk2-firmware to pveversion package list

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofixup: Makefile: s/tests/test/
Thomas Lamprecht [Tue, 23 Oct 2018 10:49:10 +0000 (12:49 +0200)]
fixup: Makefile: s/tests/test/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agodc/user: render user fullnames htmlEncoded
Dominik Csapak [Fri, 19 Oct 2018 10:36:45 +0000 (12:36 +0200)]
dc/user: render user fullnames htmlEncoded

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agobuild: use pve-doc-generator to verify API
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:05 +0000 (13:02 +0200)]
build: use pve-doc-generator to verify API

and move API verification to 'check' target, where it belongs.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: use pve-doc-generator for bash-completion
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:04 +0000 (13:02 +0200)]
build: use pve-doc-generator for bash-completion

and bump build-depends accordingly

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: set PERL_DOC_INC_DIRS
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:03 +0000 (13:02 +0200)]
build: set PERL_DOC_INC_DIRS

this allows correct builds without pve-manager installed, with a clean
fall-back to the old behaviour in case pve-doc-generator is too old.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: pull REPOID into top-level Makefile
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:02 +0000 (13:02 +0200)]
build: pull REPOID into top-level Makefile

otherwise it is missing when building in a clean chroot via a generated
source packages.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agobuild: cleanup file generation
Fabian Grünbichler [Wed, 17 Oct 2018 11:02:01 +0000 (13:02 +0200)]
build: cleanup file generation

should happen in the default 'all' target, not in 'install'.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agoclose #584: ui qemu: changed remove unused disk to asynchron call
Tim Marx [Thu, 18 Oct 2018 11:23:28 +0000 (13:23 +0200)]
close #584: ui qemu: changed remove unused disk to asynchron call

Signed-off-by: Tim Marx <t.marx@proxmox.com>
5 years agod/control: add lintian to build depends
Thomas Lamprecht [Wed, 17 Oct 2018 08:07:23 +0000 (10:07 +0200)]
d/control: add lintian to build depends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agod/control: add libapt-pkg-perl also to build depends
Thomas Lamprecht [Wed, 17 Oct 2018 06:00:59 +0000 (08:00 +0200)]
d/control: add libapt-pkg-perl also to build depends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoCompleting Build-Depends
Rhonda D'Vine [Thu, 11 Oct 2018 10:05:20 +0000 (12:05 +0200)]
Completing Build-Depends

These were the missing Build-Depends that were needed in building this
package.

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
5 years agoUpdate default CIPHERS to a more current list
Rhonda D'Vine [Thu, 11 Oct 2018 10:05:19 +0000 (12:05 +0200)]
Update default CIPHERS to a more current list

The default CIPHERS allowed for a fair amount of not really considered
secure anymore connections.  This updated cipher list is taken from
mozilla: https://wiki.mozilla.org/Security/Server_Side_TLS

Signed-off-by: Rhonda D'Vine <rhonda@proxmox.com>
5 years agobump version to 5.2-10
Thomas Lamprecht [Tue, 16 Oct 2018 09:57:20 +0000 (11:57 +0200)]
bump version to 5.2-10

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agopvesh: fix bug #1942 - add standard options conditional
Dietmar Maurer [Tue, 16 Oct 2018 08:55:05 +0000 (10:55 +0200)]
pvesh: fix bug #1942 - add standard options conditional

Do not add/extract standard options if the method itself defined properties
using the same names (like 'quiet').

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
5 years agod/control: bump version dependency for libpve-common-perl
Thomas Lamprecht [Mon, 8 Oct 2018 12:16:11 +0000 (14:16 +0200)]
d/control: bump version dependency for libpve-common-perl

to ensure we have the /etc/hosts inotify read/write, needed for it's
gui part, methods available

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agouse 'die' instead of 'raise_param_exc'
Dietmar Maurer [Mon, 8 Oct 2018 11:14:51 +0000 (13:14 +0200)]
use 'die' instead of 'raise_param_exc'

Because there is not 'config' parameter.

5 years agoAPI2 : Network : add network config reload
Alexandre Derumier [Tue, 2 Oct 2018 07:19:38 +0000 (09:19 +0200)]
API2 : Network : add network config reload

This add a new api to online reload networking configuration
with ifupdown2.

This work with native ifupdown2 modules, as ifupdown2 have
interface dependency relationships.

Some specific interfaces options can't be reloaded online
(because kernel don't implement it), it this case, we ifdown/ifup
theses interfaces. (mainly vxlan interfaces options)

5 years agogui: dc/Tasks.js fix indentation
Dominik Csapak [Fri, 5 Oct 2018 08:19:23 +0000 (10:19 +0200)]
gui: dc/Tasks.js fix indentation

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: dc/Tasks.js fix trailing whitespace
Dominik Csapak [Fri, 5 Oct 2018 08:19:22 +0000 (10:19 +0200)]
gui: dc/Tasks.js fix trailing whitespace

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agomake /etc/hosts editable via gui
Dominik Csapak [Thu, 13 Sep 2018 12:55:56 +0000 (14:55 +0200)]
make /etc/hosts editable via gui

with adding the NodeHostsView to the node tabs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd /node/{NODE}/hosts API Call
Dominik Csapak [Wed, 12 Sep 2018 08:24:13 +0000 (10:24 +0200)]
add /node/{NODE}/hosts API Call

to get and set the content of /etc/hosts

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.2-9
Thomas Lamprecht [Thu, 13 Sep 2018 09:43:59 +0000 (11:43 +0200)]
bump version to 5.2-9

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: form/VMSelector: use SIMPLE mode for guest checkbox model
Thomas Lamprecht [Tue, 11 Sep 2018 07:48:25 +0000 (09:48 +0200)]
ui: form/VMSelector: use SIMPLE mode for guest checkbox model

Switch the default mode 'MULTI' with 'SIMPLE', the same we use in the
dc/Backup guest selector. It allows to remove the 'checkOnly'
setting, which limited selection and deselection of elements on the
checkbox it self, doing nothing when clicking on rows.

Besides the friendlier and more streamlined UX this actually fixes a
bug in Firefox (confirmed in version 62, possible in other versions
too) where select/deselect di not worked when clicking in the white
area of the checkbox, but only when clicking on the surrounding
padding.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: window/BulkAction: remove double '/' in api URL
Thomas Lamprecht [Tue, 11 Sep 2018 07:42:41 +0000 (09:42 +0200)]
ui: window/BulkAction: remove double '/' in api URL

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoswitch MP selector to integer input
Fabian Grünbichler [Wed, 5 Sep 2018 09:37:11 +0000 (11:37 +0200)]
switch MP selector to integer input

instead of combobox - 256 elements are too much.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agofix #1897: bump max number of mountpoints to 256
Fabian Grünbichler [Wed, 5 Sep 2018 09:37:10 +0000 (11:37 +0200)]
fix #1897: bump max number of mountpoints to 256

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
5 years agod/control: update build dependencies
Thomas Lamprecht [Thu, 6 Sep 2018 04:37:44 +0000 (06:37 +0200)]
d/control: update build dependencies

helpful for easier bootstrapping PVE, e.g., on buster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agocpumodelselector : add EPYC
Alexandre Derumier [Sun, 2 Sep 2018 05:52:59 +0000 (07:52 +0200)]
cpumodelselector : add EPYC

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agopveceph: remove 'btrfs' as fstype for new OSDs
Wolfgang Link [Fri, 31 Aug 2018 06:10:58 +0000 (08:10 +0200)]
pveceph: remove 'btrfs' as fstype for new OSDs

btrfs is deprecated since Luminous and it will no more be tested.

If btrfs is used, you have to add an extra parameter to ceph.conf
to allow ceph-disk to activate btrfs OSD's.
In our default config this is not the case.

From Luminous release note [1]:

"We no longer test the FileStore ceph-osd backend in combination with
btrfs. We recommend against using btrfs. If you are using
btrfs-based OSDs and want to upgrade to luminous you will need to
add the follwing to your ceph.conf:

enable experimental unrecoverable data corrupting features = btrfs
The code is mature and unlikely to change, but we are only
continuing to test the Jewel stable branch against btrfs. We
recommend moving these OSDs to FileStore with XFS or BlueStore."

[1] https://ceph.com/releases/v12-2-0-luminous-released/

5 years agofix #1884: vm/hardware: ensure correct value on pending changes
David Limbeck [Fri, 24 Aug 2018 09:05:52 +0000 (11:05 +0200)]
fix #1884: vm/hardware: ensure correct value on pending changes

e.g., pending deletion of cdrom/dvd drive showed as hard disk in
hardware tab

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agogui: allow whitespace in mp paths
Dominik Csapak [Wed, 22 Aug 2018 08:17:17 +0000 (10:17 +0200)]
gui: allow whitespace in mp paths

we do all necessary checks in the backend, and there we allow
whitespace in mp paths, so there is no need to restrict it in
the gui to non-whitespace characters

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.2-8
Thomas Lamprecht [Mon, 20 Aug 2018 13:12:23 +0000 (15:12 +0200)]
bump version to 5.2-8

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1872 Move button stays on the screen after closing
David Limbeck [Mon, 20 Aug 2018 09:57:34 +0000 (11:57 +0200)]
fix #1872 Move button stays on the screen after closing

5 years agofixe return values in /cluster/resources
Dominik Csapak [Fri, 17 Aug 2018 11:18:14 +0000 (13:18 +0200)]
fixe return values in /cluster/resources

openvz is deprecated but can still be a return value
maxcpu can be a real number (e.g., for CT if cpulimit is 1.5 and
cores is not set), and may not be an integer

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agofix #1393: use language from datacenter.cfg for gui
Dominik Csapak [Fri, 17 Aug 2018 07:26:21 +0000 (09:26 +0200)]
fix #1393: use language from datacenter.cfg for gui

if we do not have a language cookie, try to read
the language from the datacenter.cfg and fall back to 'en'

also set it into the 'Proxmox' object, so that the gui can show it
in the LoginWindow

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agogui: zfs over iscsi: only allow inputs that are relevant
Dominik Csapak [Fri, 10 Aug 2018 11:26:58 +0000 (13:26 +0200)]
gui: zfs over iscsi: only allow inputs that are relevant

some options are only relevant for some iscsi providers
so only allow thos who are relevant to the selected provider
and rename LIO target portal group to 'Target portal group'
since it is only active when lio is chosen

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix #1828: check if targetnode exists before starting mass migration
Dominik Csapak [Fri, 10 Aug 2018 09:18:25 +0000 (11:18 +0200)]
fix #1828: check if targetnode exists before starting mass migration

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix #1837: reorganize ha panel
Dominik Csapak [Wed, 8 Aug 2018 14:37:20 +0000 (16:37 +0200)]
fix #1837: reorganize ha panel

since the whole panel was scrollable instead of the individual ones,
selecting a ha service triggered the 'jump to focus' which made it
hard (if not impossible) to reach the edit/remove buttons for it

this patch reorganizes the panels in such a way that the status
panel is fixed height, and the content of the resource panel is
scrollable (always showing the edit/remove buttons)

to avoid not seeing the resources when one has a large number of
nodes, we make the individual panels collapsible

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd 'single' type for zfs creation
Dominik Csapak [Wed, 8 Aug 2018 08:20:10 +0000 (10:20 +0200)]
add 'single' type for zfs creation

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd ZFS list/detail/create gui
Dominik Csapak [Tue, 7 Aug 2018 14:51:11 +0000 (16:51 +0200)]
add ZFS list/detail/create gui

list shows zpools only, with detail the user can see
the status of the indiviual vdevs/mirrors

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agofix onlineHelp links for diskmanagement
Dominik Csapak [Tue, 7 Aug 2018 14:51:10 +0000 (16:51 +0200)]
fix onlineHelp links for diskmanagement

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agopveam update: add empty properties definition
Dietmar Maurer [Tue, 7 Aug 2018 09:31:20 +0000 (11:31 +0200)]
pveam update: add empty properties definition

To avoid warnings about undef value in RESTHandler.

5 years agoui: storage: do not allow empty TPG if LIO is selected
Thomas Lamprecht [Thu, 2 Aug 2018 16:25:56 +0000 (18:25 +0200)]
ui: storage: do not allow empty TPG if LIO is selected

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage: add enable/hide logic for LIO TPG field
Thomas Lamprecht [Thu, 2 Aug 2018 16:21:18 +0000 (18:21 +0200)]
ui: storage: add enable/hide logic for LIO TPG field

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui: storage: Linux LIO/targetcli support
Udo Rader [Thu, 26 Jul 2018 21:28:32 +0000 (23:28 +0200)]
ui: storage: Linux LIO/targetcli support

adding LIO option and dedicated "LIO target portal group" input field to the
"Add: ZFS via iSCSI" dialog

Signed-Off-By: Udo Rader <udo.rader@bestsolution.at>
5 years agoui/qemu: Extend Qemu Guest agent
Stoiko Ivanov [Wed, 1 Aug 2018 18:29:07 +0000 (20:29 +0200)]
ui/qemu: Extend Qemu Guest agent

Change to agent now being a property_string, and including  fstrim_cloned_disks.

Co-Authored-By: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
5 years agoui/Parser: printPropertyString: simplify and always put defaultKey values first
Thomas Lamprecht [Thu, 2 Aug 2018 14:00:56 +0000 (16:00 +0200)]
ui/Parser: printPropertyString: simplify and always put defaultKey values first

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui/Parser: parsePropertyString: log errors to console
Thomas Lamprecht [Thu, 2 Aug 2018 13:58:57 +0000 (15:58 +0200)]
ui/Parser: parsePropertyString: log errors to console

allows to catch bugs faster as we get a call trace and may see this
error even when our caller doesn't handle an undefined return value
from this method.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agoui/Parser: add generic functions property_strings
Stoiko Ivanov [Wed, 1 Aug 2018 18:29:06 +0000 (20:29 +0200)]
ui/Parser: add generic functions property_strings

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
5 years agoadd Directory list/create gui
Dominik Csapak [Mon, 30 Jul 2018 08:26:10 +0000 (10:26 +0200)]
add Directory list/create gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd LVMThin list/create gui
Dominik Csapak [Mon, 30 Jul 2018 08:26:09 +0000 (10:26 +0200)]
add LVMThin list/create gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoadd LVM List/Create Gui
Dominik Csapak [Mon, 30 Jul 2018 08:26:08 +0000 (10:26 +0200)]
add LVM List/Create Gui

only let the user change the name of the vg

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agomove DiskSelector to its own file, for generic use
Dominik Csapak [Mon, 30 Jul 2018 08:26:07 +0000 (10:26 +0200)]
move DiskSelector to its own file, for generic use

also set the default diskType to undefined and
change the api endpoint to /nodes/NODE/disks/list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agoui: storage: combine RBD external and hyperconverged add dialog
Thomas Lamprecht [Tue, 31 Jul 2018 08:28:06 +0000 (10:28 +0200)]
ui: storage: combine RBD external and hyperconverged add dialog

Combine both dialogues. This reduces storage choices from the
Storage -> Add menu, and thus improves usability.

We make the whole dialog also more intelligent by querying the
monitors, so that we can show them for the hyper converged case
keeping a similar interface for both cases. Further we can use this
to decide if a hyperconverged setup is possible at all.
While this information would also be available through the fact if
the pool selector has entries I wanted to show them anyway and could
make logic a bit easier using it.

5 years agofix doubleclick on vm with spice console
Dominik Csapak [Mon, 30 Jul 2018 09:37:32 +0000 (11:37 +0200)]
fix doubleclick on vm with spice console

allowSpice needs to be a real boolean, because of a
'=== true' check to open a spice console if allowed, so make it one here

this fixes the issue that a doubleclick on a tree item only opened
the novnc console even if spice is the default and the vm is spice
enabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
5 years agobump version to 5.2-7
Dietmar Maurer [Fri, 27 Jul 2018 09:47:38 +0000 (11:47 +0200)]
bump version to 5.2-7

5 years agopveproxy: add link to extjs for api-viewer
Thomas Lamprecht [Wed, 25 Jul 2018 09:21:31 +0000 (11:21 +0200)]
pveproxy: add link to extjs for api-viewer

allows us to remove the external loading of extjs from the cloudflare
cdn in pve-docs easier with having the external hosted version in
mind.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
5 years agocorrectly install PVE/CLI/pvesh.pm
Dietmar Maurer [Fri, 27 Jul 2018 05:45:20 +0000 (07:45 +0200)]
correctly install PVE/CLI/pvesh.pm

5 years agopvesh: add standard_output_properties to set/create/delete
Dietmar Maurer [Fri, 27 Jul 2018 05:34:49 +0000 (07:34 +0200)]
pvesh: add standard_output_properties to set/create/delete

Most of those API calls return simple strings, so it does not really matter.
Nethertheless, some calls return complex data structures and we want to set
output format for them.

5 years agopvesh cleanup: use a handler class - PVE/CLI/pvesh.pm
Dietmar Maurer [Thu, 26 Jul 2018 13:20:15 +0000 (15:20 +0200)]
pvesh cleanup: use a handler class - PVE/CLI/pvesh.pm

5 years agopvenode: remove useless call to query_terminal_options
Dietmar Maurer [Thu, 26 Jul 2018 10:55:28 +0000 (12:55 +0200)]
pvenode: remove useless call to query_terminal_options

5 years agopvenode: use print_api_result to print acme account information
Dietmar Maurer [Thu, 26 Jul 2018 08:54:04 +0000 (10:54 +0200)]
pvenode: use print_api_result to print acme account information

5 years agopvenode: use print_api_result to print certificate information
Dietmar Maurer [Wed, 25 Jul 2018 13:17:55 +0000 (15:17 +0200)]
pvenode: use print_api_result to print certificate information

5 years agopvenode: fixup output formatting
Dietmar Maurer [Wed, 25 Jul 2018 12:05:51 +0000 (14:05 +0200)]
pvenode: fixup output formatting

5 years agopvesh: implement 'ls' command
Dietmar Maurer [Wed, 25 Jul 2018 09:34:42 +0000 (11:34 +0200)]
pvesh: implement 'ls' command

5 years agopvesh: do not use CLIHandler $option parameter, simplify code
Dietmar Maurer [Tue, 24 Jul 2018 11:46:08 +0000 (13:46 +0200)]
pvesh: do not use CLIHandler $option parameter, simplify code

5 years agoui: permissions: allow to select root path '/' directly
Thomas Lamprecht [Wed, 25 Jul 2018 08:18:12 +0000 (10:18 +0200)]
ui: permissions: allow to select root path '/' directly

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>