test: run through perltidy

[pve-network.git] / src / test / run_test_zones.pl

diff --git a/src/test/run_test_zones.pl b/src/test/run_test_zones.pl
index 12e017a9cd1b76dfcbff2b0a59282a7af183b595..5354e4d30fe59eee4ebf2e93474e8718d4b1e048 100755 (executable)
--- a/src/test/run_test_zones.pl
+++ b/src/test/run_test_zones.pl
@@ -29,14 +29,13 @@ sub read_sdn_config {
     return $sdn_config;
 }
 
-
 my @tests = grep { -d } glob './zones/*/*';
 
 foreach my $test (@tests) {
 
-    my $sdn_config = read_sdn_config ("./$test/sdn_config");
+    my $sdn_config = read_sdn_config("./$test/sdn_config");
 
-    open my $fh1, '<', "./$test/interfaces" or die "can't read interfaces file";
+    open(my $fh1, '<', "./$test/interfaces") or die "can't read interfaces file - $!";
     my $interfaces_config = PVE::INotify::__read_etc_network_interfaces($fh1, undef, undef);
     close $fh1;
 
@@ -78,7 +77,7 @@ foreach my $test (@tests) {
        },
        find_bridge => sub {
            return;
-       }
+       },
     );
 
     my $sdn_module = Test::MockModule->new("PVE::Network::SDN");
@@ -91,15 +90,13 @@ foreach my $test (@tests) {
     my $name = $test;
     my $expected = read_file("./$test/expected_sdn_interfaces");
 
-    my $result = "";
-    eval {
-       $result = PVE::Network::SDN::Zones::generate_etc_network_config();
-    };
+    my $result = eval { PVE::Network::SDN::Zones::generate_etc_network_config() };
 
     if (my $err = $@) {
+       diag("got unexpected error - $err");
        fail($name);
     } else {
-       is ($result, $expected, $name);
+       is($result, $expected, $name);
     }
 
     if ($sdn_config->{controllers}) {
@@ -108,16 +105,17 @@ foreach my $test (@tests) {
 
        eval {
            my $config = PVE::Network::SDN::Controllers::generate_controller_config();
-           $controller_rawconfig = PVE::Network::SDN::Controllers::generate_controller_rawconfig($config);
+           $controller_rawconfig =
+               PVE::Network::SDN::Controllers::generate_controller_rawconfig($config);
        };
        if (my $err = $@) {
+           diag("got unexpected error - $err");
            fail($name);
        } else {
-           is ($controller_rawconfig, $expected, $name);
+           is($controller_rawconfig, $expected, $name);
        }
     }
 }
 
 done_testing();
 
-