]> git.proxmox.com Git - pve-qemu.git/commit - debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch
update submodule and patches to QEMU 8.2.2
authorFiona Ebner <f.ebner@proxmox.com>
Thu, 25 Apr 2024 15:21:28 +0000 (17:21 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 26 Apr 2024 12:14:06 +0000 (14:14 +0200)
commitf1eed34ac7af4dedc0a0bf476fbcb5f06e673ccd
tree971a82b541eac6da98eaf03112d1286478563e37
parent2e71c17f5b67a874ed9f00e21fa6fb8fd714ca3e
update submodule and patches to QEMU 8.2.2

This version includes both the AioContext lock and the block graph
lock, so there might be some deadlocks lurking. It's not possible to
disable the block graph lock like was done in QEMU 8.1, because there
are no changes like the function bdrv_schedule_unref() that require
it. QEMU 9.0 will finally get rid of the AioContext locking.

During live-restore with a VirtIO SCSI drive with iothread there is a
known racy deadlock related to the AioContext lock. Not new [1], but
not sure if more likely now. Should be fixed in QEMU 9.0.

The block graph lock comes with annotations that can be checked by
clang's TSA. This required changes to the block drivers, i.e.
alloc-track, pbs, zeroinit as well as taking the appropriate locks
in pve-backup, savevm-async, vma-reader.

Local variable shadowing is prohibited via a compiler flag now,
required slight adaptation in vma.c.

Major changes only affect alloc-track:

* It is not possible to call a generated co-wrapper like
  bdrv_get_info() while holding the block graph lock exclusively [0],
  which does happen during initialization of alloc-track when the
  backing hd is set and the refresh_limits driver callback is invoked.

  The bdrv_get_info() call to get the cluster size is moved to
  directly after opening the file child in track_open().

  The important thing is that at least the request alignment for the
  write target is used, because then the RMW cycle in bdrv_pwritev
  will gather enough data from the backing file. Partial cluster
  allocations in the target are not a fundamental issue, because the
  driver returns its allocation status based on the bitmap, so any
  other data that maps to the same cluster will still be copied later
  by a stream job (or during writes to that cluster).

* Replacing the node cannot be done in the
  track_co_change_backing_file() callback, because it is a coroutine
  and cannot hold the block graph lock exclusively. So it is moved to
  the stream job itself with the auto-remove option not having an
  effect anymore (qemu-server would always set it anyways).

  In the future, there could either be a special option for the stream
  job, or maybe the upcoming blockdev-replace QMP command can be used.

  Replacing the backing child is actually already done in the stream
  job, so no need to do it in the track_co_change_backing_file()
  callback. It also cannot be called from a coroutine. Looking at the
  implementation in the qcow2 driver, it doesn't seem to be intended
  to change the backing child itself, just update driver-internal
  state.

Other changes:

* alloc-track: Error out early when used without auto-remove. Since
  replacing the node now happens in the stream job, where the option
  cannot be read from (it's internal to the driver), it will always be
  treated as 'on'. Makes sure to have users beside qemu-server notice
  the change (should they even exist). The option can be fully dropped
  in the future while adding a version guard in qemu-server.

* alloc-track: Avoid seemingly superfluous child permission update.
  Doesn't seem necessary nowadays (maybe after commit "alloc-track:
  fix deadlock during drop" where the dropping is not rescheduled and
  delayed anymore or some upstream change). Replacing the block node
  will already update the permissions of the new node (which was the
  file child before). Should there really be some issue, instead of
  having a drop state, this could also be just based off the fact
  whether there is still a backing child.

  Dumping the cumulative (shared) permissions for the BDS with a debug
  print yields the same values after this patch and with QEMU 8.1,
  namely 3 and 5.

* PBS block driver: compile unconditionally. Proxmox VE always needs
  it and something in the build process changed to make it not enabled
  by default. Probably would need to move the build option to meson
  otherwise.

* backup: job unreferencing during cleanup needs to happen outside of
  coroutine, so it was moved to before invoking the clean

* mirror: Cherry-pick stable fix to avoid potential deadlock.

* savevm-async: migrate_init now can fail, so propagate potential
  error.

* savevm-async: compression counters are not accessible outside
  migration/ram-compress now, so drop code that prophylactically set
  it to zero.

[0]: https://lore.kernel.org/qemu-devel/220be383-3b0d-4938-b584-69ad214e5d5d@proxmox.com/
[1]: https://lore.kernel.org/qemu-devel/e13b488e-bf13-44f2-acca-e724d14f43fd@proxmox.com/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
82 files changed:
debian/patches/bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch
debian/patches/bitmap-mirror/0002-drive-mirror-add-support-for-conditional-and-always-.patch
debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch
debian/patches/bitmap-mirror/0004-mirror-switch-to-bdrv_dirty_bitmap_merge_internal.patch
debian/patches/bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch
debian/patches/extra/0001-monitor-qmp-fix-race-with-clients-disconnecting-earl.patch
debian/patches/extra/0003-ide-avoid-potential-deadlock-when-draining-during-tr.patch
debian/patches/extra/0004-migration-block-dirty-bitmap-fix-loading-bitmap-when.patch
debian/patches/extra/0005-Revert-Revert-graph-lock-Disable-locking-for-now.patch [deleted file]
debian/patches/extra/0005-Revert-x86-acpi-workaround-Windows-not-handling-name.patch [new file with mode: 0644]
debian/patches/extra/0006-migration-states-workaround-snapshot-performance-reg.patch [deleted file]
debian/patches/extra/0006-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch [new file with mode: 0644]
debian/patches/extra/0007-Revert-x86-acpi-workaround-Windows-not-handling-name.patch [deleted file]
debian/patches/extra/0007-mirror-Don-t-call-job_pause_point-under-graph-lock.patch [new file with mode: 0644]
debian/patches/extra/0008-target-i386-the-sgx_epc_get_section-stub-is-reachabl.patch [deleted file]
debian/patches/extra/0009-ui-clipboard-mark-type-as-not-available-when-there-i.patch [deleted file]
debian/patches/extra/0010-virtio-scsi-Attach-event-vq-notifier-with-no_poll.patch [deleted file]
debian/patches/extra/0011-virtio-Re-enable-notifications-after-drain.patch [deleted file]
debian/patches/extra/0012-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch [deleted file]
debian/patches/extra/0013-virtio-blk-avoid-using-ioeventfd-state-in-irqfd-cond.patch [deleted file]
debian/patches/pve/0001-PVE-Config-block-file-change-locking-default-to-off.patch
debian/patches/pve/0002-PVE-Config-Adjust-network-script-path-to-etc-kvm.patch
debian/patches/pve/0003-PVE-Config-set-the-CPU-model-to-kvm64-32-instead-of-.patch
debian/patches/pve/0004-PVE-Config-ui-spice-default-to-pve-certificates.patch
debian/patches/pve/0005-PVE-Config-glusterfs-no-default-logfile-if-daemonize.patch
debian/patches/pve/0006-PVE-Config-rbd-block-rbd-disable-rbd_cache_writethro.patch
debian/patches/pve/0007-PVE-Up-glusterfs-allow-partial-reads.patch
debian/patches/pve/0008-PVE-Up-qemu-img-return-success-on-info-without-snaps.patch
debian/patches/pve/0009-PVE-Up-qemu-img-dd-add-osize-and-read-from-to-stdin-.patch
debian/patches/pve/0010-PVE-Up-qemu-img-dd-add-isize-parameter.patch
debian/patches/pve/0011-PVE-Up-qemu-img-dd-add-n-skip_create.patch
debian/patches/pve/0012-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch
debian/patches/pve/0013-PVE-virtio-balloon-improve-query-balloon.patch
debian/patches/pve/0014-PVE-qapi-modify-query-machines.patch
debian/patches/pve/0015-PVE-qapi-modify-spice-query.patch
debian/patches/pve/0016-PVE-add-IOChannel-implementation-for-savevm-async.patch
debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch
debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch
debian/patches/pve/0019-PVE-block-add-the-zeroinit-block-driver-filter.patch
debian/patches/pve/0020-PVE-Add-dummy-id-command-line-parameter.patch
debian/patches/pve/0021-PVE-Config-Revert-target-i386-disable-LINT0-after-re.patch
debian/patches/pve/0022-PVE-Up-Config-file-posix-make-locking-optiono-on-cre.patch
debian/patches/pve/0024-PVE-Compat-4.0-used-balloon-qemu-4-0-config-size-fal.patch
debian/patches/pve/0025-PVE-Allow-version-code-in-machine-type.patch
debian/patches/pve/0026-block-backup-move-bcs-bitmap-initialization-to-job-c.patch
debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch
debian/patches/pve/0028-PVE-Backup-add-backup-dump-block-driver.patch
debian/patches/pve/0029-PVE-Add-sequential-job-transaction-support.patch
debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch
debian/patches/pve/0031-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch
debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
debian/patches/pve/0033-PVE-redirect-stderr-to-journal-when-daemonized.patch
debian/patches/pve/0034-PVE-Migrate-dirty-bitmap-state-via-savevm.patch
debian/patches/pve/0035-migration-block-dirty-bitmap-migrate-other-bitmaps-e.patch
debian/patches/pve/0036-PVE-fall-back-to-open-iscsi-initiatorname.patch
debian/patches/pve/0037-PVE-block-stream-increase-chunk-size.patch
debian/patches/pve/0038-block-io-accept-NULL-qiov-in-bdrv_pad_request.patch
debian/patches/pve/0039-block-add-alloc-track-driver.patch
debian/patches/pve/0040-Revert-block-rbd-workaround-for-ceph-issue-53784.patch
debian/patches/pve/0041-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch
debian/patches/pve/0042-Revert-block-rbd-implement-bdrv_co_block_status.patch
debian/patches/pve/0043-alloc-track-error-out-when-auto-remove-is-not-set.patch [new file with mode: 0644]
debian/patches/pve/0043-alloc-track-fix-deadlock-during-drop.patch [deleted file]
debian/patches/pve/0044-alloc-track-avoid-seemingly-superfluous-child-permis.patch [new file with mode: 0644]
debian/patches/pve/0044-migration-for-snapshots-hold-the-BQL-during-setup-ca.patch [deleted file]
debian/patches/pve/0045-block-copy-before-write-fix-permission.patch [new file with mode: 0644]
debian/patches/pve/0045-savevm-async-don-t-hold-BQL-during-setup.patch [deleted file]
debian/patches/pve/0046-block-copy-before-write-fix-permission.patch [deleted file]
debian/patches/pve/0046-block-copy-before-write-support-unligned-snapshot-di.patch [new file with mode: 0644]
debian/patches/pve/0047-block-copy-before-write-create-block_copy-bitmap-in-.patch [new file with mode: 0644]
debian/patches/pve/0047-block-copy-before-write-support-unligned-snapshot-di.patch [deleted file]
debian/patches/pve/0048-block-copy-before-write-create-block_copy-bitmap-in-.patch [deleted file]
debian/patches/pve/0048-qapi-blockdev-backup-add-discard-source-parameter.patch [new file with mode: 0644]
debian/patches/pve/0049-copy-before-write-allow-specifying-minimum-cluster-s.patch [new file with mode: 0644]
debian/patches/pve/0049-qapi-blockdev-backup-add-discard-source-parameter.patch [deleted file]
debian/patches/pve/0050-backup-add-minimum-cluster-size-to-performance-optio.patch [new file with mode: 0644]
debian/patches/pve/0050-copy-before-write-allow-specifying-minimum-cluster-s.patch [deleted file]
debian/patches/pve/0051-PVE-backup-add-fleecing-option.patch [new file with mode: 0644]
debian/patches/pve/0051-backup-add-minimum-cluster-size-to-performance-optio.patch [deleted file]
debian/patches/pve/0052-PVE-backup-add-fleecing-option.patch [deleted file]
debian/patches/series
qemu