]> git.proxmox.com Git - pve-qemu.git/commit - debian/patches/pve/0033-PVE-add-query_proxmox_support-QMP-command.patch
fix saving and loading dirty bitmaps in snapshots
authorStefan Reiter <s.reiter@proxmox.com>
Tue, 16 Mar 2021 16:30:22 +0000 (17:30 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 16 Mar 2021 19:44:06 +0000 (20:44 +0100)
commite9b36665c76dcf4c327c2c7c5fe5df6cb1b18fba
treef02ffc796597a49015a64146313ae9c821d585b7
parent970196fc93189975e730b5ef16884ef18a391c57
fix saving and loading dirty bitmaps in snapshots

Saving dirty bitmaps from our savevm-async code didn't work, since we
use a coroutine which holds the iothread mutex already (upstream savevm
is sync, migration uses a thread). Release the mutex before calling the
one function that (according to it's documentation) requires the lock to
*not* be held: qemu_savevm_state_pending.

Additionally, loading dirty bitmaps requires a call to
dirty_bitmap_mig_before_vm_start after "loadvm", which the upstream
savevm does explicitly afterwards - do that too.

This is exposed via the query-proxmox-support property
"pbs-dirty-bitmap-savevm".

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch
debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch
debian/patches/pve/0033-PVE-add-query_proxmox_support-QMP-command.patch
debian/patches/pve/0034-PVE-add-query-pbs-bitmap-info-QMP-call.patch
debian/patches/pve/0037-PVE-Backup-Use-a-transaction-to-synchronize-job-stat.patch
debian/patches/pve/0038-PVE-Backup-Don-t-block-on-finishing-and-cleanup-crea.patch
debian/patches/pve/0039-PVE-Migrate-dirty-bitmap-state-via-savevm.patch
debian/patches/pve/0042-PVE-Use-coroutine-QMP-for-backup-cancel_backup.patch
debian/patches/pve/0043-PBS-add-master-key-support.patch