]> git.proxmox.com Git - pve-storage.git/blame - PVE/Storage/RBDPlugin.pm
bump version to 4.0-24
[pve-storage.git] / PVE / Storage / RBDPlugin.pm
CommitLineData
0509010d
AD
1package PVE::Storage::RBDPlugin;
2
3use strict;
4use warnings;
5use IO::File;
6use PVE::Tools qw(run_command trim);
7use PVE::Storage::Plugin;
8use PVE::JSONSchema qw(get_standard_option);
9
10use base qw(PVE::Storage::Plugin);
11
249cb647
SP
12sub rbd_unittobytes {
13 {
14 "M" => 1024*1024,
15 "G" => 1024*1024*1024,
16 "T" => 1024*1024*1024*1024,
17 }
18}
19
8897f5dc
SP
20my $add_pool_to_disk = sub {
21 my ($scfg, $disk) = @_;
22
23 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
24
25 return "$pool/$disk";
26};
27
411476cd
DM
28my $rbd_cmd = sub {
29 my ($scfg, $storeid, $op, @options) = @_;
0509010d 30
e5427b00 31 my $monhost = $scfg->{monhost};
0509010d
AD
32 $monhost =~ s/;/,/g;
33
1440604a
AD
34 my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
35 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
36 my $username = $scfg->{username} ? $scfg->{username} : 'admin';
37
38 my $cmd = ['/usr/bin/rbd', '-p', $pool, '-m', $monhost];
39
40 if(-e $keyring){
41 push @$cmd, '-n', "client.$username";
42 push @$cmd, '--keyring', $keyring;
43 push @$cmd, '--auth_supported', 'cephx';
44 }else{
45 push @$cmd, '--auth_supported', 'none';
46 }
47
48 push @$cmd, $op;
3e195ccc 49
411476cd 50 push @$cmd, @options if scalar(@options);
3e195ccc 51
411476cd
DM
52 return $cmd;
53};
0509010d 54
69589444
AD
55my $rados_cmd = sub {
56 my ($scfg, $storeid, $op, @options) = @_;
57
58 my $monhost = $scfg->{monhost};
59 $monhost =~ s/;/,/g;
60
1440604a
AD
61 my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
62 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
63 my $username = $scfg->{username} ? $scfg->{username} : 'admin';
64
65 my $cmd = ['/usr/bin/rados', '-p', $pool, '-m', $monhost];
66
67 if(-e $keyring){
68 push @$cmd, '-n', "client.$username";
69 push @$cmd, '--keyring', $keyring;
70 push @$cmd, '--auth_supported', 'cephx';
71 }else{
72 push @$cmd, '--auth_supported', 'none';
73 }
74
75 push @$cmd, $op;
69589444
AD
76
77 push @$cmd, @options if scalar(@options);
78
79 return $cmd;
80};
81
c693f749
SP
82sub run_rbd_command {
83 my ($cmd, %args) = @_;
84
85 my $lasterr;
86 my $errmsg = $args{errmsg} . ": " || "";
c97c5b3b 87 if (!exists($args{errfunc})) {
c693f749
SP
88 # ' error: 2014-02-06 11:51:59.839135 7f09f94d0760 -1 librbd: snap_unprotect: can't unprotect;
89 # at least 1 child(ren) in pool cephstor1
90 $args{errfunc} = sub {
c97c5b3b
DM
91 my $line = shift;
92 if ($line =~ m/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d+ [0-9a-f]+ [\-\d]+ librbd: (.*)$/) {
93 $lasterr = "$1\n";
94 } else {
95 $lasterr = $line;
96 }
97 print STDERR $lasterr;
98 *STDERR->flush();
99 };
100 }
101
102 eval { run_command($cmd, %args); };
103 if (my $err = $@) {
104 die $errmsg . $lasterr if length($lasterr);
105 die $err;
c693f749
SP
106 }
107
c97c5b3b 108 return undef;
c693f749
SP
109}
110
411476cd
DM
111sub rbd_ls {
112 my ($scfg, $storeid) = @_;
d70e7f6c 113
7cb2889a 114 my $cmd = &$rbd_cmd($scfg, $storeid, 'ls', '-l');
1440604a 115 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
d70e7f6c 116
411476cd 117 my $list = {};
0509010d 118
8c3abf12 119 my $parser = sub {
411476cd 120 my $line = shift;
0509010d 121
ca1e168a
AD
122 if ($line =~ m/^((vm|base)-(\d+)-disk-\d+)\s+(\d+)(M|G|T)\s((\S+)\/((vm|base)-\d+-\S+@\S+))?/) {
123 my ($image, $owner, $size, $unit, $parent) = ($1, $3, $4, $5, $8);
0509010d 124
1440604a 125 $list->{$pool}->{$image} = {
411476cd 126 name => $image,
249cb647 127 size => $size*rbd_unittobytes()->{$unit},
62b98a65 128 parent => $parent,
411476cd
DM
129 vmid => $owner
130 };
131 }
8c3abf12
DM
132 };
133
134 eval {
c693f749 135 run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
8c3abf12
DM
136 };
137 my $err = $@;
138
139 die $err if $err && $err !~ m/doesn't contain rbd images/ ;
411476cd
DM
140
141 return $list;
0509010d
AD
142}
143
62b98a65 144sub rbd_volume_info {
992e6835
AD
145 my ($scfg, $storeid, $volname, $snap) = @_;
146
147 my $cmd = undef;
148
149 if($snap){
150 $cmd = &$rbd_cmd($scfg, $storeid, 'info', $volname, '--snap', $snap);
151 }else{
152 $cmd = &$rbd_cmd($scfg, $storeid, 'info', $volname);
153 }
e110213e 154
e110213e 155 my $size = undef;
62b98a65 156 my $parent = undef;
992e6835
AD
157 my $format = undef;
158 my $protected = undef;
62b98a65 159
e110213e
AD
160 my $parser = sub {
161 my $line = shift;
162
249cb647
SP
163 if ($line =~ m/size (\d+) (M|G|T)B in (\d+) objects/) {
164 $size = $1 * rbd_unittobytes()->{$2} if ($1);
62b98a65
AD
165 } elsif ($line =~ m/parent:\s(\S+)\/(\S+)/) {
166 $parent = $2;
992e6835
AD
167 } elsif ($line =~ m/format:\s(\d+)/) {
168 $format = $1;
169 } elsif ($line =~ m/protected:\s(\S+)/) {
170 $protected = 1 if $1 eq "True";
e110213e 171 }
992e6835 172
e110213e
AD
173 };
174
c693f749 175 run_rbd_command($cmd, errmsg => "rbd error", errfunc => sub {}, outfunc => $parser);
e110213e 176
992e6835 177 return ($size, $parent, $format, $protected);
e110213e
AD
178}
179
e5427b00 180# Configuration
0509010d 181
e5427b00
AD
182PVE::JSONSchema::register_format('pve-storage-monhost', \&parse_monhost);
183sub parse_monhost {
0509010d
AD
184 my ($name, $noerr) = @_;
185
186 if ($name !~ m/^[a-z][a-z0-9\-\_\.]*[a-z0-9]$/i) {
187 return undef if $noerr;
188 die "lvm name '$name' contains illegal characters\n";
189 }
190
191 return $name;
192}
193
0509010d
AD
194sub type {
195 return 'rbd';
196}
197
198sub plugindata {
199 return {
1f79bb07 200 content => [ {images => 1, rootdir => 1}, { images => 1 }],
0509010d
AD
201 };
202}
203
204sub properties {
205 return {
e5427b00 206 monhost => {
0509010d 207 description => "Monitors daemon ips.",
e5427b00 208 type => 'string',
0509010d 209 },
e5427b00
AD
210 pool => {
211 description => "Pool.",
0509010d
AD
212 type => 'string',
213 },
e5427b00
AD
214 username => {
215 description => "RBD Id.",
0509010d
AD
216 type => 'string',
217 },
e5427b00 218 authsupported => {
0509010d
AD
219 description => "Authsupported.",
220 type => 'string',
221 },
9f20a8a6
AD
222 krbd => {
223 description => "Access rbd through krbd kernel module.",
224 type => 'boolean',
225 },
0509010d
AD
226 };
227}
228
229sub options {
230 return {
35d6dfaf
AD
231 nodes => { optional => 1 },
232 disable => { optional => 1 },
e5427b00 233 monhost => { fixed => 1 },
1440604a
AD
234 pool => { optional => 1 },
235 username => { optional => 1 },
0509010d 236 content => { optional => 1 },
9f20a8a6 237 krbd => { optional => 1 },
0509010d
AD
238 };
239}
240
241# Storage implementation
242
243sub parse_volname {
244 my ($class, $volname) = @_;
245
d04c7e55 246 if ($volname =~ m/^((base-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) {
7800e84d 247 return ('images', $4, $7, $2, $3, $5, 'raw');
0509010d
AD
248 }
249
250 die "unable to parse rbd volume name '$volname'\n";
251}
252
253sub path {
38e6ec3f 254 my ($class, $scfg, $volname, $storeid, $snapname) = @_;
0509010d
AD
255
256 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
38e6ec3f 257 $name .= '@'.$snapname if $snapname;
0509010d 258
a8176f54
AD
259 my $monhost = $scfg->{monhost};
260 $monhost =~ s/:/\\:/g;
261
1440604a
AD
262 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
263 my $username = $scfg->{username} ? $scfg->{username} : 'admin';
264
265 my $path = "rbd:$pool/$name:mon_host=$monhost";
266 my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring";
267
268 if(-e $keyring ){
269 $path .= ":id=$username:auth_supported=cephx:keyring=$keyring";
270 }else{
271 $path .= ":auth_supported=none";
272 }
0509010d 273
9f20a8a6
AD
274 $path = "/dev/rbd/$pool/$name" if $scfg->{krbd};
275
0509010d
AD
276 return ($path, $vmid, $vtype);
277}
278
5b9b9b14
AD
279my $find_free_diskname = sub {
280 my ($storeid, $scfg, $vmid) = @_;
281
282 my $rbd = rbd_ls($scfg, $storeid);
1440604a 283 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
5b9b9b14 284 my $disk_ids = {};
1440604a 285 my $dat = $rbd->{$pool};
5b9b9b14
AD
286
287 foreach my $image (keys %$dat) {
288 my $volname = $dat->{$image}->{name};
289 if ($volname =~ m/(vm|base)-$vmid-disk-(\d+)/){
290 $disk_ids->{$2} = 1;
291 }
292 }
293 #fix: can we search in $rbd hash key with a regex to find (vm|base) ?
294 for (my $i = 1; $i < 100; $i++) {
295 if (!$disk_ids->{$i}) {
296 return "vm-$vmid-disk-$i";
297 }
298 }
299
300 die "unable to allocate an image name for VM $vmid in storage '$storeid'\n";
301};
302
5eab0272
DM
303sub create_base {
304 my ($class, $storeid, $scfg, $volname) = @_;
305
992e6835
AD
306 my $snap = '__base__';
307
308 my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
309 $class->parse_volname($volname);
310
311 die "create_base not possible with base image\n" if $isBase;
312
313 my ($size, $parent, $format, undef) = rbd_volume_info($scfg, $storeid, $name);
314 die "rbd volume info on '$name' failed\n" if !($size);
315
316 die "rbd image must be at format V2" if $format ne "2";
317
318 die "volname '$volname' contains wrong information about parent $parent $basename\n"
319 if $basename && (!$parent || $parent ne $basename."@".$snap);
320
321 my $newname = $name;
322 $newname =~ s/^vm-/base-/;
323
324 my $newvolname = $basename ? "$basename/$newname" : "$newname";
325
8897f5dc 326 my $cmd = &$rbd_cmd($scfg, $storeid, 'rename', &$add_pool_to_disk($scfg, $name), &$add_pool_to_disk($scfg, $newname));
c693f749 327 run_rbd_command($cmd, errmsg => "rbd rename '$name' error");
992e6835
AD
328
329 my $running = undef; #fixme : is create_base always offline ?
330
331 $class->volume_snapshot($scfg, $storeid, $newname, $snap, $running);
332
333 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $newname, $snap);
334
335 if (!$protected){
336 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $newname, '--snap', $snap);
2362bc87 337 run_rbd_command($cmd, errmsg => "rbd protect $newname snap '$snap' error");
992e6835
AD
338 }
339
340 return $newvolname;
341
5eab0272
DM
342}
343
344sub clone_image {
f236eaf8 345 my ($class, $scfg, $storeid, $volname, $vmid, $snapname) = @_;
5eab0272 346
f2708285 347 my $snap = '__base__';
f236eaf8 348 $snap = $snapname if length $snapname;
f2708285
AD
349
350 my ($vtype, $basename, $basevmid, undef, undef, $isBase) =
351 $class->parse_volname($volname);
352
63da6d79
DM
353 die "$volname is not a base image and snapname is not provided\n"
354 if !$isBase && !length($snapname);
f2708285
AD
355
356 my $name = &$find_free_diskname($storeid, $scfg, $vmid);
357
f236eaf8
SP
358 warn "clone $volname: $basename snapname $snap to $name\n";
359
63da6d79 360 if (length($snapname)) {
f236eaf8
SP
361 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $volname, $snapname);
362
63da6d79 363 if (!$protected) {
f236eaf8
SP
364 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'protect', $volname, '--snap', $snapname);
365 run_rbd_command($cmd, errmsg => "rbd protect $volname snap $snapname error");
366 }
367 }
f2708285
AD
368
369 my $newvol = "$basename/$name";
63da6d79
DM
370 $newvol = $name if length($snapname);
371
372 my $cmd = &$rbd_cmd($scfg, $storeid, 'clone', &$add_pool_to_disk($scfg, $basename),
373 '--snap', $snap, &$add_pool_to_disk($scfg, $name));
f2708285 374
c693f749 375 run_rbd_command($cmd, errmsg => "rbd clone '$basename' error");
f2708285
AD
376
377 return $newvol;
5eab0272
DM
378}
379
0509010d
AD
380sub alloc_image {
381 my ($class, $storeid, $scfg, $vmid, $fmt, $name, $size) = @_;
382
383
e5427b00 384 die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
0509010d 385 if $name && $name !~ m/^vm-$vmid-/;
0509010d 386
3fad2603 387 $name = &$find_free_diskname($storeid, $scfg, $vmid) if !$name;
0509010d 388
a8c3f8f6 389 my $cmd = &$rbd_cmd($scfg, $storeid, 'create', '--image-format' , 2, '--size', int(($size+1023)/1024), $name);
c693f749 390 run_rbd_command($cmd, errmsg => "rbd create $name' error");
0509010d
AD
391
392 return $name;
393}
394
395sub free_image {
32437ed2 396 my ($class, $storeid, $scfg, $volname, $isBase) = @_;
0509010d 397
42d07b9a
AD
398 my ($vtype, $name, $vmid, undef, undef, undef) =
399 $class->parse_volname($volname);
400
401 if ($isBase) {
402 my $snap = '__base__';
403 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $name, $snap);
404 if ($protected){
405 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
2362bc87 406 run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
42d07b9a
AD
407 }
408 }
409
515ef80b
WL
410 $class->deactivate_volume($storeid, $scfg, $volname);
411
42d07b9a 412 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'purge', $name);
c693f749 413 run_rbd_command($cmd, errmsg => "rbd snap purge '$volname' error");
c30470a3 414
42d07b9a 415 $cmd = &$rbd_cmd($scfg, $storeid, 'rm', $name);
c693f749 416 run_rbd_command($cmd, errmsg => "rbd rm '$volname' error");
0509010d
AD
417
418 return undef;
419}
420
421sub list_images {
422 my ($class, $storeid, $scfg, $vmid, $vollist, $cache) = @_;
423
e5427b00 424 $cache->{rbd} = rbd_ls($scfg, $storeid) if !$cache->{rbd};
1440604a 425 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
411476cd 426
0509010d
AD
427 my $res = [];
428
1440604a 429 if (my $dat = $cache->{rbd}->{$pool}) {
0509010d
AD
430 foreach my $image (keys %$dat) {
431
432 my $volname = $dat->{$image}->{name};
433
434 my $volid = "$storeid:$volname";
435
0509010d
AD
436 my $owner = $dat->{$volname}->{vmid};
437 if ($vollist) {
438 my $found = grep { $_ eq $volid } @$vollist;
439 next if !$found;
440 } else {
441 next if defined ($vmid) && ($owner ne $vmid);
442 }
443
444 my $info = $dat->{$volname};
445 $info->{volid} = $volid;
411476cd 446 $info->{format} = 'raw';
0509010d
AD
447
448 push @$res, $info;
449 }
450 }
451
411476cd 452 return $res;
0509010d
AD
453}
454
0509010d
AD
455sub status {
456 my ($class, $storeid, $scfg, $cache) = @_;
457
69589444
AD
458 my $cmd = &$rados_cmd($scfg, $storeid, 'df');
459
460 my $stats = {};
461
462 my $parser = sub {
463 my $line = shift;
464 if ($line =~ m/^\s+total\s(\S+)\s+(\d+)/) {
465 $stats->{$1} = $2;
466 }
467 };
468
469 eval {
c693f749 470 run_rbd_command($cmd, errmsg => "rados error", errfunc => sub {}, outfunc => $parser);
69589444
AD
471 };
472
473 my $total = $stats->{space} ? $stats->{space}*1024 : 0;
474 my $free = $stats->{avail} ? $stats->{avail}*1024 : 0;
475 my $used = $stats->{used} ? $stats->{used}*1024: 0;
0509010d 476 my $active = 1;
0509010d 477
411476cd 478 return ($total, $free, $used, $active);
0509010d
AD
479}
480
481sub activate_storage {
482 my ($class, $storeid, $scfg, $cache) = @_;
483 return 1;
484}
485
486sub deactivate_storage {
487 my ($class, $storeid, $scfg, $cache) = @_;
488 return 1;
489}
490
491sub activate_volume {
02e797b8 492 my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
9f20a8a6
AD
493
494 return 1 if !$scfg->{krbd};
495
496 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
4f6a99d8
DM
497 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
498
499 my $path = "/dev/rbd/$pool/$name";
02e797b8 500 $path .= '@'.$snapname if $snapname;
4f6a99d8 501 return if -b $path;
9f20a8a6 502
02e797b8 503 $name .= '@'.$snapname if $snapname;
9f20a8a6
AD
504 my $cmd = &$rbd_cmd($scfg, $storeid, 'map', $name);
505 run_rbd_command($cmd, errmsg => "can't mount rbd volume $name");
506
0509010d
AD
507 return 1;
508}
509
510sub deactivate_volume {
02e797b8 511 my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
9f20a8a6
AD
512
513 return 1 if !$scfg->{krbd};
514
515 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
516 my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
517
518 my $path = "/dev/rbd/$pool/$name";
02e797b8 519 $path .= '@'.$snapname if $snapname;
b50812f9
WL
520 return if ! -b $path;
521
9f20a8a6
AD
522 my $cmd = &$rbd_cmd($scfg, $storeid, 'unmap', $path);
523 run_rbd_command($cmd, errmsg => "can't unmount rbd volume $name");
524
0509010d
AD
525 return 1;
526}
527
0002d9cc
AD
528sub volume_size_info {
529 my ($class, $scfg, $storeid, $volname, $timeout) = @_;
530
81d1d017
AD
531 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
532 my ($size, undef) = rbd_volume_info($scfg, $storeid, $name);
62b98a65 533 return $size;
0002d9cc
AD
534}
535
e7a42a76
AD
536sub volume_resize {
537 my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
538
539 return 1 if $running;
540
478fc06c
AD
541 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
542
543 my $cmd = &$rbd_cmd($scfg, $storeid, 'resize', '--size', ($size/1024/1024), $name);
c693f749 544 run_rbd_command($cmd, errmsg => "rbd resize '$volname' error");
e7a42a76
AD
545 return undef;
546}
547
788dd8e1 548sub volume_snapshot {
f5640e7d 549 my ($class, $scfg, $storeid, $volname, $snap) = @_;
788dd8e1 550
9af33ed0
AD
551 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
552
553 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'create', '--snap', $snap, $name);
c693f749 554 run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
788dd8e1
AD
555 return undef;
556}
557
5a2b2e2f
AD
558sub volume_snapshot_rollback {
559 my ($class, $scfg, $storeid, $volname, $snap) = @_;
560
c6ce2cc8
AD
561 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
562
563 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rollback', '--snap', $snap, $name);
2362bc87 564 run_rbd_command($cmd, errmsg => "rbd snapshot $volname to '$snap' error");
5a2b2e2f
AD
565}
566
cce29bcd
AD
567sub volume_snapshot_delete {
568 my ($class, $scfg, $storeid, $volname, $snap, $running) = @_;
569
570 return 1 if $running;
571
c78cb110
AD
572 my ($vtype, $name, $vmid) = $class->parse_volname($volname);
573
f90a0a20
SP
574 my (undef, undef, undef, $protected) = rbd_volume_info($scfg, $storeid, $name, $snap);
575 if ($protected){
576 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'unprotect', $name, '--snap', $snap);
577 run_rbd_command($cmd, errmsg => "rbd unprotect $name snap '$snap' error");
578 }
579
c78cb110 580 my $cmd = &$rbd_cmd($scfg, $storeid, 'snap', 'rm', '--snap', $snap, $name);
c693f749
SP
581
582 run_rbd_command($cmd, errmsg => "rbd snapshot '$volname' error");
583
cce29bcd
AD
584 return undef;
585}
586
774f21b9
AD
587sub volume_has_feature {
588 my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_;
589
590 my $features = {
5649ccfe 591 snapshot => { current => 1, snap => 1},
44c3689a 592 clone => { base => 1, snap => 1},
5649ccfe
AD
593 template => { current => 1},
594 copy => { base => 1, current => 1, snap => 1},
774f21b9
AD
595 };
596
1e7ae581
AD
597 my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
598 $class->parse_volname($volname);
599
600 my $key = undef;
601 if($snapname){
2c5a7097 602 $key = 'snap';
1e7ae581
AD
603 }else{
604 $key = $isBase ? 'base' : 'current';
605 }
606 return 1 if $features->{$feature}->{$key};
774f21b9
AD
607
608 return undef;
609}
610
0509010d 6111;