use strict;
use warnings;
+
use PVE::ProcFSTools;
use Data::Dumper;
use Cwd qw(abs_path);
use Fcntl ':mode';
+use File::stat;
use JSON;
use PVE::Tools qw(extract_param run_command file_get_contents file_read_firstline dir_glob_regex dir_glob_foreach trim);
my $SGDISK = "/sbin/sgdisk";
my $PVS = "/sbin/pvs";
my $LVS = "/sbin/lvs";
-my $UDEVADM = "/bin/udevadm";
my $LSBLK = "/bin/lsblk";
sub verify_blockdev_path {
if (defined($type) && $type eq 'ata' && $line =~ m/^([ \d]{2}\d)\s+(\S+)\s+(\S{6})\s+(\d+)\s+(\d+)\s+(\S+)\s+(\S+)\s+(.*)$/) {
my $entry = {};
-
$entry->{name} = $2 if defined $2;
$entry->{flags} = $3 if defined $3;
# the +0 makes a number out of the strings
} elsif (defined($type) && $type eq 'text') {
$smartdata->{text} = '' if !defined $smartdata->{text};
$smartdata->{text} .= "$line\n";
- # extract wearout from nvme text, allow for decimal values
- if ($line =~ m/Percentage Used:.*(\d+(?:\.\d+)?)\%/i) {
+ # extract wearout from nvme/sas text, allow for decimal values
+ if ($line =~ m/Percentage Used(?: endurance indicator)?:\s*(\d+(?:\.\d+)?)\%/i) {
$smartdata->{wearout} = 100 - $1;
}
} elsif ($line =~ m/SMART Disabled/) {
return $smartdata;
}
-sub get_parttype_info() {
+sub get_lsblk_info() {
my $cmd = [$LSBLK, '--json', '-o', 'path,parttype'];
my $output = "";
my $res = {};
warn "$@\n" if $@;
my $list = $parsed->{blockdevices} // [];
- foreach my $dev (@$list) {
- next if !($dev->{parttype});
- my $type = $dev->{parttype};
- $res->{$type} = [] if !defined($res->{$type});
- push @{$res->{$type}}, $dev->{path};
- }
+ $res = { map {
+ $_->{path} => { parttype => $_->{parttype} }
+ } @{$list} };
return $res;
}
my $get_devices_by_partuuid = sub {
- my ($parttype_map, $uuids, $res) = @_;
+ my ($lsblk_info, $uuids, $res) = @_;
$res = {} if !defined($res);
- foreach my $uuid (sort keys %$uuids) {
- map { $res->{$_} = $uuids->{$uuid} } @{$parttype_map->{$uuid}};
+ foreach my $dev (sort keys %{$lsblk_info}) {
+ my $uuid = $lsblk_info->{$dev}->{parttype};
+ next if !defined($uuid) || !defined($uuids->{$uuid});
+ $res->{$dev} = $uuids->{$uuid};
}
return $res;
};
sub get_zfs_devices {
- my ($parttype_map) = @_;
+ my ($lsblk_info) = @_;
my $res = {};
return {} if ! -x $ZPOOL;
};
- $res = $get_devices_by_partuuid->($parttype_map, $uuids, $res);
+ $res = $get_devices_by_partuuid->($lsblk_info, $uuids, $res);
return $res;
}
sub get_lvm_devices {
- my ($parttype_map) = @_;
+ my ($lsblk_info) = @_;
my $res = {};
eval {
run_command([$PVS, '--noheadings', '--readonly', '-o', 'pv_name'], outfunc => sub{
"e6d6d379-f507-44c2-a23c-238f2a3df928" => 1,
};
- $res = $get_devices_by_partuuid->($parttype_map, $uuids, $res);
+ $res = $get_devices_by_partuuid->($lsblk_info, $uuids, $res);
return $res;
}
sub get_ceph_journals {
- my ($parttype_map) = @_;
+ my ($lsblk_info) = @_;
my $res = {};
my $uuids = {
'cafecafe-9b03-4f30-b4c6-b4b80ceff106' => 4, # block
};
- $res = $get_devices_by_partuuid->($parttype_map, $uuids, $res);
+ $res = $get_devices_by_partuuid->($lsblk_info, $uuids, $res);
return $res;
}
my $info = "";
my $data = {};
eval {
- run_command([$UDEVADM, 'info', '-p', $dev, '--query', 'all'], outfunc => sub {
+ run_command(['udevadm', 'info', '-p', $dev, '--query', 'all'], outfunc => sub {
my ($line) = @_;
$info .= "$line\n";
});
$data->{wwn} = $1;
}
+ if ($info =~ m/^E: DEVLINKS=(.+)$/m) {
+ my @devlinks = grep(m#^/dev/disk/by-id/(ata|scsi|nvme(?!-eui))#, split (/ /, $1));
+ $data->{by_id_link} = $devlinks[0] if defined($devlinks[0]);
+ }
+
return $data;
}
}
sub get_wear_leveling_info {
- my ($smartdata, $model) = @_;
+ my ($smartdata) = @_;
my $attributes = $smartdata->{attributes};
if (defined($smartdata->{wearout})) {
my $wearout;
- my $vendormap = {
- 'kingston' => 231,
- 'samsung' => 177,
- 'intel' => 233,
- 'sandisk' => 233,
- 'crucial' => 202,
- 'default' => 233,
- };
-
- # find target attr id
-
- my $attrid;
-
- foreach my $vendor (keys %$vendormap) {
- if ($model =~ m/$vendor/i) {
- $attrid = $vendormap->{$vendor};
- # found the attribute
- last;
+ # Common register names that represent percentage values of potential
+ # failure indicators used in drivedb.h of smartmontool's. Order matters,
+ # as some drives may have multiple definitions
+ my @wearoutregisters = (
+ "Media_Wearout_Indicator",
+ "SSD_Life_Left",
+ "Wear_Leveling_Count",
+ "Perc_Write\/Erase_Ct_BC",
+ "Perc_Rated_Life_Remain",
+ "Remaining_Lifetime_Perc",
+ "Percent_Lifetime_Remain",
+ "Lifetime_Left",
+ "PCT_Life_Remaining",
+ "Lifetime_Remaining",
+ "Percent_Life_Remaining",
+ "Percent_Lifetime_Used",
+ "Perc_Rated_Life_Used"
+ );
+
+ # Search for S.M.A.R.T. attributes for known register
+ foreach my $register (@wearoutregisters) {
+ last if defined $wearout;
+ foreach my $attr (@$attributes) {
+ next if $attr->{name} !~ m/$register/;
+ $wearout = $attr->{value};
+ last;
}
}
- if (!$attrid) {
- $attrid = $vendormap->{default};
- }
-
- foreach my $attr (@$attributes) {
- next if $attr->{id} != $attrid;
- $wearout = $attr->{value};
- last;
- }
-
return $wearout;
}
return 0;
}
+my sub is_ssdlike {
+ my ($type) = @_;
+ return $type eq 'ssd' || $type eq 'nvme';
+}
+
sub get_disks {
my ($disks, $nosmart) = @_;
my $disklist = {};
$mounted->{abs_path($mount->[0])} = $mount->[1];
};
- my $dev_is_mounted = sub {
- my ($dev) = @_;
- return $mounted->{$dev};
- };
-
- my $parttype_map = get_parttype_info();
+ my $lsblk_info = get_lsblk_info();
- my $journalhash = get_ceph_journals($parttype_map);
+ my $journalhash = get_ceph_journals($lsblk_info);
my $ceph_volume_infos = get_ceph_volume_infos();
- my $zfshash = get_zfs_devices($parttype_map);
+ my $zfshash = get_zfs_devices($lsblk_info);
- my $lvmhash = get_lvm_devices($parttype_map);
+ my $lvmhash = get_lvm_devices($lsblk_info);
my $disk_regex = ".*";
if (defined($disks)) {
die "disks is not a string or array reference\n";
}
# we get cciss/c0d0 but need cciss!c0d0
- map { s|cciss/|cciss!| } @$disks;
+ $_ =~ s|cciss/|cciss!| for @$disks;
$disk_regex = "(?:" . join('|', @$disks) . ")";
}
if ($sysdata->{rotational} == 0) {
$type = 'ssd';
+ $type = 'nvme' if $dev =~ m/^nvme\d+n\d+$/;
$data->{rpm} = 0;
} elsif ($sysdata->{rotational} == 1) {
if ($data->{rpm} != -1) {
if (!$nosmart) {
eval {
- my $smartdata = get_smart_data($devpath, ($type ne 'ssd'));
+ my $smartdata = get_smart_data($devpath, !is_ssdlike($type));
$health = $smartdata->{health} if $smartdata->{health};
- if ($type eq 'ssd') {
+ if (is_ssdlike($type)) {
# if we have an ssd we try to get the wearout indicator
- my $wearval = get_wear_leveling_info($smartdata, $data->{model} || $sysdata->{model});
+ my $wearval = get_wear_leveling_info($smartdata);
$wearout = $wearval if defined($wearval);
}
};
$used = 'LVM' if $lvmhash->{$devpath};
- $used = 'mounted' if &$dev_is_mounted($devpath);
+ $used = 'mounted' if $mounted->{$devpath};
$used = 'ZFS' if $zfshash->{$devpath};
wearout => $wearout,
};
+ my $by_id_link = $data->{by_id_link};
+ $disklist->{$dev}->{by_id_link} = $by_id_link if defined($by_id_link);
+
my $osdid = -1;
my $bluestore = 0;
my $osdencrypted = 0;
$found_partitions = 1;
- if (my $mp = &$dev_is_mounted("$partpath/$part")) {
+ if (my $mp = $mounted->{"$partpath/$part"}) {
$found_mountpoints = 1;
if ($mp =~ m|^/var/lib/ceph/osd/ceph-(\d+)$|) {
$osdid = $1;
sub get_partnum {
my ($part_path) = @_;
- my ($mode, $rdev) = (stat($part_path))[2,6];
+ my $st = stat($part_path);
- next if !$mode || !S_ISBLK($mode) || !$rdev;
- my $major = PVE::Tools::dev_t_major($rdev);
- my $minor = PVE::Tools::dev_t_minor($rdev);
+ next if !$st->mode || !S_ISBLK($st->mode) || !$st->rdev;
+ my $major = PVE::Tools::dev_t_major($st->rdev);
+ my $minor = PVE::Tools::dev_t_minor($st->rdev);
my $partnum_path = "/sys/dev/block/$major:$minor/";
my $partnum;
sub get_blockdev {
my ($part_path) = @_;
- my $dev = $1 if $part_path =~ m|^/dev/(.*)$|;
- my $link = readlink "/sys/class/block/$dev";
- my $block_dev = $1 if $link =~ m|([^/]*)/$dev$|;
+ my ($dev, $block_dev);
+ if ($part_path =~ m|^/dev/(.*)$|) {
+ $dev = $1;
+ my $link = readlink "/sys/class/block/$dev";
+ $block_dev = $1 if $link =~ m|([^/]*)/$dev$|;
+ }
die "Can't parse parent device\n" if !defined($block_dev);
die "No valid block device\n" if index($dev, $block_dev) == -1;