pbs: prune: avoid getting all snapshots for group assembly if fixed anyway

[pve-storage.git] / PVE / Storage / PBSPlugin.pm

diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
index 633c399ca1dcb79a7156ea8274d545c45b4b06dd..4320974b6b9c03c6ce4b722fb6b7d06550c7f359 100644 (file)
--- a/PVE/Storage/PBSPlugin.pm
+++ b/PVE/Storage/PBSPlugin.pm
@@ -403,19 +403,25 @@ sub prune_backups {
 
     $logfunc //= sub { print "$_[1]\n" };
 
-    my $backups = eval { $class->list_volumes($storeid, $scfg, $vmid, ['backup']) };
-    die "failed to get list of all backups to prune - $@" if $@;
-
     $type = 'vm' if defined($type) && $type eq 'qemu';
     $type = 'ct' if defined($type) && $type eq 'lxc';
 
     my $backup_groups = {};
-    foreach my $backup (@{$backups}) {
-       (my $backup_type = $backup->{format}) =~ s/^pbs-//;
-       next if defined($type) && $backup_type ne $type;
 
-       my $backup_group = "$backup_type/$backup->{vmid}";
-       $backup_groups->{$backup_group} = 1;
+    if (defined($vmid) && defined($type)) {
+       # no need to get the list of volumes, we only got a single backup group anyway
+       $backup_groups->{"$type/$vmid"} = 1;
+    } else {
+       my $backups = eval { $class->list_volumes($storeid, $scfg, $vmid, ['backup']) };
+       die "failed to get list of all backups to prune - $@" if $@;
+
+       foreach my $backup (@{$backups}) {
+           (my $backup_type = $backup->{format}) =~ s/^pbs-//;
+           next if defined($type) && $backup_type ne $type;
+
+           my $backup_group = "$backup_type/$backup->{vmid}";
+           $backup_groups->{$backup_group} = 1;
+       }
     }
 
     my @param;