]> git.proxmox.com Git - qemu-server.git/commit
backup: prepare: fix format detection for disks without storage ID
authorFiona Ebner <f.ebner@proxmox.com>
Mon, 27 Mar 2023 09:01:05 +0000 (11:01 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 27 Mar 2023 09:38:36 +0000 (11:38 +0200)
commit670f947ee86a9046fe2a5cdc74c7aa18e99a4cba
tree81cae99af1293bb31baf85534f40469a5fda0035
parent021e9cdf7d9acbefa347f9735d9a33f5ffac26cf
backup: prepare: fix format detection for disks without storage ID

which is the case for passed-through disks. The qemu_img_format()
function cannot correctly handle those, and it's not safe to assume
they are raw (it's most likely, but not guaranteed), so just use the
storage method for the format like it was done before commit
efa3aa24 ("avoid list context for volume_size_info calls"). This will
use 'qemu-img info' to get the actual format.

Reported in the community forum:
https://forum.proxmox.com/threads/124794/
https://forum.proxmox.com/threads/124823/
https://forum.proxmox.com/threads/124818/

Fixes: efa3aa24 ("avoid list context for volume_size_info calls")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
PVE/VZDump/QemuServer.pm