]> git.proxmox.com Git - qemu.git/commit - target-i386/cpu.c
target-i386: Don't set any KVM flag by default if KVM is disabled
authorEduardo Habkost <ehabkost@redhat.com>
Thu, 17 Jan 2013 20:59:28 +0000 (18:59 -0200)
committerAndreas Färber <afaerber@suse.de>
Sun, 27 Jan 2013 13:34:26 +0000 (14:34 +0100)
commitaa87d45855c7b255b451622a84a3e5b9b4393425
treed89f939e239ea6062e9900b263b9974be8e006f5
parentd61a23ba77deefd88fd2457c2dba7d5bf13f5f5b
target-i386: Don't set any KVM flag by default if KVM is disabled

This is a cleanup that tries to solve two small issues:

 - We don't need a separate kvm_pv_eoi_features variable just to keep a
   constant calculated at compile-time, and this style would require
   adding a separate variable (that's declared twice because of the
   CONFIG_KVM ifdef) for each feature that's going to be
   enabled/disabled by machine-type compat code.
 - The pc-1.3 code is setting the kvm_pv_eoi flag on cpuid_kvm_features
   even when KVM is disabled at runtime. This small inconsistency in
   the cpuid_kvm_features field isn't a problem today because
   cpuid_kvm_features is ignored by the TCG code, but it may cause
   unexpected problems later when refactoring the CPUID handling code.

This patch eliminates the kvm_pv_eoi_features variable and simply uses
kvm_enabled() inside the enable_kvm_pv_eoi() compat function, so it
enables kvm_pv_eoi only if KVM is enabled. I believe this makes the
behavior of enable_kvm_pv_eoi() clearer and easier to understand.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Gleb Natapov <gleb@redhat.com>
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
target-i386/cpu.c