]> git.proxmox.com Git - qemu.git/commit
tests/cris: Fix some errors and potential crashes
authorStefan Weil <weil@mail.berlios.de>
Sun, 3 Apr 2011 19:36:36 +0000 (21:36 +0200)
committerEdgar E. Iglesias <edgar.iglesias@gmail.com>
Sun, 3 Apr 2011 19:58:38 +0000 (21:58 +0200)
commit2917dce477f91e933052f5555b4c6be961ff624e
treee37790dd76f7d53761522dea178296251db90501
parent9bcfc7daabb138b0fe3d64d74892942d482e5bbd
tests/cris: Fix some errors and potential crashes

These errors were reported by cppcheck:

tests/cris/check_openpf1.c:30: error:
Mismatching allocation and deallocation: f

tests/cris/check_openpf2.c:13: error:
Mismatching allocation and deallocation: f

tests/cris/check_stat3.c:16: error:
Buffer overrun possible for long cmd-line args

tests/cris/check_stat4.c:18: error:
Buffer overrun possible for long cmd-line args

The first two are obvious coding errors (fopen needs fclose, not close).

The last two may seem less important (nobody will start test code
with an argument of more than 1022 characters which raises a buffer
overrun). Fixing them nevertheless helps with static code checks
like those done by cppcheck.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
tests/cris/check_openpf1.c
tests/cris/check_openpf2.c
tests/cris/check_stat3.c
tests/cris/check_stat4.c