]> git.proxmox.com Git - qemu.git/commit
qdev-properties-system.c: Allow vlan or netdev for -device, not both
authorVlad Yasevich <vyasevic@redhat.com>
Fri, 8 Nov 2013 02:13:09 +0000 (21:13 -0500)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 22 Nov 2013 08:47:00 +0000 (09:47 +0100)
commit30c367ed446b6ea53245589a5cf373578ac075d7
treeec3803f73d5d69c6f888ad63f65b8f34514d939e
parent607bb022f2a44797cbf40e85e84da4134e2f0e01
qdev-properties-system.c: Allow vlan or netdev for -device, not both

It is currently possible to specify things like:
-device e1000,netdev=foo,vlan=1
With this usage, whichever argument was specified last (vlan or netdev)
overwrites what was previousely set and results in a non-working
configuration.  Even worse, when used with multiqueue devices,
it causes a segmentation fault on exit in qemu_free_net_client.

That patch treates the above command line options as invalid and
generates an error at start-up.

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/core/qdev-properties-system.c