]> git.proxmox.com Git - qemu.git/commit
virtio: properly validate address before accessing config
authorJason Wang <jasowang@redhat.com>
Tue, 7 May 2013 05:42:49 +0000 (13:42 +0800)
committerAnthony Liguori <aliguori@us.ibm.com>
Wed, 8 May 2013 20:54:21 +0000 (15:54 -0500)
commit5f5a1318653c08e435cfa52f60b6a712815b659d
treef0225933089d17dc522c51ab17b71e24c619c4cb
parent62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
virtio: properly validate address before accessing config

There are several several issues in the current checking:

- The check was based on the minus of unsigned values which can overflow
- It was done after .{set|get}_config() which can lead crash when config_len
  is zero since vdev->config is NULL

Fix this by:

- Validate the address in virtio_pci_config_{read|write}() before
  .{set|get}_config
- Use addition instead minus to do the validation

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Petr Matousek <pmatouse@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Petr Matousek <pmatouse@redhat.com>
Message-id: 1367905369-10765-1-git-send-email-jasowang@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/virtio/virtio.c