]> git.proxmox.com Git - qemu.git/commit
scsi-generic: fix sign extension of READ CAPACITY(10) data
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 21 May 2013 12:08:53 +0000 (14:08 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 18 Jun 2013 17:56:37 +0000 (12:56 -0500)
commit9c4f5dd03a93f0049091c9049df94abd60ca10fc
treedd14fa7d247a2608badc060a6ed9673c59aad2d5
parent3abd71cd98deff0209fdacd2bb7583428914075d
scsi-generic: fix sign extension of READ CAPACITY(10) data

Issuing the READ CAPACITY(10) command in the guest will cause QEMU
to update its knowledge of the maximum accessible LBA in the disk.
The recorded maximum LBA will be wrong if the disk is bigger than
1TB, because ldl_be_p returns a signed int.

When this is fixed, a latent bug will be unmasked.  If the READ
CAPACITY(10) command reported an overflow (0xFFFFFFFF), we must
not overwrite the previously-known maximum accessible LBA, or the guest
will fail to access the disk above the first 2TB.

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 53254e569f8e07501f3e0098bd57d2b780e52faa)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/scsi/scsi-generic.c