]> git.proxmox.com Git - qemu.git/commit
block: Handle multiwrite errors only when all requests have completed
authorKevin Wolf <kwolf@redhat.com>
Thu, 1 Jul 2010 14:08:51 +0000 (16:08 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 14 Jul 2010 11:09:24 +0000 (13:09 +0200)
commitbb44e0bbcea21e50aaed1bd54d0aa53c46cecbf1
tree068046d111e7da95afce2e26dc80b67efbf525a9
parent191d44fc4361932c3ae647eee343e150fb8b6e34
block: Handle multiwrite errors only when all requests have completed

Don't try to be clever by freeing all temporary data and calling all callbacks
when the return value (an error) is certain. Doing so has at least two
important problems:

* The temporary data that is freed (qiov, possibly zero buffer) is still used
  by the requests that have not yet completed.
* Calling the callbacks for all requests in the multiwrite means for the caller
  that it may free buffers etc. which are still in use.

Just remember the error value and do the cleanup when all requests have
completed.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit de189a1b4a471d37a2909e97646654fc9751b52f)
block.c