]> git.proxmox.com Git - qemu.git/commit
kvm: Fix uninitialized cpuid_data
authorStefan Weil <sw@weilnetz.de>
Wed, 6 Nov 2013 21:35:27 +0000 (22:35 +0100)
committerGleb Natapov <gleb@redhat.com>
Thu, 7 Nov 2013 11:14:56 +0000 (13:14 +0200)
commitef4cbe14342c1f63b3c754e306218f004f4e26c4
treea8a3b56c2d9308a1c2ecdcec7bee4da5c21ce174
parent3a902babf1d7b5ef1ffa8bc95be271fe1270c2f6
kvm: Fix uninitialized cpuid_data

This error was reported by valgrind when running qemu-system-x86_64
with kvm:

==975== Conditional jump or move depends on uninitialised value(s)
==975==    at 0x521C38: cpuid_find_entry (kvm.c:176)
==975==    by 0x5235BA: kvm_arch_init_vcpu (kvm.c:686)
==975==    by 0x4D5175: kvm_init_vcpu (kvm-all.c:267)
==975==    by 0x45035B: qemu_kvm_cpu_thread_fn (cpus.c:858)
==975==    by 0xD361E0D: start_thread (pthread_create.c:311)
==975==    by 0xD65E9EC: clone (clone.S:113)
==975==  Uninitialised value was created by a stack allocation
==975==    at 0x5226E4: kvm_arch_init_vcpu (kvm.c:446)

Instead of adding more memset calls for parts of cpuid_data, the existing
calls were removed and cpuid_data is now initialized completely in one
call.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
target-i386/kvm.c