]> git.proxmox.com Git - qemu.git/commit
block: fix sector comparism in multiwrite_req_compare
authorChristoph Hellwig <hch@lst.de>
Wed, 19 May 2010 18:53:10 +0000 (20:53 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 21 May 2010 09:49:19 +0000 (11:49 +0200)
commit77be4366baface6613cfc312ba281f8e5860997c
tree9c2666894e96ae3deec82f4232c16ffbc5dfe4fc
parent618fbb84299780af96e3d4c4b6f2148656fe3708
block: fix sector comparism in multiwrite_req_compare

The difference between the start sectors of two requests can be larger
than the size of the "int" type, which can lead to a not correctly
sorted multiwrite array and thus spurious I/O errors and filesystem
corruption due to incorrect request merges.

So instead of doing the cute sector arithmetics trick spell out the
exact comparisms.

Spotted by Kevin Wolf based on a testcase from Michael Tokarev.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c