]>
Commit | Line | Data |
---|---|---|
75b07eca FG |
1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
2 | From: WHR <msl0000023508@gmail.com> | |
3 | Date: Sun, 14 Jan 2018 23:57:54 +0300 | |
4 | Subject: [PATCH] OpenZFS 8966 - Source file zfs_acl.c, function | |
5 | zfs_aclset_common contains a use after end of the lifetime of a local | |
6 | variable | |
7 | MIME-Version: 1.0 | |
8 | Content-Type: text/plain; charset=UTF-8 | |
9 | Content-Transfer-Encoding: 8bit | |
10 | ||
11 | Authored by: WHR <msl0000023508@gmail.com> | |
12 | Reviewed by: Matt Ahrens <mahrens@delphix.com> | |
13 | Reviewed by: Andriy Gapon <avg@FreeBSD.org> | |
14 | Reviewed by: George Melikov <mail@gmelikov.ru> | |
15 | Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> | |
16 | Approved by: Richard Lowe <richlowe@richlowe.net> | |
17 | Ported-by: Giuseppe Di Natale <dinatale2@llnl.gov> | |
18 | ||
19 | OpenZFS-issue: https://www.illumos.org/issues/8966 | |
20 | OpenZFS-commit: https://github.com/openzfs/openzfs/commit/c95549fcdc | |
21 | Closes #7141 | |
22 | ||
23 | (cherry picked from commit a196b3bc3dcc14bda32b2fbed40d5e436319aca6) | |
24 | Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> | |
25 | --- | |
26 | module/zfs/zfs_acl.c | 2 +- | |
27 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
28 | ||
29 | diff --git a/module/zfs/zfs_acl.c b/module/zfs/zfs_acl.c | |
30 | index 7ddedeaaf..1fcfca0c7 100644 | |
31 | --- a/module/zfs/zfs_acl.c | |
32 | +++ b/module/zfs/zfs_acl.c | |
33 | @@ -1323,6 +1323,7 @@ zfs_aclset_common(znode_t *zp, zfs_acl_t *aclp, cred_t *cr, dmu_tx_t *tx) | |
34 | sa_bulk_attr_t bulk[5]; | |
35 | uint64_t ctime[2]; | |
36 | int count = 0; | |
37 | + zfs_acl_phys_t acl_phys; | |
38 | ||
39 | mode = zp->z_mode; | |
40 | ||
41 | @@ -1369,7 +1370,6 @@ zfs_aclset_common(znode_t *zp, zfs_acl_t *aclp, cred_t *cr, dmu_tx_t *tx) | |
42 | } else { /* Painful legacy way */ | |
43 | zfs_acl_node_t *aclnode; | |
44 | uint64_t off = 0; | |
45 | - zfs_acl_phys_t acl_phys; | |
46 | uint64_t aoid; | |
47 | ||
48 | if ((error = sa_lookup(zp->z_sa_hdl, SA_ZPL_ZNODE_ACL(zfsvfs), | |
49 | -- | |
50 | 2.14.2 | |
51 |