]>
Commit | Line | Data |
---|---|---|
94b18763 | 1 | import os |
d2e6a577 | 2 | import pytest |
92f5a8d4 | 3 | from mock.mock import patch |
d2e6a577 | 4 | from ceph_volume import process, exceptions |
3efd9988 | 5 | from ceph_volume.api import lvm as api |
d2e6a577 FG |
6 | |
7 | ||
8 | class TestParseTags(object): | |
9 | ||
10 | def test_no_tags_means_empty_dict(self): | |
11 | result = api.parse_tags('') | |
12 | assert result == {} | |
13 | ||
14 | def test_single_tag_gets_parsed(self): | |
15 | result = api.parse_tags('ceph.osd_something=1') | |
16 | assert result == {'ceph.osd_something': '1'} | |
17 | ||
b32b8144 FG |
18 | def test_non_ceph_tags_are_skipped(self): |
19 | result = api.parse_tags('foo') | |
20 | assert result == {} | |
21 | ||
22 | def test_mixed_non_ceph_tags(self): | |
23 | result = api.parse_tags('foo,ceph.bar=1') | |
24 | assert result == {'ceph.bar': '1'} | |
25 | ||
d2e6a577 FG |
26 | def test_multiple_csv_expands_in_dict(self): |
27 | result = api.parse_tags('ceph.osd_something=1,ceph.foo=2,ceph.fsid=0000') | |
28 | # assert them piecemeal to avoid the un-ordered dict nature | |
29 | assert result['ceph.osd_something'] == '1' | |
30 | assert result['ceph.foo'] == '2' | |
31 | assert result['ceph.fsid'] == '0000' | |
32 | ||
33 | ||
92f5a8d4 TL |
34 | class TestVolume(object): |
35 | ||
36 | def test_is_ceph_device(self): | |
37 | lv_tags = "ceph.type=data,ceph.osd_id=0" | |
38 | osd = api.Volume(lv_name='osd/volume', lv_tags=lv_tags) | |
39 | assert api.is_ceph_device(osd) | |
40 | ||
41 | @pytest.mark.parametrize('dev',[ | |
42 | '/dev/sdb', | |
43 | api.VolumeGroup(vg_name='foo'), | |
f6b5b4d7 TL |
44 | api.Volume(lv_name='vg/no_osd', lv_tags='', lv_path='lv/path'), |
45 | api.Volume(lv_name='vg/no_osd', lv_tags='ceph.osd_id=null', lv_path='lv/path'), | |
92f5a8d4 TL |
46 | None, |
47 | ]) | |
48 | def test_is_not_ceph_device(self, dev): | |
49 | assert not api.is_ceph_device(dev) | |
50 | ||
9f95a23c TL |
51 | def test_no_empty_lv_name(self): |
52 | with pytest.raises(ValueError): | |
53 | api.Volume(lv_name='', lv_tags='') | |
54 | ||
92f5a8d4 | 55 | |
9f95a23c TL |
56 | class TestVolumeGroup(object): |
57 | ||
58 | def test_volume_group_no_empty_name(self): | |
59 | with pytest.raises(ValueError): | |
60 | api.VolumeGroup(vg_name='') | |
61 | ||
62 | ||
1adf2230 AA |
63 | class TestVolumeGroupFree(object): |
64 | ||
1adf2230 | 65 | def test_integer_gets_produced(self): |
92f5a8d4 TL |
66 | vg = api.VolumeGroup(vg_name='nosize', vg_free_count=100, vg_extent_size=4194304) |
67 | assert vg.free == 100 * 4194304 | |
1adf2230 AA |
68 | |
69 | ||
70 | class TestCreateLVs(object): | |
71 | ||
05a536ef | 72 | def setup_method(self): |
92f5a8d4 TL |
73 | self.vg = api.VolumeGroup(vg_name='ceph', |
74 | vg_extent_size=1073741824, | |
75 | vg_extent_count=99999999, | |
76 | vg_free_count=999) | |
77 | ||
1adf2230 AA |
78 | def test_creates_correct_lv_number_from_parts(self, monkeypatch): |
79 | monkeypatch.setattr('ceph_volume.api.lvm.create_lv', lambda *a, **kw: (a, kw)) | |
92f5a8d4 | 80 | lvs = api.create_lvs(self.vg, parts=4) |
1adf2230 AA |
81 | assert len(lvs) == 4 |
82 | ||
83 | def test_suffixes_the_size_arg(self, monkeypatch): | |
84 | monkeypatch.setattr('ceph_volume.api.lvm.create_lv', lambda *a, **kw: (a, kw)) | |
92f5a8d4 | 85 | lvs = api.create_lvs(self.vg, parts=4) |
1adf2230 AA |
86 | assert lvs[0][1]['extents'] == 249 |
87 | ||
88 | def test_only_uses_free_size(self, monkeypatch): | |
89 | monkeypatch.setattr('ceph_volume.api.lvm.create_lv', lambda *a, **kw: (a, kw)) | |
92f5a8d4 TL |
90 | vg = api.VolumeGroup(vg_name='ceph', |
91 | vg_extent_size=1073741824, | |
92 | vg_extent_count=99999999, | |
93 | vg_free_count=1000) | |
1adf2230 AA |
94 | lvs = api.create_lvs(vg, parts=4) |
95 | assert lvs[0][1]['extents'] == 250 | |
96 | ||
97 | def test_null_tags_are_set_by_default(self, monkeypatch): | |
98 | monkeypatch.setattr('ceph_volume.api.lvm.create_lv', lambda *a, **kw: (a, kw)) | |
92f5a8d4 | 99 | kwargs = api.create_lvs(self.vg, parts=4)[0][1] |
1adf2230 AA |
100 | assert list(kwargs['tags'].values()) == ['null', 'null', 'null', 'null'] |
101 | ||
102 | def test_fallback_to_one_part(self, monkeypatch): | |
103 | monkeypatch.setattr('ceph_volume.api.lvm.create_lv', lambda *a, **kw: (a, kw)) | |
92f5a8d4 | 104 | lvs = api.create_lvs(self.vg) |
1adf2230 AA |
105 | assert len(lvs) == 1 |
106 | ||
107 | ||
108 | class TestVolumeGroupSizing(object): | |
109 | ||
05a536ef | 110 | def setup_method(self): |
92f5a8d4 TL |
111 | self.vg = api.VolumeGroup(vg_name='ceph', |
112 | vg_extent_size=1073741824, | |
113 | vg_free_count=1024) | |
1adf2230 AA |
114 | |
115 | def test_parts_and_size_errors(self): | |
116 | with pytest.raises(ValueError) as error: | |
117 | self.vg.sizing(parts=4, size=10) | |
81eedcae | 118 | assert "Cannot process sizing" in str(error.value) |
1adf2230 AA |
119 | |
120 | def test_zero_parts_produces_100_percent(self): | |
121 | result = self.vg.sizing(parts=0) | |
122 | assert result['percentages'] == 100 | |
123 | ||
124 | def test_two_parts_produces_50_percent(self): | |
125 | result = self.vg.sizing(parts=2) | |
126 | assert result['percentages'] == 50 | |
127 | ||
128 | def test_two_parts_produces_half_size(self): | |
129 | result = self.vg.sizing(parts=2) | |
130 | assert result['sizes'] == 512 | |
131 | ||
132 | def test_half_size_produces_round_sizes(self): | |
133 | result = self.vg.sizing(size=512) | |
134 | assert result['sizes'] == 512 | |
135 | assert result['percentages'] == 50 | |
136 | assert result['parts'] == 2 | |
137 | ||
138 | def test_bit_more_than_half_size_allocates_full_size(self): | |
139 | # 513 can't allocate more than 1, so it just fallsback to using the | |
140 | # whole device | |
141 | result = self.vg.sizing(size=513) | |
142 | assert result['sizes'] == 1024 | |
143 | assert result['percentages'] == 100 | |
144 | assert result['parts'] == 1 | |
145 | ||
146 | def test_extents_are_halfed_rounded_down(self): | |
147 | result = self.vg.sizing(size=512) | |
92f5a8d4 | 148 | assert result['extents'] == 512 |
1adf2230 AA |
149 | |
150 | def test_bit_less_size_rounds_down(self): | |
151 | result = self.vg.sizing(size=129) | |
152 | assert result['sizes'] == 146 | |
153 | assert result['percentages'] == 14 | |
154 | assert result['parts'] == 7 | |
155 | ||
156 | def test_unable_to_allocate_past_free_size(self): | |
157 | with pytest.raises(exceptions.SizeAllocationError): | |
158 | self.vg.sizing(size=2048) | |
159 | ||
160 | ||
3efd9988 FG |
161 | class TestRemoveLV(object): |
162 | ||
163 | def test_removes_lv(self, monkeypatch): | |
164 | def mock_call(cmd, **kw): | |
165 | return ('', '', 0) | |
166 | monkeypatch.setattr(process, 'call', mock_call) | |
167 | assert api.remove_lv("vg/lv") | |
168 | ||
91327a77 AA |
169 | def test_removes_lv_object(self, fake_call): |
170 | foo_volume = api.Volume(lv_name='foo', lv_path='/path', vg_name='foo_group', lv_tags='') | |
171 | api.remove_lv(foo_volume) | |
172 | # last argument from the list passed to process.call | |
173 | assert fake_call.calls[0]['args'][0][-1] == '/path' | |
174 | ||
3efd9988 FG |
175 | def test_fails_to_remove_lv(self, monkeypatch): |
176 | def mock_call(cmd, **kw): | |
177 | return ('', '', 1) | |
178 | monkeypatch.setattr(process, 'call', mock_call) | |
179 | with pytest.raises(RuntimeError): | |
180 | api.remove_lv("vg/lv") | |
181 | ||
182 | ||
d2e6a577 FG |
183 | class TestCreateLV(object): |
184 | ||
05a536ef | 185 | def setup_method(self): |
d2e6a577 | 186 | self.foo_volume = api.Volume(lv_name='foo', lv_path='/path', vg_name='foo_group', lv_tags='') |
92f5a8d4 | 187 | self.foo_group = api.VolumeGroup(vg_name='foo_group', |
cd265ab1 TL |
188 | vg_extent_size="4194304", |
189 | vg_extent_count="100", | |
190 | vg_free_count="100") | |
92f5a8d4 TL |
191 | |
192 | @patch('ceph_volume.api.lvm.process.run') | |
193 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
194 | @patch('ceph_volume.api.lvm.get_single_lv') |
195 | def test_uses_size(self, m_get_single_lv, m_call, m_run, monkeypatch): | |
196 | m_get_single_lv.return_value = self.foo_volume | |
cd265ab1 | 197 | api.create_lv('foo', 0, vg=self.foo_group, size=419430400, tags={'ceph.type': 'data'}) |
20effc67 TL |
198 | expected = (['lvcreate', '--yes', '-l', '100', '-n', 'foo-0', 'foo_group']) |
199 | m_run.assert_called_with(expected, run_on_host=True) | |
92f5a8d4 | 200 | |
cd265ab1 TL |
201 | @patch('ceph_volume.api.lvm.process.run') |
202 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
203 | @patch('ceph_volume.api.lvm.get_single_lv') |
204 | def test_uses_size_adjust_if_1percent_over(self, m_get_single_lv, m_call, m_run, monkeypatch): | |
cd265ab1 TL |
205 | foo_volume = api.Volume(lv_name='foo', lv_path='/path', vg_name='foo_group', lv_tags='') |
206 | foo_group = api.VolumeGroup(vg_name='foo_group', | |
207 | vg_extent_size="4194304", | |
208 | vg_extent_count="1000", | |
209 | vg_free_count="1000") | |
a4b75251 | 210 | m_get_single_lv.return_value = foo_volume |
cd265ab1 TL |
211 | # 423624704 should be just under 1% off of the available size 419430400 |
212 | api.create_lv('foo', 0, vg=foo_group, size=4232052736, tags={'ceph.type': 'data'}) | |
213 | expected = ['lvcreate', '--yes', '-l', '1000', '-n', 'foo-0', 'foo_group'] | |
20effc67 | 214 | m_run.assert_called_with(expected, run_on_host=True) |
cd265ab1 TL |
215 | |
216 | @patch('ceph_volume.api.lvm.process.run') | |
217 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
218 | @patch('ceph_volume.api.lvm.get_single_lv') |
219 | def test_uses_size_too_large(self, m_get_single_lv, m_call, m_run, monkeypatch): | |
220 | m_get_single_lv.return_value = self.foo_volume | |
cd265ab1 TL |
221 | with pytest.raises(RuntimeError): |
222 | api.create_lv('foo', 0, vg=self.foo_group, size=5368709120, tags={'ceph.type': 'data'}) | |
223 | ||
92f5a8d4 TL |
224 | @patch('ceph_volume.api.lvm.process.run') |
225 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
226 | @patch('ceph_volume.api.lvm.get_single_lv') |
227 | def test_uses_extents(self, m_get_single_lv, m_call, m_run, monkeypatch): | |
228 | m_get_single_lv.return_value = self.foo_volume | |
92f5a8d4 TL |
229 | api.create_lv('foo', 0, vg=self.foo_group, extents='50', tags={'ceph.type': 'data'}) |
230 | expected = ['lvcreate', '--yes', '-l', '50', '-n', 'foo-0', 'foo_group'] | |
20effc67 | 231 | m_run.assert_called_with(expected, run_on_host=True) |
92f5a8d4 TL |
232 | |
233 | @pytest.mark.parametrize("test_input,expected", | |
234 | [(2, 50), | |
235 | (3, 33),]) | |
236 | @patch('ceph_volume.api.lvm.process.run') | |
237 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
238 | @patch('ceph_volume.api.lvm.get_single_lv') |
239 | def test_uses_slots(self, m_get_single_lv, m_call, m_run, monkeypatch, test_input, expected): | |
240 | m_get_single_lv.return_value = self.foo_volume | |
92f5a8d4 TL |
241 | api.create_lv('foo', 0, vg=self.foo_group, slots=test_input, tags={'ceph.type': 'data'}) |
242 | expected = ['lvcreate', '--yes', '-l', str(expected), '-n', 'foo-0', 'foo_group'] | |
20effc67 | 243 | m_run.assert_called_with(expected, run_on_host=True) |
92f5a8d4 TL |
244 | |
245 | @patch('ceph_volume.api.lvm.process.run') | |
246 | @patch('ceph_volume.api.lvm.process.call') | |
a4b75251 TL |
247 | @patch('ceph_volume.api.lvm.get_single_lv') |
248 | def test_uses_all(self, m_get_single_lv, m_call, m_run, monkeypatch): | |
249 | m_get_single_lv.return_value = self.foo_volume | |
92f5a8d4 TL |
250 | api.create_lv('foo', 0, vg=self.foo_group, tags={'ceph.type': 'data'}) |
251 | expected = ['lvcreate', '--yes', '-l', '100%FREE', '-n', 'foo-0', 'foo_group'] | |
20effc67 | 252 | m_run.assert_called_with(expected, run_on_host=True) |
92f5a8d4 TL |
253 | |
254 | @patch('ceph_volume.api.lvm.process.run') | |
255 | @patch('ceph_volume.api.lvm.process.call') | |
256 | @patch('ceph_volume.api.lvm.Volume.set_tags') | |
a4b75251 TL |
257 | @patch('ceph_volume.api.lvm.get_single_lv') |
258 | def test_calls_to_set_tags_default(self, m_get_single_lv, m_set_tags, m_call, m_run, monkeypatch): | |
259 | m_get_single_lv.return_value = self.foo_volume | |
92f5a8d4 TL |
260 | api.create_lv('foo', 0, vg=self.foo_group) |
261 | tags = { | |
262 | "ceph.osd_id": "null", | |
263 | "ceph.type": "null", | |
264 | "ceph.cluster_fsid": "null", | |
265 | "ceph.osd_fsid": "null", | |
266 | } | |
267 | m_set_tags.assert_called_with(tags) | |
268 | ||
269 | @patch('ceph_volume.api.lvm.process.run') | |
270 | @patch('ceph_volume.api.lvm.process.call') | |
271 | @patch('ceph_volume.api.lvm.Volume.set_tags') | |
a4b75251 TL |
272 | @patch('ceph_volume.api.lvm.get_single_lv') |
273 | def test_calls_to_set_tags_arg(self, m_get_single_lv, m_set_tags, m_call, m_run, monkeypatch): | |
274 | m_get_single_lv.return_value = self.foo_volume | |
92f5a8d4 TL |
275 | api.create_lv('foo', 0, vg=self.foo_group, tags={'ceph.type': 'data'}) |
276 | tags = { | |
277 | "ceph.type": "data", | |
278 | "ceph.data_device": "/path" | |
279 | } | |
280 | m_set_tags.assert_called_with(tags) | |
281 | ||
282 | @patch('ceph_volume.api.lvm.process.run') | |
283 | @patch('ceph_volume.api.lvm.process.call') | |
284 | @patch('ceph_volume.api.lvm.get_device_vgs') | |
285 | @patch('ceph_volume.api.lvm.create_vg') | |
a4b75251 TL |
286 | @patch('ceph_volume.api.lvm.get_single_lv') |
287 | def test_create_vg(self, m_get_single_lv, m_create_vg, m_get_device_vgs, m_call, | |
92f5a8d4 | 288 | m_run, monkeypatch): |
a4b75251 | 289 | m_get_single_lv.return_value = self.foo_volume |
92f5a8d4 TL |
290 | m_get_device_vgs.return_value = [] |
291 | api.create_lv('foo', 0, device='dev/foo', size='5G', tags={'ceph.type': 'data'}) | |
292 | m_create_vg.assert_called_with('dev/foo', name_prefix='ceph') | |
1adf2230 AA |
293 | |
294 | ||
81eedcae TL |
295 | class TestTags(object): |
296 | ||
05a536ef | 297 | def setup_method(self): |
81eedcae TL |
298 | self.foo_volume_clean = api.Volume(lv_name='foo_clean', lv_path='/pathclean', |
299 | vg_name='foo_group', | |
300 | lv_tags='') | |
301 | self.foo_volume = api.Volume(lv_name='foo', lv_path='/path', | |
302 | vg_name='foo_group', | |
303 | lv_tags='ceph.foo0=bar0,ceph.foo1=bar1,ceph.foo2=bar2') | |
304 | ||
305 | def test_set_tag(self, monkeypatch, capture): | |
306 | monkeypatch.setattr(process, 'run', capture) | |
307 | monkeypatch.setattr(process, 'call', capture) | |
308 | self.foo_volume_clean.set_tag('foo', 'bar') | |
309 | expected = ['lvchange', '--addtag', 'foo=bar', '/pathclean'] | |
310 | assert capture.calls[0]['args'][0] == expected | |
311 | assert self.foo_volume_clean.tags == {'foo': 'bar'} | |
312 | ||
313 | def test_set_clear_tag(self, monkeypatch, capture): | |
314 | monkeypatch.setattr(process, 'run', capture) | |
315 | monkeypatch.setattr(process, 'call', capture) | |
316 | self.foo_volume_clean.set_tag('foo', 'bar') | |
317 | assert self.foo_volume_clean.tags == {'foo': 'bar'} | |
318 | self.foo_volume_clean.clear_tag('foo') | |
319 | expected = ['lvchange', '--deltag', 'foo=bar', '/pathclean'] | |
320 | assert self.foo_volume_clean.tags == {} | |
321 | assert capture.calls[1]['args'][0] == expected | |
322 | ||
323 | def test_set_tags(self, monkeypatch, capture): | |
324 | monkeypatch.setattr(process, 'run', capture) | |
325 | monkeypatch.setattr(process, 'call', capture) | |
326 | tags = {'ceph.foo0': 'bar0', 'ceph.foo1': 'bar1', 'ceph.foo2': 'bar2'} | |
327 | assert self.foo_volume.tags == tags | |
328 | ||
329 | tags = {'ceph.foo0': 'bar0', 'ceph.foo1': 'baz1', 'ceph.foo2': 'baz2'} | |
330 | self.foo_volume.set_tags(tags) | |
331 | assert self.foo_volume.tags == tags | |
332 | ||
333 | self.foo_volume.set_tag('ceph.foo1', 'other1') | |
334 | tags['ceph.foo1'] = 'other1' | |
335 | assert self.foo_volume.tags == tags | |
336 | ||
337 | expected = [ | |
e306af50 TL |
338 | sorted(['lvchange', '--deltag', 'ceph.foo0=bar0', '--deltag', |
339 | 'ceph.foo1=bar1', '--deltag', 'ceph.foo2=bar2', '/path']), | |
340 | sorted(['lvchange', '--deltag', 'ceph.foo1=baz1', '/path']), | |
341 | sorted(['lvchange', '--addtag', 'ceph.foo0=bar0', '--addtag', | |
342 | 'ceph.foo1=baz1', '--addtag', 'ceph.foo2=baz2', '/path']), | |
343 | sorted(['lvchange', '--addtag', 'ceph.foo1=other1', '/path']), | |
81eedcae TL |
344 | ] |
345 | # The order isn't guaranted | |
346 | for call in capture.calls: | |
e306af50 | 347 | assert sorted(call['args'][0]) in expected |
81eedcae TL |
348 | assert len(capture.calls) == len(expected) |
349 | ||
350 | def test_clear_tags(self, monkeypatch, capture): | |
351 | monkeypatch.setattr(process, 'run', capture) | |
352 | monkeypatch.setattr(process, 'call', capture) | |
353 | tags = {'ceph.foo0': 'bar0', 'ceph.foo1': 'bar1', 'ceph.foo2': 'bar2'} | |
354 | ||
355 | self.foo_volume_clean.set_tags(tags) | |
356 | assert self.foo_volume_clean.tags == tags | |
357 | self.foo_volume_clean.clear_tags() | |
358 | assert self.foo_volume_clean.tags == {} | |
359 | ||
360 | expected = [ | |
e306af50 TL |
361 | sorted(['lvchange', '--addtag', 'ceph.foo0=bar0', '--addtag', |
362 | 'ceph.foo1=bar1', '--addtag', 'ceph.foo2=bar2', | |
363 | '/pathclean']), | |
364 | sorted(['lvchange', '--deltag', 'ceph.foo0=bar0', '--deltag', | |
365 | 'ceph.foo1=bar1', '--deltag', 'ceph.foo2=bar2', | |
366 | '/pathclean']), | |
81eedcae TL |
367 | ] |
368 | # The order isn't guaranted | |
369 | for call in capture.calls: | |
e306af50 | 370 | assert sorted(call['args'][0]) in expected |
81eedcae TL |
371 | assert len(capture.calls) == len(expected) |
372 | ||
373 | ||
1adf2230 AA |
374 | class TestExtendVG(object): |
375 | ||
05a536ef | 376 | def setup_method(self): |
1adf2230 AA |
377 | self.foo_volume = api.VolumeGroup(vg_name='foo', lv_tags='') |
378 | ||
379 | def test_uses_single_device_in_list(self, monkeypatch, fake_run): | |
a4b75251 | 380 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
381 | api.extend_vg(self.foo_volume, ['/dev/sda']) |
382 | expected = ['vgextend', '--force', '--yes', 'foo', '/dev/sda'] | |
383 | assert fake_run.calls[0]['args'][0] == expected | |
384 | ||
385 | def test_uses_single_device(self, monkeypatch, fake_run): | |
a4b75251 | 386 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
387 | api.extend_vg(self.foo_volume, '/dev/sda') |
388 | expected = ['vgextend', '--force', '--yes', 'foo', '/dev/sda'] | |
389 | assert fake_run.calls[0]['args'][0] == expected | |
390 | ||
391 | def test_uses_multiple_devices(self, monkeypatch, fake_run): | |
a4b75251 | 392 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
393 | api.extend_vg(self.foo_volume, ['/dev/sda', '/dev/sdb']) |
394 | expected = ['vgextend', '--force', '--yes', 'foo', '/dev/sda', '/dev/sdb'] | |
81eedcae TL |
395 | assert fake_run.calls[0]['args'][0] == expected |
396 | ||
397 | ||
398 | class TestReduceVG(object): | |
399 | ||
05a536ef | 400 | def setup_method(self): |
81eedcae TL |
401 | self.foo_volume = api.VolumeGroup(vg_name='foo', lv_tags='') |
402 | ||
403 | def test_uses_single_device_in_list(self, monkeypatch, fake_run): | |
a4b75251 | 404 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
81eedcae TL |
405 | api.reduce_vg(self.foo_volume, ['/dev/sda']) |
406 | expected = ['vgreduce', '--force', '--yes', 'foo', '/dev/sda'] | |
407 | assert fake_run.calls[0]['args'][0] == expected | |
408 | ||
409 | def test_uses_single_device(self, monkeypatch, fake_run): | |
a4b75251 | 410 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
81eedcae TL |
411 | api.reduce_vg(self.foo_volume, '/dev/sda') |
412 | expected = ['vgreduce', '--force', '--yes', 'foo', '/dev/sda'] | |
413 | assert fake_run.calls[0]['args'][0] == expected | |
414 | ||
415 | def test_uses_multiple_devices(self, monkeypatch, fake_run): | |
a4b75251 | 416 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
81eedcae TL |
417 | api.reduce_vg(self.foo_volume, ['/dev/sda', '/dev/sdb']) |
418 | expected = ['vgreduce', '--force', '--yes', 'foo', '/dev/sda', '/dev/sdb'] | |
1adf2230 AA |
419 | assert fake_run.calls[0]['args'][0] == expected |
420 | ||
421 | ||
422 | class TestCreateVG(object): | |
423 | ||
05a536ef | 424 | def setup_method(self): |
1adf2230 AA |
425 | self.foo_volume = api.VolumeGroup(vg_name='foo', lv_tags='') |
426 | ||
427 | def test_no_name(self, monkeypatch, fake_run): | |
a4b75251 | 428 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
429 | api.create_vg('/dev/sda') |
430 | result = fake_run.calls[0]['args'][0] | |
431 | assert '/dev/sda' in result | |
432 | assert result[-2].startswith('ceph-') | |
433 | ||
434 | def test_devices_list(self, monkeypatch, fake_run): | |
a4b75251 | 435 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
436 | api.create_vg(['/dev/sda', '/dev/sdb'], name='ceph') |
437 | result = fake_run.calls[0]['args'][0] | |
92f5a8d4 | 438 | expected = ['vgcreate', '--force', '--yes', 'ceph', '/dev/sda', '/dev/sdb'] |
1adf2230 AA |
439 | assert result == expected |
440 | ||
441 | def test_name_prefix(self, monkeypatch, fake_run): | |
a4b75251 | 442 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
443 | api.create_vg('/dev/sda', name_prefix='master') |
444 | result = fake_run.calls[0]['args'][0] | |
445 | assert '/dev/sda' in result | |
446 | assert result[-2].startswith('master-') | |
447 | ||
448 | def test_specific_name(self, monkeypatch, fake_run): | |
a4b75251 | 449 | monkeypatch.setattr(api, 'get_single_vg', lambda **kw: True) |
1adf2230 AA |
450 | api.create_vg('/dev/sda', name='master') |
451 | result = fake_run.calls[0]['args'][0] | |
452 | assert '/dev/sda' in result | |
453 | assert result[-2] == 'master' | |
94b18763 FG |
454 | |
455 | # | |
456 | # The following tests are pretty gnarly. VDO detection is very convoluted and | |
457 | # involves correlating information from device mappers, realpaths, slaves of | |
458 | # those mappers, and parents or related mappers. This makes it very hard to | |
459 | # patch nicely or keep tests short and readable. These tests are trying to | |
460 | # ensure correctness, the better approach will be to do some functional testing | |
461 | # with VDO. | |
462 | # | |
463 | ||
464 | ||
465 | @pytest.fixture | |
466 | def disable_kvdo_path(monkeypatch): | |
91327a77 | 467 | monkeypatch.setattr('os.path.isdir', lambda x, **kw: False) |
94b18763 FG |
468 | |
469 | ||
470 | @pytest.fixture | |
471 | def enable_kvdo_path(monkeypatch): | |
91327a77 | 472 | monkeypatch.setattr('os.path.isdir', lambda x, **kw: True) |
94b18763 FG |
473 | |
474 | ||
475 | # Stub for os.listdir | |
476 | ||
477 | ||
478 | class ListDir(object): | |
479 | ||
480 | def __init__(self, paths): | |
481 | self.paths = paths | |
482 | self._normalize_paths() | |
483 | self.listdir = os.listdir | |
484 | ||
485 | def _normalize_paths(self): | |
486 | for k, v in self.paths.items(): | |
487 | self.paths[k.rstrip('/')] = v.rstrip('/') | |
488 | ||
489 | def add(self, original, fake): | |
490 | self.paths[original.rstrip('/')] = fake.rstrip('/') | |
491 | ||
492 | def __call__(self, path): | |
493 | return self.listdir(self.paths[path.rstrip('/')]) | |
494 | ||
495 | ||
496 | @pytest.fixture(scope='function') | |
497 | def listdir(monkeypatch): | |
498 | def apply(paths=None, stub=None): | |
499 | if not stub: | |
500 | stub = ListDir(paths) | |
501 | if paths: | |
502 | for original, fake in paths.items(): | |
503 | stub.add(original, fake) | |
504 | ||
505 | monkeypatch.setattr('os.listdir', stub) | |
506 | return apply | |
507 | ||
508 | ||
509 | @pytest.fixture(scope='function') | |
510 | def makedirs(tmpdir): | |
511 | def create(directory): | |
512 | path = os.path.join(str(tmpdir), directory) | |
513 | os.makedirs(path) | |
514 | return path | |
515 | create.base = str(tmpdir) | |
516 | return create | |
517 | ||
518 | ||
519 | class TestIsVdo(object): | |
520 | ||
521 | def test_no_vdo_dir(self, disable_kvdo_path): | |
522 | assert api._is_vdo('/path') is False | |
523 | ||
524 | def test_exceptions_return_false(self, monkeypatch): | |
525 | def throw(): | |
526 | raise Exception() | |
527 | monkeypatch.setattr('ceph_volume.api.lvm._is_vdo', throw) | |
528 | assert api.is_vdo('/path') == '0' | |
529 | ||
530 | def test_is_vdo_returns_a_string(self, monkeypatch): | |
91327a77 | 531 | monkeypatch.setattr('ceph_volume.api.lvm._is_vdo', lambda x, **kw: True) |
94b18763 FG |
532 | assert api.is_vdo('/path') == '1' |
533 | ||
534 | def test_kvdo_dir_no_devices(self, makedirs, enable_kvdo_path, listdir, monkeypatch): | |
535 | kvdo_path = makedirs('sys/kvdo') | |
536 | listdir(paths={'/sys/kvdo': kvdo_path}) | |
91327a77 AA |
537 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_slaves', lambda x, **kw: []) |
538 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_parents', lambda x, **kw: []) | |
94b18763 FG |
539 | assert api._is_vdo('/dev/mapper/vdo0') is False |
540 | ||
541 | def test_vdo_slaves_found_and_matched(self, makedirs, enable_kvdo_path, listdir, monkeypatch): | |
542 | kvdo_path = makedirs('sys/kvdo') | |
543 | listdir(paths={'/sys/kvdo': kvdo_path}) | |
91327a77 AA |
544 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_slaves', lambda x, **kw: ['/dev/dm-3']) |
545 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_parents', lambda x, **kw: []) | |
94b18763 FG |
546 | assert api._is_vdo('/dev/dm-3') is True |
547 | ||
548 | def test_vdo_parents_found_and_matched(self, makedirs, enable_kvdo_path, listdir, monkeypatch): | |
549 | kvdo_path = makedirs('sys/kvdo') | |
550 | listdir(paths={'/sys/kvdo': kvdo_path}) | |
91327a77 AA |
551 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_slaves', lambda x, **kw: []) |
552 | monkeypatch.setattr('ceph_volume.api.lvm._vdo_parents', lambda x, **kw: ['/dev/dm-4']) | |
94b18763 FG |
553 | assert api._is_vdo('/dev/dm-4') is True |
554 | ||
555 | ||
556 | class TestVdoSlaves(object): | |
557 | ||
558 | def test_slaves_are_not_found(self, makedirs, listdir, monkeypatch): | |
559 | slaves_path = makedirs('sys/block/vdo0/slaves') | |
560 | listdir(paths={'/sys/block/vdo0/slaves': slaves_path}) | |
91327a77 | 561 | monkeypatch.setattr('ceph_volume.api.lvm.os.path.exists', lambda x, **kw: True) |
94b18763 FG |
562 | result = sorted(api._vdo_slaves(['vdo0'])) |
563 | assert '/dev/mapper/vdo0' in result | |
564 | assert 'vdo0' in result | |
565 | ||
566 | def test_slaves_are_found(self, makedirs, listdir, monkeypatch): | |
567 | slaves_path = makedirs('sys/block/vdo0/slaves') | |
568 | makedirs('sys/block/vdo0/slaves/dm-4') | |
569 | makedirs('dev/mapper/vdo0') | |
570 | listdir(paths={'/sys/block/vdo0/slaves': slaves_path}) | |
91327a77 | 571 | monkeypatch.setattr('ceph_volume.api.lvm.os.path.exists', lambda x, **kw: True) |
94b18763 FG |
572 | result = sorted(api._vdo_slaves(['vdo0'])) |
573 | assert '/dev/dm-4' in result | |
574 | assert 'dm-4' in result | |
575 | ||
576 | ||
577 | class TestVDOParents(object): | |
578 | ||
579 | def test_parents_are_found(self, makedirs, listdir): | |
580 | block_path = makedirs('sys/block') | |
581 | slaves_path = makedirs('sys/block/dm-4/slaves') | |
582 | makedirs('sys/block/dm-4/slaves/dm-3') | |
583 | listdir(paths={ | |
584 | '/sys/block/dm-4/slaves': slaves_path, | |
585 | '/sys/block': block_path}) | |
586 | result = api._vdo_parents(['dm-3']) | |
587 | assert '/dev/dm-4' in result | |
588 | assert 'dm-4' in result | |
589 | ||
590 | def test_parents_are_not_found(self, makedirs, listdir): | |
591 | block_path = makedirs('sys/block') | |
592 | slaves_path = makedirs('sys/block/dm-4/slaves') | |
593 | makedirs('sys/block/dm-4/slaves/dm-5') | |
594 | listdir(paths={ | |
595 | '/sys/block/dm-4/slaves': slaves_path, | |
596 | '/sys/block': block_path}) | |
597 | result = api._vdo_parents(['dm-3']) | |
598 | assert result == [] | |
1adf2230 AA |
599 | |
600 | ||
601 | class TestSplitNameParser(object): | |
602 | ||
603 | def test_keys_are_parsed_without_prefix(self): | |
604 | line = ["DM_VG_NAME='/dev/mapper/vg';DM_LV_NAME='lv';DM_LV_LAYER=''"] | |
605 | result = api._splitname_parser(line) | |
606 | assert result['VG_NAME'] == 'vg' | |
607 | assert result['LV_NAME'] == 'lv' | |
608 | assert result['LV_LAYER'] == '' | |
609 | ||
610 | def test_vg_name_sans_mapper(self): | |
611 | line = ["DM_VG_NAME='/dev/mapper/vg';DM_LV_NAME='lv';DM_LV_LAYER=''"] | |
612 | result = api._splitname_parser(line) | |
613 | assert '/dev/mapper' not in result['VG_NAME'] | |
614 | ||
615 | ||
9f95a23c TL |
616 | class TestGetDeviceVgs(object): |
617 | ||
618 | @patch('ceph_volume.process.call') | |
619 | @patch('ceph_volume.api.lvm._output_parser') | |
620 | def test_get_device_vgs_with_empty_pv(self, patched_output_parser, pcall): | |
621 | patched_output_parser.return_value = [{'vg_name': ''}] | |
622 | pcall.return_value = ('', '', '') | |
623 | vgs = api.get_device_vgs('/dev/foo') | |
624 | assert vgs == [] | |
625 | ||
626 | class TestGetDeviceLvs(object): | |
627 | ||
628 | @patch('ceph_volume.process.call') | |
629 | @patch('ceph_volume.api.lvm._output_parser') | |
630 | def test_get_device_lvs_with_empty_vg(self, patched_output_parser, pcall): | |
631 | patched_output_parser.return_value = [{'lv_name': ''}] | |
632 | pcall.return_value = ('', '', '') | |
633 | vgs = api.get_device_lvs('/dev/foo') | |
634 | assert vgs == [] | |
f6b5b4d7 TL |
635 | |
636 | ||
637 | # NOTE: api.convert_filters_to_str() and api.convert_tags_to_str() should get | |
638 | # tested automatically while testing api.make_filters_lvmcmd_ready() | |
639 | class TestMakeFiltersLVMCMDReady(object): | |
640 | ||
641 | def test_with_no_filters_and_no_tags(self): | |
642 | retval = api.make_filters_lvmcmd_ready(None, None) | |
643 | ||
644 | assert isinstance(retval, str) | |
645 | assert retval == '' | |
646 | ||
647 | def test_with_filters_and_no_tags(self): | |
648 | filters = {'lv_name': 'lv1', 'lv_path': '/dev/sda'} | |
649 | ||
650 | retval = api.make_filters_lvmcmd_ready(filters, None) | |
651 | ||
652 | assert isinstance(retval, str) | |
653 | for k, v in filters.items(): | |
654 | assert k in retval | |
655 | assert v in retval | |
656 | ||
657 | def test_with_no_filters_and_with_tags(self): | |
658 | tags = {'ceph.type': 'data', 'ceph.osd_id': '0'} | |
659 | ||
660 | retval = api.make_filters_lvmcmd_ready(None, tags) | |
661 | ||
662 | assert isinstance(retval, str) | |
663 | assert 'tags' in retval | |
664 | for k, v in tags.items(): | |
665 | assert k in retval | |
666 | assert v in retval | |
667 | assert retval.find('tags') < retval.find(k) < retval.find(v) | |
668 | ||
669 | def test_with_filters_and_tags(self): | |
670 | filters = {'lv_name': 'lv1', 'lv_path': '/dev/sda'} | |
671 | tags = {'ceph.type': 'data', 'ceph.osd_id': '0'} | |
672 | ||
673 | retval = api.make_filters_lvmcmd_ready(filters, tags) | |
674 | ||
675 | assert isinstance(retval, str) | |
676 | for f, t in zip(filters.items(), tags.items()): | |
677 | assert f[0] in retval | |
678 | assert f[1] in retval | |
679 | assert t[0] in retval | |
680 | assert t[1] in retval | |
681 | assert retval.find(f[0]) < retval.find(f[1]) < \ | |
682 | retval.find('tags') < retval.find(t[0]) < retval.find(t[1]) | |
683 | ||
684 | ||
685 | class TestGetPVs(object): | |
686 | ||
687 | def test_get_pvs(self, monkeypatch): | |
688 | pv1 = api.PVolume(pv_name='/dev/sda', pv_uuid='0000', pv_tags={}, | |
689 | vg_name='vg1') | |
690 | pv2 = api.PVolume(pv_name='/dev/sdb', pv_uuid='0001', pv_tags={}, | |
691 | vg_name='vg2') | |
692 | pvs = [pv1, pv2] | |
693 | stdout = ['{};{};{};{};;'.format(pv1.pv_name, pv1.pv_tags, pv1.pv_uuid, pv1.vg_name), | |
694 | '{};{};{};{};;'.format(pv2.pv_name, pv2.pv_tags, pv2.pv_uuid, pv2.vg_name)] | |
695 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
696 | ||
697 | pvs_ = api.get_pvs() | |
698 | assert len(pvs_) == len(pvs) | |
699 | for pv, pv_ in zip(pvs, pvs_): | |
700 | assert pv_.pv_name == pv.pv_name | |
701 | ||
702 | def test_get_pvs_single_pv(self, monkeypatch): | |
703 | pv1 = api.PVolume(pv_name='/dev/sda', pv_uuid='0000', pv_tags={}, | |
704 | vg_name='vg1') | |
705 | pvs = [pv1] | |
706 | stdout = ['{};;;;;;'.format(pv1.pv_name)] | |
707 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
708 | ||
709 | pvs_ = api.get_pvs() | |
710 | assert len(pvs_) == 1 | |
711 | assert pvs_[0].pv_name == pvs[0].pv_name | |
712 | ||
713 | def test_get_pvs_empty(self, monkeypatch): | |
714 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: ('', '', 0)) | |
715 | assert api.get_pvs() == [] | |
716 | ||
717 | ||
718 | class TestGetVGs(object): | |
719 | ||
720 | def test_get_vgs(self, monkeypatch): | |
721 | vg1 = api.VolumeGroup(vg_name='vg1') | |
722 | vg2 = api.VolumeGroup(vg_name='vg2') | |
723 | vgs = [vg1, vg2] | |
724 | stdout = ['{};;;;;;'.format(vg1.vg_name), | |
725 | '{};;;;;;'.format(vg2.vg_name)] | |
726 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
727 | ||
728 | vgs_ = api.get_vgs() | |
729 | assert len(vgs_) == len(vgs) | |
730 | for vg, vg_ in zip(vgs, vgs_): | |
731 | assert vg_.vg_name == vg.vg_name | |
732 | ||
733 | def test_get_vgs_single_vg(self, monkeypatch): | |
734 | vg1 = api.VolumeGroup(vg_name='vg'); vgs = [vg1] | |
735 | stdout = ['{};;;;;;'.format(vg1.vg_name)] | |
736 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
737 | ||
738 | vgs_ = api.get_vgs() | |
739 | assert len(vgs_) == 1 | |
740 | assert vgs_[0].vg_name == vgs[0].vg_name | |
741 | ||
742 | def test_get_vgs_empty(self, monkeypatch): | |
743 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: ('', '', 0)) | |
744 | assert api.get_vgs() == [] | |
745 | ||
746 | ||
747 | class TestGetLVs(object): | |
748 | ||
749 | def test_get_lvs(self, monkeypatch): | |
750 | lv1 = api.Volume(lv_tags='ceph.type=data', lv_path='/dev/vg1/lv1', | |
751 | lv_name='lv1', vg_name='vg1') | |
752 | lv2 = api.Volume(lv_tags='ceph.type=data', lv_path='/dev/vg2/lv2', | |
753 | lv_name='lv2', vg_name='vg2') | |
754 | lvs = [lv1, lv2] | |
755 | stdout = ['{};{};{};{}'.format(lv1.lv_tags, lv1.lv_path, lv1.lv_name, | |
756 | lv1.vg_name), | |
757 | '{};{};{};{}'.format(lv2.lv_tags, lv2.lv_path, lv2.lv_name, | |
758 | lv2.vg_name)] | |
759 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
760 | ||
761 | lvs_ = api.get_lvs() | |
762 | assert len(lvs_) == len(lvs) | |
763 | for lv, lv_ in zip(lvs, lvs_): | |
764 | assert lv.__dict__ == lv_.__dict__ | |
765 | ||
766 | def test_get_lvs_single_lv(self, monkeypatch): | |
767 | stdout = ['ceph.type=data;/dev/vg/lv;lv;vg'] | |
768 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: (stdout, '', 0)) | |
769 | lvs = [] | |
770 | lvs.append((api.Volume(lv_tags='ceph.type=data', | |
771 | lv_path='/dev/vg/lv', | |
772 | lv_name='lv', vg_name='vg'))) | |
773 | ||
774 | lvs_ = api.get_lvs() | |
775 | assert len(lvs_) == len(lvs) | |
776 | assert lvs[0].__dict__ == lvs_[0].__dict__ | |
777 | ||
778 | def test_get_lvs_empty(self, monkeypatch): | |
779 | monkeypatch.setattr(api.process, 'call', lambda x,**kw: ('', '', 0)) | |
780 | assert api.get_lvs() == [] | |
781 | ||
782 | ||
a4b75251 | 783 | class TestGetSinglePV(object): |
f6b5b4d7 | 784 | |
a4b75251 TL |
785 | @patch('ceph_volume.devices.lvm.prepare.api.get_pvs') |
786 | def test_get_single_pv_multiple_matches_raises_runtimeerror(self, m_get_pvs): | |
787 | fake_pvs = [] | |
788 | fake_pvs.append(api.PVolume(pv_name='/dev/sda', pv_tags={})) | |
789 | fake_pvs.append(api.PVolume(pv_name='/dev/sdb', pv_tags={})) | |
f6b5b4d7 | 790 | |
a4b75251 | 791 | m_get_pvs.return_value = fake_pvs |
f6b5b4d7 | 792 | |
a4b75251 TL |
793 | with pytest.raises(RuntimeError) as e: |
794 | api.get_single_pv() | |
795 | assert "matched more than 1 PV present on this host." in str(e.value) | |
f6b5b4d7 | 796 | |
a4b75251 TL |
797 | @patch('ceph_volume.devices.lvm.prepare.api.get_pvs') |
798 | def test_get_single_pv_no_match_returns_none(self, m_get_pvs): | |
799 | m_get_pvs.return_value = [] | |
f6b5b4d7 | 800 | |
a4b75251 TL |
801 | pv = api.get_single_pv() |
802 | assert pv == None | |
f6b5b4d7 | 803 | |
a4b75251 TL |
804 | @patch('ceph_volume.devices.lvm.prepare.api.get_pvs') |
805 | def test_get_single_pv_one_match(self, m_get_pvs): | |
806 | fake_pvs = [] | |
807 | fake_pvs.append(api.PVolume(pv_name='/dev/sda', pv_tags={})) | |
808 | m_get_pvs.return_value = fake_pvs | |
f6b5b4d7 | 809 | |
a4b75251 | 810 | pv = api.get_single_pv() |
f6b5b4d7 | 811 | |
a4b75251 TL |
812 | assert isinstance(pv, api.PVolume) |
813 | assert pv.name == '/dev/sda' | |
f6b5b4d7 | 814 | |
f6b5b4d7 | 815 | |
a4b75251 | 816 | class TestGetSingleVG(object): |
f6b5b4d7 | 817 | |
a4b75251 TL |
818 | @patch('ceph_volume.devices.lvm.prepare.api.get_vgs') |
819 | def test_get_single_vg_multiple_matches_raises_runtimeerror(self, m_get_vgs): | |
820 | fake_vgs = [] | |
821 | fake_vgs.append(api.VolumeGroup(vg_name='vg1')) | |
822 | fake_vgs.append(api.VolumeGroup(vg_name='vg2')) | |
f6b5b4d7 | 823 | |
a4b75251 | 824 | m_get_vgs.return_value = fake_vgs |
f6b5b4d7 | 825 | |
a4b75251 TL |
826 | with pytest.raises(RuntimeError) as e: |
827 | api.get_single_vg() | |
828 | assert "matched more than 1 VG present on this host." in str(e.value) | |
f6b5b4d7 | 829 | |
a4b75251 TL |
830 | @patch('ceph_volume.devices.lvm.prepare.api.get_vgs') |
831 | def test_get_single_vg_no_match_returns_none(self, m_get_vgs): | |
832 | m_get_vgs.return_value = [] | |
f6b5b4d7 | 833 | |
a4b75251 TL |
834 | vg = api.get_single_vg() |
835 | assert vg == None | |
f6b5b4d7 | 836 | |
a4b75251 TL |
837 | @patch('ceph_volume.devices.lvm.prepare.api.get_vgs') |
838 | def test_get_single_vg_one_match(self, m_get_vgs): | |
839 | fake_vgs = [] | |
840 | fake_vgs.append(api.VolumeGroup(vg_name='vg1')) | |
841 | m_get_vgs.return_value = fake_vgs | |
f6b5b4d7 | 842 | |
a4b75251 | 843 | vg = api.get_single_vg() |
f6b5b4d7 | 844 | |
a4b75251 TL |
845 | assert isinstance(vg, api.VolumeGroup) |
846 | assert vg.name == 'vg1' | |
f6b5b4d7 | 847 | |
a4b75251 TL |
848 | class TestGetSingleLV(object): |
849 | ||
850 | @patch('ceph_volume.devices.lvm.prepare.api.get_lvs') | |
851 | def test_get_single_lv_multiple_matches_raises_runtimeerror(self, m_get_lvs): | |
852 | fake_lvs = [] | |
853 | fake_lvs.append(api.Volume(lv_name='lv1', | |
854 | lv_path='/dev/vg1/lv1', | |
855 | vg_name='vg1', | |
856 | lv_tags='', | |
857 | lv_uuid='fake-uuid')) | |
858 | fake_lvs.append(api.Volume(lv_name='lv1', | |
859 | lv_path='/dev/vg2/lv1', | |
860 | vg_name='vg2', | |
861 | lv_tags='', | |
862 | lv_uuid='fake-uuid')) | |
863 | m_get_lvs.return_value = fake_lvs | |
864 | ||
865 | with pytest.raises(RuntimeError) as e: | |
866 | api.get_single_lv() | |
867 | assert "matched more than 1 LV present on this host" in str(e.value) | |
868 | ||
869 | @patch('ceph_volume.devices.lvm.prepare.api.get_lvs') | |
870 | def test_get_single_lv_no_match_returns_none(self, m_get_lvs): | |
871 | m_get_lvs.return_value = [] | |
872 | ||
873 | lv = api.get_single_lv() | |
874 | assert lv == None | |
875 | ||
876 | @patch('ceph_volume.devices.lvm.prepare.api.get_lvs') | |
877 | def test_get_single_lv_one_match(self, m_get_lvs): | |
878 | fake_lvs = [] | |
879 | fake_lvs.append(api.Volume(lv_name='lv1', lv_path='/dev/vg1/lv1', vg_name='vg1', lv_tags='', lv_uuid='fake-uuid')) | |
880 | m_get_lvs.return_value = fake_lvs | |
881 | ||
882 | lv_ = api.get_single_lv() | |
883 | ||
884 | assert isinstance(lv_, api.Volume) | |
885 | assert lv_.name == 'lv1' | |
aee94f69 TL |
886 | |
887 | ||
888 | class TestHelpers: | |
889 | def test_get_lv_path_from_mapper(self): | |
890 | mapper = '/dev/mapper/ceph--c1a97e46--234c--46aa--a549--3ca1d1f356a9-osd--block--32e8e896--172e--4a38--a06a--3702598510ec' | |
891 | lv_path = api.get_lv_path_from_mapper(mapper) | |
892 | assert lv_path == '/dev/ceph-c1a97e46-234c-46aa-a549-3ca1d1f356a9/osd-block-32e8e896-172e-4a38-a06a-3702598510ec' | |
893 | ||
894 | def test_get_mapper_from_lv_path(self): | |
895 | lv_path = '/dev/ceph-c1a97e46-234c-46aa-a549-3ca1d1f356a9/osd-block-32e8e896-172e-4a38-a06a-3702598510ec' | |
896 | mapper = api.get_mapper_from_lv_path(lv_path) | |
897 | assert mapper == '/dev/mapper/ceph--c1a97e46--234c--46aa--a549--3ca1d1f356a9/osd--block--32e8e896--172e--4a38--a06a/3702598510ec' |