]>
Commit | Line | Data |
---|---|---|
6838f038 WB |
1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
2 | From: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
83faa3fe TL |
3 | Date: Mon, 6 Apr 2020 12:16:30 +0200 |
4 | Subject: [PATCH] PVE: [Config] block/file: change locking default to off | |
6838f038 WB |
5 | |
6 | 'auto' only checks whether the system generally supports OFD | |
7 | locks but not whether the storage the file resides on | |
8 | supports any locking, causing issues with NFS. | |
9 | ||
10 | Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com> | |
b855dce7 | 11 | Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> |
6838f038 WB |
12 | --- |
13 | block/file-posix.c | 4 ++-- | |
14 | 1 file changed, 2 insertions(+), 2 deletions(-) | |
15 | ||
16 | diff --git a/block/file-posix.c b/block/file-posix.c | |
d03e1b3c | 17 | index b9647c5ffc..9a16d86344 100644 |
6838f038 WB |
18 | --- a/block/file-posix.c |
19 | +++ b/block/file-posix.c | |
d03e1b3c | 20 | @@ -552,7 +552,7 @@ static QemuOptsList raw_runtime_opts = { |
6838f038 WB |
21 | { |
22 | .name = "locking", | |
23 | .type = QEMU_OPT_STRING, | |
24 | - .help = "file locking mode (on/off/auto, default: auto)", | |
25 | + .help = "file locking mode (on/off/auto, default: off)", | |
26 | }, | |
27 | { | |
28 | .name = "pr-manager", | |
d03e1b3c | 29 | @@ -652,7 +652,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, |
6838f038 WB |
30 | s->use_lock = false; |
31 | break; | |
32 | case ON_OFF_AUTO_AUTO: | |
33 | - s->use_lock = qemu_has_ofd_lock(); | |
34 | + s->use_lock = false; | |
35 | break; | |
36 | default: | |
37 | abort(); |