debian/patches/pve/0058-PVE-fall-back-to-open-iscsi-initiatorname.patch

   1 From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
   2 From: Fabian Ebner <f.ebner@proxmox.com>
   3 Date: Tue, 17 Nov 2020 10:51:05 +0100
   4 Subject: [PATCH] PVE: fall back to open-iscsi initiatorname
   5
   6 When no explicit option is given, try reading the initiator name from
   7 /etc/iscsi/initiatorname.iscsi and only use the generic fallback, i.e.
   8 iqn.2008-11.org.linux-kvmXXX, as a third alternative.
   9
  10 This avoids the need to add an explicit option for vma and to explicitly set it
  11 for each call to qemu that deals with iSCSI disks, while still allowing to set
  12 the option if a different name is needed.
  13
  14 According to RFC 3720, an initiator name is at most 223 bytes long, so the
  15 4 KiB buffer is big enough, even if many whitespaces are used.
  16
  17 Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
  18 ---
  19  block/iscsi.c | 30 ++++++++++++++++++++++++++++++
  20  1 file changed, 30 insertions(+)
  21
  22 diff --git a/block/iscsi.c b/block/iscsi.c
  23 index bd2122a3a4..56437d8b99 100644
  24 --- a/block/iscsi.c
  25 +++ b/block/iscsi.c
  26 @@ -1374,12 +1374,42 @@ static char *get_initiator_name(QemuOpts *opts)
  27      const char *name;
  28      char *iscsi_name;
  29      UuidInfo *uuid_info;
  30 +    FILE *name_fh;
  31
  32      name = qemu_opt_get(opts, "initiator-name");
  33      if (name) {
  34          return g_strdup(name);
  35      }
  36
  37 +    name_fh = fopen("/etc/iscsi/initiatorname.iscsi", "r");
  38 +    if (name_fh) {
  39 +        const char *key = "InitiatorName";
  40 +        char buffer[4096];
  41 +        char *line;
  42 +
  43 +        while ((line = fgets(buffer, sizeof(buffer), name_fh))) {
  44 +            line = g_strstrip(line);
  45 +            if (!strncmp(line, key, strlen(key))) {
  46 +                line = strchr(line, '=');
  47 +                if (!line || strlen(line) == 1) {
  48 +                    continue;
  49 +                }
  50 +                line++;
  51 +                g_strstrip(line);
  52 +                if (!strlen(line)) {
  53 +                    continue;
  54 +                }
  55 +                name = line;
  56 +                break;
  57 +            }
  58 +        }
  59 +        fclose(name_fh);
  60 +
  61 +        if (name) {
  62 +            return g_strdup(name);
  63 +        }
  64 +    }
  65 +
  66      uuid_info = qmp_query_uuid(NULL);
  67      if (strcmp(uuid_info->UUID, UUID_NONE) == 0) {
  68          name = qemu_get_vm_name();
  69 --
  70 2.20.1
  71