Fixup for review

[mirror_edk2.git] / IntelFrameworkModulePkg / Bus / Pci / IdeBusDxe / Atapi.c

diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c
index e7ddcb980ef1633951ffb79554ea6610520823e2..e3515d254769cfa7db2faed0fc2b22e01ee77ecf 100644 (file)
--- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c
+++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c
@@ -90,11 +90,11 @@ LS120GetMediaStatus (
   //\r
   StatusValue = IDEReadPortB (IdeDev->PciIo, IdeDev->IoPort->Reg1.Error);\r
 \r
-  if (StatusValue & BIT1) {\r
+  if ((StatusValue & BIT1) != 0) {\r
     return EFI_NO_MEDIA;\r
   }\r
 \r
-  if (StatusValue & BIT6) {\r
+  if ((StatusValue & BIT6) != 0) {\r
     return EFI_WRITE_PROTECTED;\r
   } else {\r
     return EFI_SUCCESS;\r
@@ -803,7 +803,7 @@ PioReadWriteData (
 \r
   @param[in] *IdeDev     Pointer pointing to IDE_BLK_IO_DEV data structure, used\r
                          to record all the information of the IDE device.\r
-  @param[in] *SResult    Sense result for this packet command.\r
+  @param[out] *SResult   Sense result for this packet command.\r
 \r
   @retval EFI_SUCCESS      Device is accessible.\r
   @retval EFI_DEVICE_ERROR Device is not accessible.\r
@@ -851,17 +851,11 @@ AtapiTestUnitReady (
   pointer pointing to IDE_BLK_IO_DEV data structure, used\r
   to record all the information of the IDE device.\r
 \r
-  @param[out] **SenseBuffers\r
+  @param[out] **SenseCounts\r
   allocated in this function, and freed by the calling function.\r
   This buffer is used to accommodate all the sense data returned \r
   by the device.\r
 \r
-  @param[out] *BufUnit\r
-  record the unit size of the sense data block in the SenseBuffers,\r
-\r
-  @param[out] *BufNumbers\r
-  record the number of units in the SenseBuffers.\r
-\r
   @retval EFI_SUCCESS\r
   Request Sense command completes successfully.\r
   \r
@@ -961,7 +955,7 @@ AtapiRequestSense (
 \r
   @param[in] *IdeDev    Pointer pointing to IDE_BLK_IO_DEV data structure, used\r
                         to record all the information of the IDE device.\r
-  @param[in] SResult    Sense result for this packet command\r
+  @param[out] SResult   Sense result for this packet command\r
 \r
   @retval EFI_SUCCESS      Read Capacity Command finally completes successfully.\r
   @retval EFI_DEVICE_ERROR Read Capacity Command failed because of device error.\r
@@ -1657,7 +1651,7 @@ AtapiSoftReset (
   This function is the ATAPI implementation for ReadBlocks in the\r
   Block I/O Protocol interface.\r
 \r
-  @param[in] *IdeBlkIoDev\r
+  @param[in] *IdeBlkIoDevice\r
   Indicates the calling context.\r
 \r
   @param[in] MediaId\r
@@ -1795,7 +1789,7 @@ AtapiBlkIoReadBlocks (
   //\r
   // save the first block to the cache for performance\r
   //\r
-  if (LBA == 0 && !IdeBlkIoDevice->Cache) {\r
+  if (LBA == 0 && (IdeBlkIoDevice->Cache == NULL)) {\r
     IdeBlkIoDevice->Cache = AllocatePool (BlockSize);\r
     if (IdeBlkIoDevice != NULL) {\r
       CopyMem ((UINT8 *) IdeBlkIoDevice->Cache, (UINT8 *) Buffer, BlockSize);\r
@@ -1810,7 +1804,7 @@ AtapiBlkIoReadBlocks (
   This function is the ATAPI implementation for WriteBlocks in the\r
   Block I/O Protocol interface.\r
 \r
-  @param[in] *This\r
+  @param[in] *IdeBlkIoDevice\r
   Indicates the calling context.\r
 \r
   @param[in] MediaId\r
@@ -1869,7 +1863,7 @@ AtapiBlkIoWriteBlocks (
   EFI_STATUS          Status;\r
   BOOLEAN             MediaChange;\r
 \r
-  if (LBA == 0 && IdeBlkIoDevice->Cache) {\r
+  if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) {\r
     gBS->FreePool (IdeBlkIoDevice->Cache);\r
     IdeBlkIoDevice->Cache = NULL;\r
   }\r
@@ -1890,7 +1884,7 @@ AtapiBlkIoWriteBlocks (
   Status      = AtapiDetectMedia (IdeBlkIoDevice, &MediaChange);\r
   if (EFI_ERROR (Status)) {\r
 \r
-    if (LBA == 0 && IdeBlkIoDevice->Cache) {\r
+    if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) {\r
       gBS->FreePool (IdeBlkIoDevice->Cache);\r
       IdeBlkIoDevice->Cache = NULL;\r
     }\r
@@ -1906,7 +1900,7 @@ AtapiBlkIoWriteBlocks (
 \r
   if (!(Media->MediaPresent)) {\r
 \r
-    if (LBA == 0 && IdeBlkIoDevice->Cache) {\r
+    if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) {\r
       gBS->FreePool (IdeBlkIoDevice->Cache);\r
       IdeBlkIoDevice->Cache = NULL;\r
     }\r
@@ -1915,7 +1909,7 @@ AtapiBlkIoWriteBlocks (
 \r
   if ((MediaId != Media->MediaId) || MediaChange) {\r
 \r
-    if (LBA == 0 && IdeBlkIoDevice->Cache) {\r
+    if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) {\r
       gBS->FreePool (IdeBlkIoDevice->Cache);\r
       IdeBlkIoDevice->Cache = NULL;\r
     }\r
@@ -2073,7 +2067,7 @@ AtapiReadPendingData (
 \r
   @retval  EFI_DEVICE_ERROR TODO: Add description for return value\r
   @retval  EFI_DEVICE_ERROR TODO: Add description for return value\r
-  @retval  EFI_SUCCESS TODO: Add description for return value\r
+  @retval  EFI_SUCCESS TODO: Add description for return value.\r
 \r
 **/\r
 EFI_STATUS\r